Current File : //usr/share/doc/net-snmp/ChangeLog.trimmed
# -*- text -*-
----------------------------------------------------------------------
Changes: V5.9.1.rc1 -> V5.9.1
commit 2eed7fe490bb6735a6c94b0cf03d9ff5d7884087
Author: Wes Hardaker <opensource@hardakers.net>
Date: Tue May 25 14:49:51 2021 -0700
remove the RC flag
commit d9d7b9b63b7b5c7be1b6de675b94f3f0ef7596ae
Author: Wes Hardaker <opensource@hardakers.net>
Date: Tue May 25 14:49:10 2021 -0700
Version number update: 5.9.1
----------------------------------------------------------------------
Changes: V5.9.1.pre1 -> V5.9.1.rc1
commit 05617ca6fd1d8355663de48280ade58d49050d33
Author: Wes Hardaker <opensource@hardakers.net>
Date: Wed Apr 28 14:15:15 2021 -0700
Release Candidate for V5-9-patches
commit c371b1d7aa174871367b2a5de23431cf7348f1a4
Author: Wes Hardaker <opensource@hardakers.net>
Date: Wed Apr 28 14:15:13 2021 -0700
Version number update: 5.9.1.rc1
commit 5ceb3ebc2fe138d35a498f402254335baffecee5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 15 10:30:04 2021 -0700
ci/build.sh: Disable parallel compilation for minimalist mode
commit f69daae8a958daa8b50e8767da216ef9570b2e6c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 15 10:45:39 2021 -0700
Run 'make distdepend'
commit 9f1d8188bae2990b42f8aef1c4f65dd18c1c1924
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 15 09:29:30 2021 -0700
Makefile.rules: Retain only -D and -I options when regenerating dependencies
The 'makedepend' command accepts the cc -D and -I options but not the other
options that may occur in $(CPPFLAGS) (-f, -g, -O, -pipe, ...).
commit 9ea3d8b93c9bb7da7fea13ee6c92356a6b82a5fb
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 14 20:03:15 2021 -0700
Makefile.in: Make sure that 'sedscript' is built before subdirectories
This is a follow-up for commit 855e1c28dad5 ("Makefile.in, agent/Makefile.in:
Fix parallel compilation").
commit 4fba346d04c26154098b917ad8769515e3766061
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 14 17:50:59 2021 -0700
Windows: Unbreak the build
Fixes: d6fac610cdea ("Fix the crash of snmpd when snmptrapd terminates the TCP connection.")
commit 93ea661906fb25657a63cfd757ef7a04c4dd0b33
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 14 16:12:43 2021 -0700
snmpd, FreeBSD 13: Make sure that filesystem statistics are up to date
Make snmpd report the current statistics instead of statistics cached at
mount time by the operating system.
Fixes: https://github.com/net-snmp/net-snmp/issues/282
commit bd5bc2df5d39a5c730a86f1c452b69f35841fdba
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 14 09:51:18 2021 -0700
ci/build.sh: Enable parallel compilation
commit 855e1c28dad53d6263c6c0c302438d2dc3128cc5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 14 09:35:24 2021 -0700
Makefile.in, agent/Makefile.in: Fix parallel compilation
See also https://github.com/net-snmp/net-snmp/issues/283 .
commit ec9068cd270677860e5832bee791a40ec33e08b2
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Apr 13 08:59:13 2021 -0700
ci/openssl.bat: Bump the OpenSSL version
commit 021d10edbf0c4b7754b994ad0e0ffb090f6dac32
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Apr 13 08:59:13 2021 -0700
ci/openssl.bat: Bump the OpenSSL version
commit 6a77db5c7dc4e31afb6bca93c5394f224c55a179
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 12 21:41:15 2021 -0700
UCD-SNMP-MIB: Let configure detect whether or not getmntinfo() is available
----------------------------------------------------------------------
Changes: V5.9 -> V5.9.1.pre1
commit f9312b44b71ddd247a98c6aff3e986d027e7eaa4
Author: Wes Hardaker <opensource@hardakers.net>
Date: Mon Apr 5 16:31:47 2021 -0700
version update for 5.9.1.pre1
commit 3080795082e347504a3cd290f840b6b024d729df
Author: Wes Hardaker <opensource@hardakers.net>
Date: Mon Apr 5 16:30:09 2021 -0700
fix comment to C
commit 0b886fc4d842f0f434606c4d35e610341cb650f7
Author: Wes Hardaker <opensource@hardakers.net>
Date: Mon Apr 5 15:38:35 2021 -0700
Version number update: 5.9.1.pre1
commit b5429f6d8556f05100eadec681680df215a2d9e8
Author: Wes Hardaker <opensource@hardakers.net>
Date: Mon Apr 5 15:38:24 2021 -0700
version update for 5.9.1.pre1
commit f36a9c4a747863d0c258a7a816381c9f15781f3c
Author: Tobias Deiminger <tobias.deiminger@rohde-schwarz.com>
Date: Wed Oct 7 08:36:40 2020 +0200
Fix regex for "-l" discovery in setup.py
This prevents setup.py from discovering wrong library link options (-l, -L)
in the middle of a word, like "inux-gnu" from "-L/usr/lib/x86_64-linux-gnu".
For net-snmp-config output as follows (real world example from Ubuntu 18.04):
"-Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -L/usr/lib/x86_64-linux-gnu -lnetsnmp -lcrypto -lm"
the former regex "-l(\S+)" would match to
['inux-gnu', 'netsnmp', 'crypto', 'm']
which obviously results in a ld error "cannot find -linux-gnu".
Now we capture a string only, if "-l" is at the beginning of a string,
or if "-l" is preceeded by any number of whitespace characters.
commit c2db3407dd4dd1a288042b06967a35712004e093
Author: Ferenc Wágner <wferi@debian.org>
Date: Mon Mar 15 18:00:48 2021 +0100
Enable systemd socket activation for UDP sockets
Like it was possible for UNIX and TCP sockets beforehand.
commit a9cf25db7e3e969dbcd9bda9a16457db6fc7210f
Author: Josef Řídký <jridky@redhat.com>
Date: Mon Mar 15 09:23:41 2021 +0100
net-snmp-cert: Use sha512 as default option for generating certificates.
Fixes: https://github.com/net-snmp/net-snmp/issues/231
[ bvanassche: edited commit message ]
commit eb1b11bb7f3ac3281dc6e92d94e8fa749cac44e0
Author: Josef Řídký <jridky@redhat.com>
Date: Fri Mar 12 10:15:30 2021 +0100
Prevent parsing IP address twice (#199)
This fixes issue, that is caused by parsing IP address twice.
First as IPv4 and as IPv6 at second, even thow the address was
properly parsed as a valid IPv4 address.
commit dce7b17e7ce7b12954a8c799265d3001922bb0a1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Mar 3 20:24:05 2021 -0800
ci/build.bat: Fix the Cygwin build
commit dc58ed9990a1736b9b500a5e16e7517f93d194f4
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Mar 3 19:10:25 2021 -0800
net-snmp-create-v3-user: Print the version number once
Print the version number once instead of keeping to print the version number
forever in an endless loop.
Fixes: https://sourceforge.net/p/net-snmp/bugs/2778/
commit afa2034ca57b7986e91272b56274cebff5d8d69f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 27 21:25:44 2021 -0800
ci/openssl.bat: Bump the OpenSSL version
commit 8c301c1e06004aa4095f956bff5f399104e71127
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 27 19:46:13 2021 -0800
IF-MIB: Do not scan for PCI devices if no PCI bus is available
Fixes: https://github.com/net-snmp/net-snmp/issues/271
commit 385d555606ee31a23d5ed711a7ffba45f4197d50
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Feb 15 08:44:13 2021 -0800
Perl: Only use $prefix on Unix systems
This patch reworks commit f64e0111ad10 ("Perl: Set the $prefix variable on
Windows").
commit f64e0111ad10b948aeadd386063a69ba5fc7fc7b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 13 20:04:29 2021 -0800
Perl: Set the $prefix variable on Windows
Fixes: https://github.com/net-snmp/net-snmp/issues/261
commit 428a486d92ca631d83f5bfc42c319f630b152bea
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 13 19:19:19 2021 -0800
Python: Use netsnmp_memdup() instead of open-coding it
commit 6ad61e6628ecf1bde987c78de37674c4886a16b9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 13 19:35:57 2021 -0800
Python: Do not report "error: set: adding variable/value to PDU" when clearing an OCTETSTR
Fixes: https://github.com/net-snmp/net-snmp/issues/265
commit ddd338fab038bf0ea25426d43518f4f24ac20853
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 13 19:19:01 2021 -0800
python/netsnmp/tests/test.py: Add a test for setting an OCTETSTR
commit f03582450d1eabae6df66b1fde5699a8e2a97b81
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 13 11:02:37 2021 -0800
snmplib: Add more comments in netsnmp_random()
commit b754da08461bd062632924fb773cb6f7c8c348d7
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 13 09:24:12 2021 -0800
Enable the compiler flag -Wtype-limits
commit b71b52f03398f2c42f100dd960009b824e6c306b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 13 09:22:54 2021 -0800
Fix the -Wtype-limits compiler warnings
commit a29685e5a35ff4a88b396e7952e59b53b9c24ebd
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 13 08:29:48 2021 -0800
configure: Only display the message "Checking for developer gcc flags" in developer mode
commit 0dcebaf3d4b142638cd86de725ef23372495005f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Feb 12 20:55:42 2021 -0800
python/netsnmp/tests/test.py: Also perform a full MIB walk
commit 8d8d8439d5d211ec1782d609e0ad67180c975d7b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Feb 12 19:49:18 2021 -0800
HOST-RESOURCES-MIB: Add JFFS2 support
Fixes: https://github.com/net-snmp/net-snmp/issues/268
commit d468c8ad86c86ceb1807ccd51408594526940137
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Feb 12 19:35:44 2021 -0800
HOST-RESOURCES-MIB: Simplify the code for recognizing "other" filesystems
commit 02bc1baf0d4f6031085e107a9cddc05dfbd74db2
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jan 10 16:58:09 2021 -0800
snmpd: Exclude the /dev/kmem code if configured with --without-kmem-usage
This is a follow-up for 9e933893751f ("snmpd: Exclude the /dev/kmem code if
configured with --without-kmem-usage").
Fixes: https://github.com/net-snmp/net-snmp/issues/251
commit 4d92f40112dd768d89a9f0a20cf743b18d951e45
Author: Filip Jensen <vivamudhoney@yahoo.es>
Date: Tue Jan 5 16:57:43 2021 +0100
Fix compilation when feature NETSNMP_FEATURE_REMOVE_LOGGING_STDIO is used
commit e3601420c8fce713924038901f824e57e6855e72
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jan 4 13:01:47 2021 -0800
Revert "Read intermediate certificates from PEM files"
This reverts commit 916110b15f28f8ae04598ad637ac26e4585ff385 and thereby
removes support for intermediate certificates from the v5.9 branch.
commit 2b93ee55d1b9b32c86c3f725c59b8fd17912ae18
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jan 4 13:01:42 2021 -0800
Revert "libsnmp: Fix a NULL pointer dereference in an error path"
This reverts commit 99a72177c7c69c5ca1a5ecb68f5f2db7d971e97a.
commit baef04f9c6fe0eb3ac74dd4d26a19264eeaf7fa1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jan 4 10:00:33 2021 -0800
testing/fulltests/unit-tests/T105trap_parse_clib: Add this test
Add a reproducer for the bug fixed by the previous patch.
commit 92f0fe9e0dc3cf7ab6e8cc94d7962df83d0ddbec
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jan 4 12:21:59 2021 -0800
libsnmp: Fix asn_parse_nlength()
Handle length zero correctly.
Fixes: https://github.com/net-snmp/net-snmp/issues/253
Fixes: a9850f4445cf ("asn parse: add NULL checks, check length lengths")
commit 1bf7c9c81d988e7945a34bea666ca3428c1ac127
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jan 4 12:17:58 2021 -0800
libsnmp: Simplify _asn_short_err()
Since snprintf() always '\0'-terminates the string it produces explicit
'\0'-termination is not necessary.
commit 34c3b4ee104a1239c7bff7f6c80ca8b05b3bf17a
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jan 4 12:13:26 2021 -0800
libsnmp: Add SNMPv1 trap support in snmp_pdu_type()
This change only affects error messages and debug messages.
Fixes: 00ef569e00d1 ("Fix 5.5.x branch structure (part 2)")
commit 9e933893751fb5b1b68c6efb844ef5d4b3a905e0
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jan 3 13:42:59 2021 -0800
snmpd: Exclude the /dev/kmem code if configured with --without-kmem-usage
See also https://github.com/net-snmp/net-snmp/issues/251 .
commit 99a72177c7c69c5ca1a5ecb68f5f2db7d971e97a
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Dec 30 13:03:30 2020 -0800
libsnmp: Fix a NULL pointer dereference in an error path
This issue was detected by Coverity.
Fixes: 916110b15f28 ("Read intermediate certificates from PEM files")
commit 916110b15f28f8ae04598ad637ac26e4585ff385
Author: minfrin <minfrin@users.noreply.github.com>
Date: Wed Dec 30 17:48:39 2020 +0000
Read intermediate certificates from PEM files
This patch lifts the restriction that a PEM file can only contain
one certificate. This brings net-snmp in line with the behaviour
of other applications that use PEM files.
Multiple certificates are read from each file, and the offset of
each certificate is added to the index for efficient retrieval.
The first certificate in the chain is eligible to be either an
identity certificate or a remote certificate. Intermediate
certificates are ignored for this purpose, maintaining existing
behaviour with respect to peerCert and remoteCert.
Trusted CA certificates are still required to be listed one per
file, this restriction will be lifted in a separate patch.
[ bvanassche: modified this patch such that the size of struct
netsnmp_cert_common_s does not change ]
commit e96087f1aa70583fe3142a2919fc3a69e62c53bb
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Dec 30 10:52:30 2020 -0800
TLSTM-MIB: Remove an unused member variable
commit 951fd2d9b07e29455ff0251b0f44ed76d935ff00
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Dec 29 15:22:42 2020 -0800
snmpd: Restore SNMPD_CALLBACK_SEND_TRAP[12] behavior
Instead of only invoking the SNMPD_CALLBACK_SEND_TRAP[12] callbacks if one
or more sessions with the corresponding SNMP version exist, invoke these
callbacks unconditionally.
Fixes: f770e0f74932 ("skip send_trap callbacks if no sessions for version")
Fixes: https://github.com/net-snmp/net-snmp/issues/247
commit 22f0630371231787f59522f4a3c4d1bb04594c66
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Dec 26 16:19:37 2020 -0800
ci: Overwrite /etc/hosts
Overwrite /etc/hosts instead of using the /etc/hosts file provided by the
CI service. This should fix sporadic OS/X test failures.
commit b3dd620161703a6ade14b5afe0e8f6fd63685a81
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Dec 26 16:07:34 2020 -0800
libsnmp, UDP: Only display VRF debug messages if relevant
Only display a VRF debug message if a VRF interface has been specified.
Fixes: 02de400544de ("libsnmp: Set Linux VRF iface on Trap sink IP addresses")
commit ac06c5844105473e211decdf825af75dc7cd8b7c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Dec 25 17:19:35 2020 -0800
Perl: Rework the authentication / privacy algorithm lookup code
Use the tables defined in snmplib/scapi.c instead of duplicating these tables.
commit 6ea6935621a05c845e6829b18c833cdb9c7baa55
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Dec 25 17:19:45 2020 -0800
libsnmp: Constify the authentication and privacy data structures
Prevent that scapi users modify data structures that should not be modified.
This patch modifies the Net-SNMP API but not the ABI.
commit 92012951687cb18c8e58fede015e4bc0a9222e73
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Dec 26 09:25:33 2020 -0800
libsnmp: Export sc_find_auth_alg_byoid() and sc_find_auth_alg_bytype()
Fix two typos in include/net-snmp/library/scapi.h.
Fixes: 329a9d3c9d63 ("revamp auth/priv protocol constants handling")
commit 4da46332f324eb5f18513d0e7e1368e529b29aef
Author: minfrin <minfrin@users.noreply.github.com>
Date: Tue Dec 22 12:03:22 2020 +0000
Add support for intermediate certificates
After constructing a certificate chain, pass the chain to openssl so the chain
is taken into account while negoiating SSL. Required to support certificates
generated by a PKI, or by a CA like Let's Encrypt.
Fixes: https://github.com/net-snmp/net-snmp/issues/241
Fixes: https://github.com/net-snmp/net-snmp/issues/242
[ bvanassche: slightly edited commit message ]
commit 969226ea501b92e1a2ed427bc1a46f18ef2890b7
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Dec 18 10:25:20 2020 -0800
libsnmp, _cert_get_extension(): Consolidate error paths
This patch does not change any functionality.
commit bb30f8ee0075750fd3648a6bf3fab543f46152ed
Author: minfrin <minfrin@users.noreply.github.com>
Date: Thu Dec 17 12:25:24 2020 +0000
libsnmp, SSL: Increase extension buffer size to prevent a crash
Make sure enough space is allocated for extensions longer than 512 bytes. Fix
the error message when the extension is too long to clearly differentiate the
error from the out of memory case. Fix a crash when the extension is too long.
[ bvanassche: edited patch description / fixed an off-by-one error / undid a
code formatting change ]
commit 4c5d2ceae4d4a8b77db48fc8fff77e14943ff4d3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Dec 16 19:36:55 2020 -0800
libsnmp: Handle certificate loading errors gracefully
Instead of crashing (SIGSEGV), skip certificates if loading fails.
Reported-by: https://github.com/minfrin
Fixes: https://github.com/net-snmp/net-snmp/issues/233
commit 9d001c34196df47526260441af35a509a325e41f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Dec 16 19:32:58 2020 -0800
libsnmp: Fix spelling in an error message
Reported-by: https://github.com/minfrin
commit bcc654e704f4794a9b10b8abf6e01f509402a6d3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Dec 13 12:06:45 2020 -0800
Darwin, ARM: Fix the 64-bit build
See also the following two commits:
* 632b143b0005 ("memory_darwin: Suppress a compiler warning")
* 8ae78da391d5 ("Use vm_region_64 on 64-bit arch; cache memory for longer")
commit f82634a1ca4a24601cd966abe4062c35e376c9ab
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Dec 13 09:58:28 2020 -0800
perl: Rework the authentication and privacy code
Switch to a table-based approach. This patch does not change any functionality.
commit cf125fee113ef9e361af51b916166990b5abeda2
Author: garnier-quentin <garnier.quentin@gmail.com>
Date: Tue Dec 8 16:10:46 2020 +0100
perl: Add support for strong SHA authentication
[ bvanassche: edited commit message, combined three patches into one and left
out whitespace-only changes ]
commit a7c8c26c48c954a19bca5fdc6ba285396610d7aa
Author: Mitchell Blank Jr <mitch@bodyfour.com>
Date: Sun Dec 13 03:23:02 2020 +0000
Fix compiler warnings generated by configure scripts
Specifically, this is meant to reduce risk of issues with Xcode 12
which has made -Werror,-Wimplicit-function-declaration a default.
Normally this doesn't bite "real" code since such a warning would be
visible for a long time with most compilers. However, inside of
configure scripts these sorts of warnings just end up in config.log
and usually get ignored. Now that they produce errors it means that
configure tests that *should* pass suddenly fail, causing very
strange failures later on.
This can be as simple as calling "exit(0);" inside of a test C
program without doing "#include <stdlib.h>" first!
I also fixed an implicit-int-return warning since that is another
C behavior that was deprecated long ago and future compilers might
consider that an error.
[ bvanassche: reran autoconf ]
commit cc3e0505f58d2c5d03be7a0b4c70afd01f7deb3c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Dec 12 18:41:45 2020 -0800
Windows: Yet another Visual Studio 2005 build fix
Microsoft Visual Studio 2013 and before do not support __func__. Hence
use __FUNCTION__ instead of __func__ when building with Visual Studio.
Reported-by: Christophe Cassignol
Fixes: 6066c6e21991 ("libsnmp, snmpv3_packet_build(): Avoid triggering a buffer overflow")
Fixes: 20725d58ca76 ("DTLSUDP transport: Check length of from address")
commit 7137ee0b94ff5eab0682e5a63d5e9d6eb2b6fea9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Dec 12 18:20:46 2020 -0800
ci/openssl.bat: Bump the OpenSSL version
commit 3617459d1d204f3e595c794a2642bd9536c86245
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Dec 12 14:38:28 2020 -0800
Windows: Fix Visual Studio 2005 build
Reported-by: Christophe Cassignol
Fixes: 193062739789 ("Net-SNMP headers: Move in_addr_t definition into <net-snmp/net-snmp-config.h>")
commit 64bbd86fc13517c5021096acfbb23577bbd0f8a8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Nov 30 19:41:27 2020 -0800
Python: Handle hex strings correctly
See also https://github.com/net-snmp/net-snmp/issues/216 .
commit c744be5ffed64f992a843e858a3cd2c1fe80f12f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Dec 1 20:19:17 2020 -0800
Python: Introduce build_python_varbind()
This patch does not change any functionality.
commit d519f4cf41c6b94661259409942fcdea46cf384d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Dec 1 19:27:55 2020 -0800
Python: Merge netsnmp_get() and netsnmp_getnext() into a single function
This patch does not change any functionality.
commit 281e6fc9454a785d9a4487d35146724dadcfbf62
Author: Johnnyxy <Johnnyxy@github.com>
Date: Thu Nov 19 17:43:13 2020 -0800
Win32, MSVC: Use <stdint.h> if it is available
See also https://github.com/net-snmp/net-snmp/issues/213 .
commit a54c03aa0564e3aeb53712228522c2ba9b0f971f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Nov 18 21:05:13 2020 -0800
net-snmp-create-v3-user: Fix multiple shellcheck warnings
commit 09a0c9005fb72102bf4f4499b28282f823e3e526
Author: Josef Ridky <jridky@redhat.com>
Date: Wed Nov 18 20:54:34 2020 -0800
net-snmp-create-v3-user: Handle empty passphrases correctly
See also https://github.com/net-snmp/net-snmp/issues/86.
Fixes: e5ad10de8e17 ("Quote provided encryption key in createUser line")
Reported-by: Chris Cheney
commit ebe677ea1be61df6589a28a5b6306fe55f5784b2
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Nov 18 19:36:17 2020 -0800
CHANGES: snmpd: Fix OID handling in header_simple_table()
Process GETNEXT for OIDs like 1.3.6.1.4.1.2021.9.1.1.4294967295 correctly.
Additionally, handle *length == 0 correctly.
See also https://github.com/net-snmp/net-snmp/issues/210 .
commit a8cb3591a924aeda1fd777f555da31ad8a627722
Author: Josef Ridky <jridky@redhat.com>
Date: Mon Nov 9 19:42:32 2020 -0800
IP-MIB: Improve handling of IPv6 support having been disabled intentionally
See also https://github.com/net-snmp/net-snmp/issues/190
[ bvanassche: modified variable names and source code comment ]
commit 325b0df837197fd8f9af23eee838daae3ff80753
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Nov 6 20:45:07 2020 -0800
snmpd: Use sigprocmask() instead of sighold() and sigrelse()
The latter two functions are obsolete, hence use sigprocmask() instead.
commit 5a18e300bd085c6ba5967d7b00cc3f57fe83f665
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Oct 8 20:12:44 2020 -0700
HOST-RESOURCES-MIB: Add support for f2fs
See also https://github.com/net-snmp/net-snmp/issues/111 .
commit b1569c31514bf76fceb93f80c8b844101ee55e3a
Author: Pavel Trushkin <pavel@dcmsys.com>
Date: Wed Sep 2 12:58:03 2020 +0300
fix the similar leak in SNMP::NODE::FETCH
commit 581698a162b47b08f8571c7e1b8991df0764e5d3
Author: Pavel Trushkin <pavel@dcmsys.com>
Date: Wed Sep 2 12:47:07 2020 +0300
fix resource leaks in the SNMP::Session destructor and SNMP::NODE::FETCH
commit 5adc5bbcec46eacf654ed92ed2431d0965076fa9
Author: Guillem Jover <gjover@sipwise.com>
Date: Fri Apr 22 15:45:07 2016 +0200
Perl, agent: Make the perl agent code more tolerant of perl types
The code is currently very strict, and does not accept several internal
perl representations for integer scalars.
First we should use SvPOK instead of SvPOKp to accept anything that
looks like a string. And then we should also accept floating point
numbers because they might store integer or unsigned values.
commit d59ae433af8b6d9051d149ca2a745fc845e7c82d
Author: Guillem Jover <gjover@sipwise.com>
Date: Fri Apr 22 15:45:07 2016 +0200
Perl, agent: Print the perl scalar flags on type mismatch in setValue
This makes it easier to debug why a type mismatch happened, as we can
see how the type is represented internally by perl.
commit 4d686f50d165f6b2b8fc79c9ae8f0a5702644fd8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Sep 27 19:24:19 2020 -0700
ci/openssl.bat: Bump the OpenSSL version
commit b65fc0f848142543314329ca286fb90fc5f87773
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Sep 27 14:06:46 2020 -0700
configure: Update config.guess to the latest version
Update config.guess to commit 4aa554d72b2a ("config.guess: Don't use
'ldd --version' to determine the presence of musl libc") from
https://git.savannah.gnu.org/gitweb/?p=config.git to fix compatibility
with the aarch64 architecture. See also
https://github.com/net-snmp/net-snmp/issues/188.
commit 62f024175a73c9b669f9bd8c7e75a65017622f3a
Author: urs-k <71150165+urs-k@users.noreply.github.com>
Date: Wed Sep 16 08:54:57 2020 +0200
snmpd: Fix a memory leak in ipAddressPrefixTable_data_access.c
See also https://github.com/net-snmp/net-snmp/pull/183.
[ bvanassche: adjusted commit message and reindented code ]
commit b30e5b6c682e7095d61401461d9305dbfe99e914
Author: Magnus Fromreide <magfr@lysator.liu.se>
Date: Fri Aug 14 00:39:34 2020 +0200
Do not require privacy in T0222
commit d1578077f41f232831b9b68fea2cc75f39569fe2
Author: Magnus Fromreide <magfr@lysator.liu.se>
Date: Mon Sep 7 08:25:42 2020 +0200
Correct the name of the V5-9-patches branch
commit 8fabe044e316f9ecda53148d9afeaf5e5854bb1a
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Sep 6 14:21:52 2020 -0700
agent/mibgroup/util_funcs: Use posix_spawn() if fork() is not available
This patch restores pass_persist support for operating systems that do
not support fork(), e.g. uClinux. The pass_persist support added by this
patch is much more useful than the implementation removed by commit
e55d56212b72 ("snmpd: Remove the uClinux code from get_exec_pipes()").
The new implementation uses anonymous pipes while the old implementation
used named pipes with hardcoded paths (/flash/cp_%d and /flash/pc_%d).
commit 537ae2f0b64f067d354db34a742a28260aa21aa1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Sep 6 14:29:53 2020 -0700
agent/mibgroup/util_funcs: Use dup2() instead of dup()
This patch makes the code easier to read but does not change any
functionality.
commit e34f0793b641998eb4f9bedb4f7929bb0e3051b8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Sep 6 15:13:58 2020 -0700
libsnmp: Allocate the module import list on the heap
Since that list occupies 8 KiB, allocate it on the heap instead of on the
stack.
commit ed4c8e85cb44e84ada5b8d2ff58e903de7ede737
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Sep 6 15:12:48 2020 -0700
libsnmp: Rework parse_imports()
Do not cast pointers passed to free(). Reduce the number of return
statements in this function to one. Surround multiline statements with
braces.
commit 52d4a465dcd92db004c34c1ad6a86fe36726e61b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Sep 4 13:44:51 2020 -0700
Darwin: Fix 'make install'
Only attempt to install header files that exist under
include/net-snmp/system/
See also https://github.com/net-snmp/net-snmp/issues/181 .
Fixes: f01c45c53cdc ("Darwin: Unify system header files")
commit 687b8c894f0de93b12f16ab9d5d9635adea39a6f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Sep 4 15:11:22 2020 -0600
OpenBSD: Fix a build error and a compiler warning
commit ee7c66cf856dcda14f6d1d1503b80c0535509bc3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Sep 4 13:32:54 2020 -0700
OpenBSD: Do not use the linker flag -no-undefined
This patch fixes a linker error on OpenBSD.
See also https://github.com/net-snmp/net-snmp/issues/178 .
commit 893b9baa6ae81a877e76842c29a637eeb2cbd0e2
Author: Guido Jäkel <g.jaekel@dnb.de>
Date: Thu Sep 3 17:03:33 2020 +0200
libsnmp: Increase MAX_IMPORTS
Today, I stepped into an well-known old issue
(https://sourceforge.net/p/net-snmp/mailman/message/16927159/) using MIBs
for a CISCO device.
[bvanassche: edited commit message]
commit 6093d4aee5cc81b8121458864d7e25fa7f46a7ba
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Aug 31 20:46:21 2020 -0700
libsnmp: Handle malloc() failure correctly in snmp_parse_oid()
See also https://github.com/net-snmp/net-snmp/issues/177 .
commit 205c69a652d742d4914a4332ecc8915b52217719
Author: mark123499 <32741576+mark123499@users.noreply.github.com>
Date: Thu Aug 27 15:19:11 2020 +0900
snmpd: avoid container double free in error cases
Fixes: ad653fb4618d ("new data access files")
[ bvanassche: Added "Fixes" tag ]
commit 5b8bf5d4130761c3374f9ad618e8a76bb75eb634
Author: Yuwei Ba <i@xiaoba.me>
Date: Fri Aug 21 15:06:10 2020 +0800
snmpd: support MemAvailable on Linux
See also https://github.com/net-snmp/net-snmp/pull/167 .
[bvanassche: modified the behavior of this patch]
commit 410ddeff0b65937afd4bca6c7bfccc078fb5467d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Aug 28 20:28:04 2020 -0700
snmpd: Reindent agent/mibgroup/hardware/memory/hw_mem.c
Source code formatting in this file is weird. Reformat this source
file with the help of the command mentioned in the CodingStyle file.
commit f73dbd3998755fe141ba724445b0cb74df1939f4
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Aug 26 13:00:27 2020 -0700
libsnmp: Use snprintf() instead of sprintf() in print_tree_node()
This patch suppresses certain static analyzer complaints. See also
https://github.com/net-snmp/net-snmp/issues/173 .
commit b14ff16eee753b29ef7659b34a67af89acee22f7
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Aug 14 09:30:06 2018 -0700
snmplib, IPv6: Fix MSVC build
Fixes: 4916ce007362 ("Fix Solaris compiler warnings")
Reported-by: Gisle Vanem <gvanem@yahoo.no>
commit c13b4349fad05caaa97e69924c020cb02139a367
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Aug 26 07:58:03 2020 -0700
Solaris: Fix a compiler warning
commit 7f5b50d5c51572f59d4b8c799cc6a676b0f1340f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jun 24 10:46:44 2018 -0700
Fix Solaris compiler warnings
This patch does not change any functionality.
commit adf7fda1f6b7123494875e8cd19b7445427b28ad
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Aug 24 19:40:48 2020 -0700
snmpd, snmptrapd: Fix a bug in an error path of parse_cmd()
Fixes: 11e119c802e5 ("snmpd, util_funcs: Introduce the parse_cmd() function")
commit ec28fff5c0dede00767b50cebe8959369e6d7035
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Aug 24 15:07:02 2020 -0700
libsnmp: Fix handling of the minus character in mib configuration directives
Change one occurrence of 'confmibdir' into 'confmibs'. It seems like the
original code is the result of a copy/paste error. See also
https://github.com/net-snmp/net-snmp/issues/170.
Fixes: 4253c5431631 ("make mibs, mibdirs and mibfiles handling consistent")
commit f43a7213badf0b4014bb744021199fb2a127efff
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Aug 24 06:58:04 2020 -0700
snmpd, snmptrapd: Let configure check whether getdtablesize() is available
This patch fixes the Net-SNMP build for termux.
See also https://github.com/net-snmp/net-snmp/issues/155.
commit 6bf543981b59f0048c640203b620c49db4c97d09
Merge: 29a707be5 7266ff58d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 22 15:15:53 2020 -0700
Merge branch 'V5-8-patches' into V5-9-patches
* V5-8-patches:
Windows: Unbreak the MSVC build of agent/mibgroup/agent/extend.c
commit 29a707be54d1df5b90ac1a5bc72ae919b015e63d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 22 15:09:55 2020 -0700
dist/svnup: Remove this script because is no longer needed
commit b04033209dc4ab9bdb4dffaf09b553438ac41797
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 22 10:46:01 2020 -0700
dist/net-snmp.spec: Improve the Net-SNMP RPM spec file
Use the local Net-SNMP source code archive instead of downloading it from
SourceForge. Only prefix the version number with %{epoch}: on RHEL / Fedora
systems. Package the pkg-config files (.pc). Fix multiple rpmbuild warnings.
commit 582b77e038ec63592a0a3e8b6bed069481e5776f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 22 10:34:41 2020 -0700
Makefile.in: Add 'rpm' make target
commit efd048bc43bd99b756a984a16e735395cac22e4a
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 22 10:16:06 2020 -0700
agent/mibgroup/versiontag: Switch from CVS to git
Instead of instructing the user to copy the Net-SNMP source files into a
subdirectory, create the tar archive from the source files administered
by git.
commit d5f6910373df6a8d501c402d29e038574d1e0975
Author: Craig Small <csmall@debian.org>
Date: Sat Aug 22 08:57:28 2020 -0700
Makefile.rules: Install the pkgconfig files as data files
See also https://github.com/net-snmp/net-snmp/issues/168 .
Fixes: 6e1329bde834 ("NEWS: Add pkg-config support for building applications and sub-agents")
[bvanassche: Added patch description]
commit 7266ff58d0a289ecff74492c39d60ed42da2e437
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 15 19:22:01 2020 -0700
Windows: Unbreak the MSVC build of agent/mibgroup/agent/extend.c
Fixes: 2703c379582f ("EXTEND MIB: Fix two recently introduced compiler warnings")
commit 5561bd1a35396fc36697a246bbb0ad391d5fc3e5
Merge: 8827eaf2b dc09b72c3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Aug 21 07:37:33 2020 -0700
Merge branch 'V5-8-patches' into V5-9-patches
* V5-8-patches:
UCD-SNMP proxy: Fix OID substitution
UCD-SNMP proxy: Document struct simple_proxy members
UCD-SNMP proxy: Remove an unused member from struct simple_proxy
commit dc09b72c32129e68c85d540e3dee64d4e9450910
Merge: 5287a8e10 b6f37de20
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Aug 21 07:32:59 2020 -0700
Merge branch 'V5-7-patches' into V5-8-patches
* V5-7-patches:
UCD-SNMP proxy: Fix OID substitution
UCD-SNMP proxy: Document struct simple_proxy members
UCD-SNMP proxy: Remove an unused member from struct simple_proxy
commit b6f37de20c46258aa081137cae2e670adce98254
Author: Josef Ridky <jridky@redhat.com>
Date: Fri Aug 21 07:27:16 2020 -0700
UCD-SNMP proxy: Fix OID substitution
See also https://github.com/net-snmp/net-snmp/issues/165.
This patch reverts commit 4eb12f0efedd ("we actually want to use the base
OID as the starting point, not the reg OID").
[bvanassche: Added commit message]
commit 11ee42c1f03fc0c779dacd2e852e44ba457f9457
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Aug 21 07:18:40 2020 -0700
UCD-SNMP proxy: Document struct simple_proxy members
commit e11dc1d9d3566cb1acbeb6bed9481ac3434b7b33
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Aug 21 07:19:22 2020 -0700
UCD-SNMP proxy: Remove an unused member from struct simple_proxy
This change does not affect the Net-SNMP ABI since the proxy.h header
file is a private header file.
commit 8827eaf2b93901987cb846b3255a99634833ab91
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Aug 16 17:04:25 2020 -0700
agent/mibgroup/ucd-snmp/pass_persist: Let configure check for waitpid()
commit f0b4b2c73059e3f9357d9a76472c45a80ed037a9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Aug 16 16:58:16 2020 -0700
agent/mibgroup/ucd-snmp/pass_persist: Simplify write_persist_pipe()
Do not ignore SIGPIPE since snmpd and snmptrapd already do this.
commit 9b33b399633e1fcea7e88d8b1a3aa774f03220c8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Aug 16 16:46:59 2020 -0700
agent/mibgroup/ucd-snmp/pass_persist: Simplify init_persist_pipes()
No functionality is changed.
commit c8eb12eaad9f5d18702545a0eb51a9e64266efb3
Author: Magnus Fromreide <magfr@lysator.liu.se>
Date: Sun Aug 16 16:44:37 2020 -0700
agent/mibgroup/ucd-snmp/pass_persist: Reduce the size of struct persist_pipe_type
Remove the fOut and fdIn members because these are not used.
[bvanassche: Added a patch description]
commit ffb91a5d41719cad5b687f70fed0b80cde5c535f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Aug 16 20:27:32 2020 -0700
agent/mibgroup/util_funcs: Split get_exec_pipes() in multiple functions
No functionality has been changed.
commit 80fed0e33eb2130d962d81375aee3f1bea2ec51c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Aug 16 20:09:13 2020 -0700
agent/mibgroup/util_funcs: Add a debug statement
commit 08864f1d3d0ba33a77e004285154223a8fd7a915
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Aug 16 20:18:12 2020 -0700
agent/mibgroup/util_funcs: Fix two recently introduced compiler warnings
Fixes: 11e119c802e5 ("snmpd, util_funcs: Introduce the parse_cmd() function")
Fixes: 9b1288216457 ("snmpd, util_funcs: Declare the first argument of get_exec_pipes() const")
commit 1b37bd3b9577d123ca1f7c60cc83a0836d7bd669
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Aug 16 08:33:19 2020 -0700
apps/snmpnetstat: Reindent source files
Indentation of the source files in the apps/snmpnetstat directory
does not follow the Net-SNMP coding style. Hence reindent these files
using the command mentioned in the CodingStyle file.
commit 1ee70571e0cae37f155f59d4382bc7109138cf09
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 15 17:29:25 2020 -0700
apps/snmpnetstat: Stop using obsolete signal functions
This was reported by Rosen Penev. See also
https://github.com/net-snmp/net-snmp/pull/162.
commit 9bee0e4bba190e9af3acf3f054f5a222bee3d7c3
Author: Bill Fenner <fenner@gmail.com>
Date: Tue Nov 6 08:28:02 2018 -0800
routex.c now uses the sockaddr_size feature
commit d7fa60b251059d3954c745477917fcefe7c7453c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Sep 23 14:34:49 2018 -0700
MinGW32, apps/snmpnetstat: Fix compiler warnings about format specifier mismatches
commit 99fedfe1238a7cc1bae4d44f49314a58a3649f73
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jun 23 18:19:41 2018 -0700
apps: Use getnameinfo() instead of netsnmp_gethostbyaddr() where appropriate
commit ef99ca519c780508f4c358200dc05c2227023215
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jun 23 19:23:25 2018 -0700
apps/snmpnetstat: Modify the argument types of inet6print() and inet6name()
This patch does not change any functionality.
commit dc08763e4616c31fd91bd7b2e38dceb716ab7fa0
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jun 23 19:05:33 2018 -0700
apps/snmpnetstat: Optimize the 127.0.0.1 comparison in inetname()
This patch does not change any functionality.
commit 475f0db2f2ff5dd66f02438ba9dd7b279738c1b1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jun 23 18:50:44 2018 -0700
apps/snmpnetstat: Constify several function arguments
commit 8f9acef689867b5a25d6cf0d15e02d863f53759c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jun 23 18:51:25 2018 -0700
apps/snmpnetstat: Use inet_ntoa() instead of open-coding it
commit 152de25d75f5419be296dcf5f98b1ae3ffaf9608
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 15 19:22:01 2020 -0700
Windows: Unbreak the MSVC build of agent/mibgroup/agent/extend.c
Fixes: 2703c379582f ("EXTEND MIB: Fix two recently introduced compiler warnings")
commit 11e119c802e54b108b6783e0834849c3926aaf6c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Aug 9 18:24:20 2020 -0700
snmpd, util_funcs: Introduce the parse_cmd() function
This patch does not change any functionality.
commit 9b1288216457083eaa58b258d2c4726de31abd25
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Aug 9 18:12:12 2020 -0700
snmpd, util_funcs: Declare the first argument of get_exec_pipes() const
This patch does not change any functionality.
commit e55d56212b7260bf2b6f71d3ddd86ab7b27363ff
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Aug 14 16:04:38 2020 -0700
snmpd: Remove the uClinux code from get_exec_pipes()
get_exec_pipes() is only used to open persistent pipes. So it is essential
to use fork(). Using vfork() in the implementation of get_exec_pipes() is
wrong because vfork() blocks the caller until the child process has
finished. Since the uClinux implementation of get_exec_pipes() uses
vfork(), remove the uClinux code from get_exec_pipes().
commit 26c1d4f2e58ce967c12a085784c86f9dd6ced862
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 8 10:54:57 2020 -0700
snmpd: Call fclose() after fdopen() but not close()
From https://pubs.opengroup.org/onlinepubs/9699919799/functions/fclose.html:
"The fclose() function shall perform the equivalent of a close() on the file
descriptor that is associated with the stream pointed to by stream."
Hence call fclose() but not close() if fdopen() succeeded.
See also https://github.com/net-snmp/net-snmp/issues/157 .
Fixes: fd9a42d142d8 ("- (pass-persist.c pass-persist.h): moved to pass_persist.[ch].")
Fixes: a36188e50dcc ("Patch #760417 from Bob Rowlands/Sun for fixing Bug #751920")
commit 51c40b7ad54dd77f0313e09c56a4b1ef761e6ab5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Aug 2 17:32:25 2020 -0700
TLSTM-MIB: Fix a Coverity use-after-free complaint
commit 99e31c39e5cfe649617fcc8f6bb9dec31b7de82f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Aug 2 16:55:19 2020 -0700
Handle MIB registration failures instead of ignoring these
This patch suppresses multiple Coverity 'use after free' complaints.
commit 02aee733f8d094749bd1fa4cf23fd53e6eff3f14
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 1 17:18:38 2020 -0700
libsnmp: Pass 0xff as second argument to memset() instead of '\xff'
This patch suppresses the following Coverity warning:
Memset fill truncated (NO_EFFECT)
bad_memset: Argument 4294967295 in memset loses precision in
memset(mask.__in6_u.__u6_addr8, 4294967295, j).
commit cd95f3065030e291122e4325f5ea69d3b2e9c619
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 1 17:15:37 2020 -0700
IF-MIB: Fix source code indentation
This was detected by Coverity.
commit 19d75e01fc72b6e03992207d68bd6649950c70b8
Author: Wes Hardaker <opensource@hardakers.net>
Date: Fri Aug 14 15:13:51 2020 -0700
change active branches to 5.9 and master
commit 0e6790c62ed89cc00bd0203a1bcd2b837fe3526e
Author: Wes Hardaker <opensource@hardakers.net>
Date: Fri Aug 14 15:12:03 2020 -0700
added a file to force-push a branch
----------------------------------------------------------------------
Changes: V5.9.rc2 -> V5.9
commit f68a967f6f3aa999f906cd986ffb83f36d37e98b
Author: Wes Hardaker <opensource@hardakers.net>
Date: Fri Aug 14 14:31:32 2020 -0700
v5-4 is no longer in release either
commit a93761876be67802598338bc92473d7df529b00e
Author: Wes Hardaker <opensource@hardakers.net>
Date: Fri Aug 14 14:31:16 2020 -0700
remove release from dist/release
commit b7f01b1134c7a8ed578f8ab9ebecafc85ab2a757
Author: Wes Hardaker <opensource@hardakers.net>
Date: Fri Aug 14 14:30:46 2020 -0700
Version number update: 5.9
commit b65b426f1a056b39286b57f8ad855c77e6dffe2e
Author: Wes Hardaker <opensource@hardakers.net>
Date: Thu Aug 6 14:07:23 2020 -0700
changelog
----------------------------------------------------------------------
Changes: V5.8.1.rc1 -> V5.9.rc2
commit d8dc063e6c41b870b84430e92ab0f5183f014e22
Author: Wes Hardaker <opensource@hardakers.net>
Date: Tue Aug 4 17:21:16 2020 -0700
autoconf
commit 7ba8a81fe24a60744ef7570f06c40de6cd4e4729
Author: Wes Hardaker <opensource@hardakers.net>
Date: Tue Aug 4 17:20:53 2020 -0700
Fix variable check to include an x prefix for safety
commit bbd53ed4a42929d0c93645e069b466daa4f0fbce
Author: Wes Hardaker <opensource@hardakers.net>
Date: Tue Aug 4 17:20:43 2020 -0700
network pcre detection
commit 8f371058e274f8a3cf1b293648b8eebc1086a2c9
Author: Wes Hardaker <opensource@hardakers.net>
Date: Tue Aug 4 17:20:07 2020 -0700
fix libwrap reference not including previous value
commit bbd6adc7794d450910aded191c94836a12614da1
Author: Wes Hardaker <opensource@hardakers.net>
Date: Fri Jul 31 07:47:40 2020 -0700
Version number update: 5.9.rc2
commit 2703c379582f17076e625606e9fbd63feb6533f4
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jul 24 08:35:44 2020 -0700
EXTEND MIB: Fix two recently introduced compiler warnings
See also commit 77f6c60f57db ("make the extend mib read-only by default").
----------------------------------------------------------------------
Changes: V5.8.1.pre2 -> V5.8.1.rc1
commit 0ee30b8ad6646c6bdd96ee67c82641ed50ce6519
Author: Wes Hardaker <opensource@hardakers.net>
Date: Thu Jul 23 17:05:50 2020 -0700
Release Candidate for V5-8-patches
commit f2ce116c5ff3e6dddb4186905bb277c38025b047
Author: Wes Hardaker <opensource@hardakers.net>
Date: Thu Jul 23 17:05:47 2020 -0700
Version number update: 5.8.1.rc1
commit 77f6c60f57dba0aaea5d8ef1dd94bcd0c8e6d205
Author: Wes Hardaker <opensource@hardakers.net>
Date: Thu Jul 23 16:17:27 2020 -0700
make the extend mib read-only by default
commit 4097a311e952d3b5c12610102bb4cc2fe72b56e5
Author: Wes Hardaker <opensource@hardakers.net>
Date: Thu Jul 23 15:46:12 2020 -0700
Revert "snmpd: Disable NET-SNMP-EXTEND-MIB support by default"
This reverts commit c2b96ee744392243782094432f657ded4e985a07.
commit b13410f5b35fd281b9e93113aaa47f9f5c418974
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 22 09:26:29 2020 -0700
snmpd, snmptrapd: Disallow to change the user / group after it has been set
This patch causes the -u and -g arguments to take precedence over the
agentuser and agentgroup keywords.
commit 53922d2d8873c460d526b8bba9a285c5b98c9e1f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 22 09:22:30 2020 -0700
snmpd, snmptrapd: Introduce the netsnmp_set_agent_{user,group}_id() functions
This patch does not change any functionality.
commit ba7740a2188184ce2beb36dd1e81b88ced390294
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Jul 21 07:36:43 2020 -0700
snmpd, snmptrapd: Reduce code duplication
Consolidate and rename the two copies of the functions that parse user
and group IDs.
commit 42e97a741dbc71ce4ab2671fc057b8488638d3b8
Author: Wes Hardaker <opensource@hardakers.net>
Date: Thu Jul 16 08:01:44 2020 -0700
Use more appropriate accept/block terminology
commit e772b8017d7e235437a45622bf8aa05f3ef3d084
Author: Robert Story <rstory@freesnmp.com>
Date: Mon Jul 13 12:45:22 2020 -0400
fix issue #99: read stored ifXTable config at startup
commit c2b96ee744392243782094432f657ded4e985a07
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jul 11 09:42:55 2020 -0700
snmpd: Disable NET-SNMP-EXTEND-MIB support by default
Since it is possible to abuse this MIB for privilege escalation attacks,
disable it by default. Notes:
- It is still possible to enable this MIB via the --with-mib-modules
configure option.
- Another MIB that provides similar functionality, namely
ucd-snmp/extensible, is disabled by default.
- The security risk of ucd-snmp/pass and ucd-snmp/pass_persist is lower
since these modules only introduce a security risk if the invoked
scripts are exploitable.
commit 6fd7499ccaafdf244a74306972562b2091cb91b1
Author: fisabelle <fisabelle@broadsoft.com>
Date: Thu Jul 9 15:49:35 2020 -0400
Issue#147: Net-SNMP not responding when proxy requests times out
commit 5a464044f95339f979f6b2fdfa756a08d519b78e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jul 5 14:09:56 2020 -0700
Stop using config_arch_require()
Stop using config_arch_require() since the effect of this macro is confusing.
As an example, #define freebsd4 freebsd4 occurs in a header file that is
included indirectly when building on FreeBSD 12. However, the following test
in config_modules_agent does not recognize the expansion of freebsd4 into
freebsd4:
# target_os may have been changed to a #define of 1...
if test "x$archtest" = "x1" -o "x$target_os" = "x$archtest" -o "x$PARTIALTARGETOS" = "x$archtest"; then
commit dec4eaa0626ef2447d41ea1af125809bfb86fbe8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jul 5 12:53:25 2020 -0700
FreeBSD: Fix the sysctl() configure test
This patch fixes the following compiler warnings:
conftest.c:406:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
main() {
^
conftest.c:415:41: warning: incompatible pointer to integer conversion passing 'void *' to parameter of type 'size_t' (aka 'unsigned long') [-Wint-conversion]
sysctl(mib, 2, &boottime, &len, NULL, NULL);
^~~~
/usr/include/sys/_null.h:34:14: note: expanded from macro 'NULL'
^~~~~~~~~~~
/usr/include/sys/sysctl.h:1062:70: note: passing argument to parameter here
int sysctl(const int *, u_int, void *, size_t *, const void *, size_t);
^
conftest.c:417:5: warning: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Wimplicit-function-declaration]
exit(0);
^
conftest.c:417:5: note: include the header <stdlib.h> or explicitly provide a declaration for 'exit'
3 warnings generated.
commit 72afad88ad58653687383b81b73299b5fdd6e8c4
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jul 4 14:30:58 2020 -0700
ci/net-snmp-configure: Improve FreeBSD support
Make freebsd_pkg_version() accept multiple package names. Rename
the opensshver variable into libssh2ver.
commit 18edbbfa20689f5b4d38390b9be7006d98f67195
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jul 3 18:44:44 2020 -0700
ci: .travis.yml: Comment out Xcode 10.x
commit ec9667c508cec45fc1e8e87fbd3f3687161926a1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jul 3 14:49:17 2020 -0700
ci/net-snmp-configure: Disable Python modules for Darwin 10 or older
Building Python modules fails with older versions of Xcode, hence do not
build Python modules for older versions of Xcode.
commit b3532cd6111eed67eaf83c540b05a175bc8f1fc1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jul 3 14:17:40 2020 -0700
ci/net-snmp-configure: Only include snmp-usm-dh-objects-mib if openssl/dh.h is available
commit 9945a3c8928d9358c7d8c5b4e8ec7b6250835f13
Author: Wes Hardaker <opensource@hardakers.net>
Date: Fri Jul 3 15:46:48 2020 -0700
minor wording fixes
commit c76c17abc03e5519ab75f2b7e951df40ae7a1ddd
Author: Wes Hardaker <opensource@hardakers.net>
Date: Fri Jul 3 15:45:51 2020 -0700
removed the way out of date thank you list, and referred to the git log
commit 1b54c6b895ba8311644427a958e43229853a853d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jul 3 10:05:44 2020 -0700
ci: Reduce the number of combinations built by Travis
commit f01c45c53cdc931faf68fb33389928a29f1297f9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Jun 30 16:53:05 2020 -0700
Darwin: Unify system header files
See also https://sourceforge.net/p/net-snmp/bugs/2504/ .
commit 9e892736ff0b04c5af5775d09155e392c76f7aae
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Thu Jul 2 22:18:50 2020 +0200
parse: remove a forgotten debug message
commit 51113450e8e653cf8261a8d09dc204a45c10b61a
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Thu Jul 2 22:16:21 2020 +0200
snmpwalk/snmpbulkwalk: flush stdout buffers before bailing out on stderr
commit 2e927ad46cce5eeaeb346d638e46d409e8220a79
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Thu Jul 2 22:08:22 2020 +0200
IANA updates for IANAifTypeMIB and IANA-ADDRESS-FAMILY-NUMBERS-MIB
commit 30238618812171bed934fe8fac629ad6ae22c75e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Jul 2 11:18:00 2020 -0700
testing: Skip tests T055 and T056 on OS/X
These tests fail when building with Xcode 12, so skip these tests.
commit 043b61801987d70cb5aa01280950afde1d5b061e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 1 11:05:41 2020 -0700
Darwin: Only include mibII/{ipAddr,var_route} if struct in_ifaddr is available
This patch fixes the following build error for Xcode 12 and later:
libtool: compile: gcc -I../../include -I. -I../../agent -I../../agent/mibgroup -I../../snmplib -I/usr/local/opt/openssl@1.1/include -D_GNU_SOURCE -D_ALL_SOURCE -D_THREAD_SAFE -D__EXTENSIONS__ -DNETSNMP_ENABLE_IPV6 -fno-strict-aliasing -DNETSNMP_REMOVE_U64 -Udarwin19 -Ddarwin19=darwin19 -Wall -Wextra -Wstrict-prototypes -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -Wno-sign-compare -Wno-unused-parameter -Wno-type-limits -Wno-deprecated-declarations -c mibII/ipAddr.c -fno-common -DPIC -o mibII/.libs/ipAddr.o
1480mibII/ipAddr.c:206:29: error: variable has incomplete type 'struct in_ifaddr'
1481 static struct in_ifaddr in_ifaddr, lowin_ifaddr;
1482 ^
commit af3e76ce47f84bc37f8a20718d4e63aa8491d0f4
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 1 19:31:41 2020 -0700
ucd-snmp/extensible.h: Add config_require(ucd-snmp/pass)
Since this module calls pass_compare(), add a dependency on ucd-snmp/pass.
This patch fixes the following runtime error on Darwin:
dyld: Symbol not found: _pass_compare
Referenced from: /Users/travis/build/bvanassche/net-snmp/agent/.libs/libnetsnmpmibs.40.dylib
Expected in: flat namespace
in /Users/travis/build/bvanassche/net-snmp/agent/.libs/libnetsnmpmibs.40.dylib
commit ebf93f489b42bbeeebd7b3e3bb8726cb8175fa2e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 1 19:29:38 2020 -0700
UCD-SNMP: Remove two superfluous casts
commit 9d123ce7407d8f46136bdbcab31205f95f997422
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 1 10:24:22 2020 -0700
ci/net-snmp-configure: Only build Python modules if Python3 is available
commit c06e6ce53f85746a414cd79b1a9c4e66cdc31bf8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Jun 30 19:15:49 2020 -0700
Darwin: Detect <crt_externs.h>, _NSGetArgv() and _NSGetExecutablePath()
commit 300ae4c59c4e60eaf679af69f3e17150c8cbf5ce
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Jun 30 16:58:52 2020 -0700
ci: Test more Darwin versions
commit 31a2c8065db102c876937ff64ee90c60b516d945
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jun 29 12:35:02 2020 -0700
libsnmp: Change several constants from unsigned char into unsigned int
The C language requires that the operands of a bitwise or expression
are promoted before the bitwise OR happens. From the C standard:
"The following may be used in an expression wherever an int or unsigned int
may be used:
- An object or expression with an integer type (other than int or unsigned
int) whose integer conversion rank is less than or equal to the rank of
int and unsigned int.
- A bit-field of type _Bool , int, signed int, or unsigned int.
If an int can represent all values of the original type (as restricted by
the width, for a bit-field), the value is converted to an int; otherwise,
it is converted to an unsigned int. These are called the integer promotions.
All other types are unchanged by the integer promotions."
In other words, the result of a bitwise OR of two unsigned char operands
has type 'int' instead of unsigned int. Hence change the type of constants
in header files from unsigned char into unsigned int.
See also https://github.com/net-snmp/net-snmp/issues/142.
commit 3df7a6ac1e0c652839446ebb53ff6f8cc14f7084
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jun 29 12:41:31 2020 -0700
agent/mibgroup/agentx/master_admin.c: Fix indentation
This patch fixes the following clang compiler warning:
mibgroup/agentx/master_admin.c:449:2: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
if (pdu->contextName != NULL)
^
mibgroup/agentx/master_admin.c:434:5: note: previous statement is here
if (!var || snmp_oid_compare(var->name, var->name_length,
^
commit 9963ec1be6c595205773b4177b5931ca550b1f79
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jun 28 19:44:39 2020 -0700
Introduce usm_build_user()
This patch does not change any functionality.
commit 2abda404ae805b1c369b0e68a2e489b3996f0ba0
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jun 28 15:23:52 2020 -0700
testing/fulltests/default/T0222snmpv3bulkget_simple: Remove the IF-MIB::ifEntry test
commit 24a8b092cce342d62a477394c60f572e49a90197
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jun 28 14:36:10 2020 -0700
Add test T0222snmpv3bulkget_simple
See also https://github.com/net-snmp/net-snmp/issues/141.
commit a0932b73ea0851308ca3e797caa600192cc3508a
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jun 27 19:49:03 2020 -0700
CHANGES: Bump libsnmp version from 35.0.1 to 40.0.0
Several functions and one data structure have been removed from header
file include/net-snmp/library/snmpusm.h. Hence bump the libsnmp version
number. For the previous libsnmp version bump, see also 1b3ef39cb7a3
("version update for 5.8.1.pre1").
commit 576788a0a9400da517ddb8ceb33a742f552a1408
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Jun 25 20:57:05 2020 -0700
libsnmp: Remove usm_clone_usmStateReference() from the public interface
Since this function is only used inside the USM implementation, remove
its declaration from the public interface.
commit 46f755fe4e6c2a919eebae0c55495f5f1207d06c
Author: Ramin Moussavi <lordrasmus@gmail.com>
Date: Tue Jun 9 13:42:50 2020 +0200
pingCtlTable: Move two more global variable definitions from .h to .c
commit 611149a879ef581454ffdd8637633197607750ff
Author: Jonas Bülow <jonas.bulow@gmail.com>
Date: Mon Jun 1 10:09:53 2020 +0200
libsnmp: Remove an obsolete keyword from a header file
This allows compilation using C++17 where the register keyword is obsoleted.
Also, the register keyword is in general never necessary.
[ bvanassche: edited commit message ]
commit 327079a4ae20e2d4766fe549a6e4e57fbe947bcd
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue May 26 06:38:53 2020 -0700
HOST-MIB, hr_filesys: Also monitor tmpfs
See also https://sourceforge.net/p/net-snmp/feature-requests/165/,
https://bugs.debian.org/685877 and
https://gitlab.alpinelinux.org/alpine/aports/issues/932.
Fixes: 2dfdd7cb73ec ("Better file system types") # v5.7
Reported-by: Craig Small <csmall@dropbear.xyz>
commit 22e1371bb1fd4a502fc1065fb5aa6b6df8a6d0d2
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue May 26 07:19:07 2020 -0700
HOST-MIB, hr_filesys: Convert recursion into iteration
commit 9238c0df6044f399f33e51c3bea89ee321b2882d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue May 26 07:34:51 2020 -0700
HOST-MIB, fsys: Remove definitions that have been commented out
commit a3ef7905e83320f834ef335d121948d6e7d58ff8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri May 15 07:13:37 2020 -0700
MIB-II: Declare local symbols static
commit 93a9f7f32612aa041e150b0d897ba3cdfda6e1db
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri May 15 07:10:20 2020 -0700
MinGW64, MIB-II: Fix a linker error
Fix the following linker error:
ld.exe: ./.libs/libnetsnmpmibs.a(var_route.o):var_route.c:(.bss+0x8): multiple definition of `create_flag'; ./.libs/libnetsnmpmibs.a(at_iphlpapi.o):at_iphlpapi.c:(.bss+0x8): first defined here
commit 68a8dcd937ca9d69764f20e495b1723d818d12b7
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu May 14 20:28:53 2020 -0700
ci/net-snmp-run-python-tests: Use Python3 interpreter
commit c01c5544bf02a139a3d103eead3c92378e75f737
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu May 14 20:26:28 2020 -0700
python: Define PY_SSIZE_T_CLEAN
See also https://docs.python.org/3/c-api/arg.html .
commit e4a4f0abca261bb62ea97c275223cf604b23288d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu May 14 19:28:43 2020 -0700
python: Improve Python3 port
See also https://github.com/net-snmp/net-snmp/issues/80.
[ bvanassche: Removed commented out code and fixed compiler warnings ]
commit 6a8ede044a269f2c10a6463e96d03709bb974151
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri May 8 19:32:52 2020 -0700
Python: Fix compiler warnings
commit 5de21610ff249d456c42530d0b8179bf1420a0e0
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri May 8 19:10:48 2020 -0700
perl/SNMP/t/bulkwalk.t: Improve the reliability of this test
Use ok($a, $b) instead of ok($a eq $b) to make error reporting more
informative. Unbless $list[3] before iterating over it to make this
test passs on DragonFly BSD. In the loop that looks for the loop
network adapter, check whether the index of that adapter is numeric
instead of comparing it with one.
commit 8bdae3bf48b3e80e148c2b20dc0f284119dc4548
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri May 8 21:41:52 2020 +0000
perl/SNMP/t/bulkwalk.t: Make this test easier to debug
commit 57936ba304d18e6c23f31b242ff6d0a95e846c4f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri May 8 19:33:10 2020 -0700
libsnmp: Declare the arguments of netsnmp_transport_create_config() const
commit 78beea8ef011702c026fdb3b32f118edcd2d6de4
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue May 5 08:25:55 2020 -0700
configure: Do not use -Wl,-no-undefined if -fsanitize= has been specified
Apparently these two compiler flags are incompatible. This patch should
fix the following build failure:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22010
commit 2d6ccd92f16a0ea2cf03ff26bdbdc46f0c93e4f8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue May 5 07:49:58 2020 -0700
configure: Ignore the krb5_config -flto=auto flag
-flto=auto is incompatible with clang, hence ignore that compiler flag.
commit fd2f267370435996eca54be70525f592fec3f0d8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon May 4 17:32:30 2020 -0700
libsnmp: Declare decode_keychange() input arguments const
commit 998a1686cbc202d2a5f3b4bc3933719cb13aaebd
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon May 4 15:11:59 2020 -0700
snmpd: Fix a buffer overflow triggered by processing "getnext"
This patch fixes the following Valgrind complaint:
Invalid write of size 8
at 0x4864DD4: netsnmp_scalar_helper_handler (scalar.c:225)
by 0x4872008: netsnmp_call_handler (agent_handler.c:546)
by 0x4872369: netsnmp_call_next_handler (agent_handler.c:660)
by 0x48655B6: netsnmp_serialize_helper_handler (serialize.c:86)
by 0x4872008: netsnmp_call_handler (agent_handler.c:546)
by 0x487219C: netsnmp_call_handlers (agent_handler.c:631)
by 0x4881D52: handle_var_requests (snmp_agent.c:3012)
by 0x488245A: handle_getnext_loop (snmp_agent.c:3502)
by 0x4882D97: handle_pdu (snmp_agent.c:3849)
by 0x4882F03: netsnmp_handle_request (snmp_agent.c:3685)
by 0x48835AB: handle_snmp_packet (snmp_agent.c:2294)
by 0x4C53CA7: _sess_process_packet_handle_pdu (snmp_api.c:5809)
by 0x4C5409F: _sess_process_packet (snmp_api.c:5858)
by 0x4C5443C: _sess_read (snmp_api.c:6115)
by 0x4C55009: snmp_sess_read2 (snmp_api.c:6387)
by 0x4C55046: snmp_read2 (snmp_api.c:5907)
by 0x403E43: receive (snmpd.c:1311)
by 0x405765: main (snmpd.c:1089)
Address 0x63a0908 is 0 bytes after a block of size 72 alloc'd
at 0x483877F: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x4C5002E: snmp_duplicate_objid (snmp_api.c:7844)
by 0x4872992: netsnmp_handler_registration_dup (agent_handler.c:844)
by 0x487575C: netsnmp_subtree_deepcopy (agent_registry.c:524)
by 0x4875B61: netsnmp_subtree_split (agent_registry.c:660)
by 0x487666F: netsnmp_subtree_load (agent_registry.c:940)
by 0x48766A4: netsnmp_subtree_load (agent_registry.c:947)
by 0x48766A4: netsnmp_subtree_load (agent_registry.c:947)
by 0x48766A4: netsnmp_subtree_load (agent_registry.c:947)
by 0x48770A4: netsnmp_register_mib (agent_registry.c:1214)
by 0x4872655: netsnmp_register_handler (agent_handler.c:318)
by 0x48656AB: netsnmp_register_serialize (serialize.c:56)
by 0x4864F07: netsnmp_register_scalar (scalar.c:98)
by 0x48712FC: netsnmp_register_watched_scalar2 (watcher.c:211)
by 0x49822AC: _register_extend (extend.c:221)
by 0x4982870: extend_parse_config (extend.c:576)
by 0x4C65EAD: run_config_handler (read_config.c:541)
by 0x4C66D19: read_config (read_config.c:960)
by 0x4C67422: read_config_with_type_when (read_config.c:481)
by 0x4C6770A: read_configs_optional (read_config.c:1018)
by 0x4C6809D: read_configs (read_config.c:1049)
by 0x4C55418: init_snmp (snmp_api.c:907)
by 0x405013: main (snmpd.c:911)
commit 836cd352bb43f3e1483a0e4937c5f05f6eab1eb9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon May 4 08:35:45 2020 -0700
libsnmp, snmpd: Handle PDU cloning failures
commit 644a9aa6f4816f5739161c674b793a28d99f69c3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon May 4 10:53:54 2020 -0700
libsnmp: Declare USM input parameters const
commit a9219e3ecee5ce0cafdcbfaee50ac70ef290fc5b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon May 4 09:13:00 2020 -0700
libsnmp: Declare the usm_get_user() arguments const
commit 7d27dd105f2633f4dfa3e3ee0a7689e5a5752b13
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon May 4 07:49:33 2020 -0700
libsnmp, snmpd: Fix two potential buffer overflows
Both bugs were introduced before 2001.
See also https://github.com/net-snmp/net-snmp/issues/110 .
commit 6c4fe0e446d3da50ed5ca8bd79f8949f0b803ddd
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon May 4 07:45:56 2020 -0700
libsnmp: Declare a build_oid_noalloc() input argument const
commit a5495798fa1e18f819a5e54f06deefe5fb798942
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun May 3 20:14:59 2020 -0700
snmpd: Remove a dead assignment
Additionally, remove an explicit \0-termination because snprintf() is
required to do \0-termination (see also
https://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html).
This patch fixes the following Coverity complaint:
CID 144418 (#1 of 1): Unused value (UNUSED_VALUE)
assigned_pointer: Assigning value from cur + snprintf(cur, ep - cur, " %i %i \"%s\" %s %i %i", curr_struct->timeout, curr_struct->retryCount, curr_struct->tagListData, curr_struct->paramsData, curr_struct->storageType, curr_struct->rowStatus) to cur here, but that stored value is overwritten before it can be used.
commit 5ab2436f775bcd1de1ed86fd5a39d55b4f30ea4f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun May 3 19:52:23 2020 -0700
agent/mibgroup/agent/extend.c: Remove dead code
This patch fixes the following Coverity complaint:
arith_non_null: The result of pointer arithmetic compatability_entries + idx is never null.
dead_error_condition: The condition exten must be true.
Fixes: 436bfa49439f ("Backwards-compatability implementation of the UCD-SNMP-MIB::extTable (if the ucd-snmp/extensible module isn't configured in).")
commit 559b8f5f9fdc66cf7612a31ff1a52825546f4f60
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun May 3 16:02:24 2020 -0700
AIX: Also define aix4 on AIX5 and AIX6
This patch allows to simplify the test defined(aix4) || defined(aix5) ||
defined(aix6) into defined(aix4).
commit aebf5909df24692e1a03327ba2e49581a8574aa8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun May 3 16:23:44 2020 -0700
configure: Improve the MIT crypto API check
commit fc7002ecced1329b62238f6278576b11846da173
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun May 3 14:26:17 2020 -0700
AIX: Fix one build error and also a compiler warning
n_name is a #define on AIX and hence using 'n_name' as a variable name
triggers a compiler error.
commit ee7eed065f652ccfc58cade8aef5848073cce7bf
Author: Bart Van Assche <bart@localhost>
Date: Sat May 2 17:21:41 2020 -0700
kFreeBSD: Fix the build
See also https://github.com/net-snmp/net-snmp/issues/103.
commit f44565fc195698e8b79fdd905c17217f0e493196
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun May 3 11:21:10 2020 -0700
Suppress recently introduced compiler warnings about close() not being declared
commit cb9b87d9b6e2b925065bf9cf700f9c44e5462d93
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat May 2 08:44:10 2020 -0700
Always use -Wl,-no-undefined when linking a shared library
Undefined symbols in a Net-SNMP shared library indicate a bug. Make sure
that this is detected at link time instead of at run time.
commit 1fe4c024aa8e7d1e493039c3e1ca91dd06ffc5be
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat May 2 09:26:37 2020 -0700
configure: Add -lkrb5 to LNETSNMPLIBS instead of LIBS
Only the Net-SNMP library needs to be linked with the Kerberos libraries.
Link with libk5crypto if necessary.
commit dfa82c4810b68181cb70fef07a7e8000beb98262
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat May 2 07:13:29 2020 -0700
FreeBSD: Use the freebsd3 macro instead of __FreeBSD__
Use the 'freebsd3' macro to guard code that is FreeBSD-specific. This will
make it easier to fix the build for kFreeBSD. Note: the freebsd3 macro is
defined if the FreeBSD version is >= 3.
commit 7c562f9b61397d8174b41c13244d2c69d729e13b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat May 2 08:24:40 2020 -0700
perl/SNMP/t/notify.t: Make this test more robust
commit 15737583d5271f398a38b2f11f900fbd73a7025b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat May 2 08:17:40 2020 -0700
UCD-SNMP-MIB: Move an include directive and a few constants into proc.c
commit 05c6c29c2c458261605fee8d3a8d59c97bba2878
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat May 2 08:10:29 2020 -0700
ci/net-snmp-configure: Build without MySQL support
commit ca585bbbae9e4831a6e622bfb9356689187bea70
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 30 07:38:35 2020 -0700
ci/net-snmp-run-tests: Fix the test that verifies whether Perl modules have been enabled
commit b323fe9f83ff070244f00363d5493b9528e4300d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 30 10:09:07 2020 -0700
perl/SNMP/t/bulkwalk.t: Improve the robustness of this test
Instead of only examining the network interface that occurs first in the
interfaces table, examine all network interfaces.
commit d589ab4eab9aa5f21290ae9e20fb4f8d0c75f105
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 30 17:01:20 2020 -0700
perl/TrapReceiver/t/1.t: Use ok() instead of print()
commit 93c22da673e88a72d59e1d6e66a8d4836f9c6828
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 30 11:52:16 2020 -0700
perl/ASN/test.pl: Convert to the Perl Test framework
commit 6c9f36b09b8a6486eb09f7496e5a73df18905a2f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 27 17:14:58 2020 -0700
perl/MakefileSubs.pm: Define the MinGW compiler flags correctly
commit e227abee97c3d43c53e5082c94892fc904780ffd
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 30 07:17:30 2020 -0700
perl/MakefileSubs.pm: Remove -Iinclude/net-snmp from the Windows flags
Remove include/net-snmp from the include path because it is not used.
commit 9f176cbee62338b2fb19de6165c4ae4f8799c822
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 30 07:20:10 2020 -0700
agent/snmp_perl.c: Remove an obsolete definition
_WIN32_WINNT is either defined by the configure script (MinGW, Cygwin) or
by win32/Configure (MSVC).
commit bbd745acaf022524b9ae686953ea010d98c68ec5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 30 08:02:39 2020 -0700
configure: Simplify the size_t format specifier check
Assume that Unix compilers are ANSI C compliant and use the 'z' format
specifier on Unix. Only check for the underlying type of size_t on
MinGW. Remove the unused NETSNMP_PRI32 format specifier.
commit 108cce420ee10857d0d9407f0f5b45b6e7c0fc48
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 29 18:36:45 2020 -0700
ci/build.bat: Check whether make perl_test succeeded for the MSVC build
commit 93fe38cf5f7cdf339df48d94caff140c91e50ac7
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 29 14:35:34 2020 -0700
perl/SNMP/Makefile.PL: Simplify GetTestInfo()
commit 50eeb76544810cf8fbcde94a2696519ba3e8acf3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 29 12:01:36 2020 -0700
perl/SNMP/t/dump-session.t: Call snmptest_cleanup() after the test has finished
commit e69984355cfd0d4bedd4077367f3a3c89de72109
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 29 11:04:22 2020 -0700
perl/SNMP/t/startagent.pl: Improve kill_by_pid_file robustness
commit 905ab798cf6a419bafa68d29f6b262a21d3a382f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 29 12:13:10 2020 -0700
perl/SNMP/t/startagent.pl: Make starting processes faster
commit e2349372287809b518dc76e16b4e0602dffeca21
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 29 09:51:04 2020 -0700
perl/default_store/test.pl: Convert to the Perl Test framework
commit 498b243e35d105d72ee205e42d17fd4505f99b25
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 29 10:51:20 2020 -0700
Perl tests: Use $mibdir instead of ../../mibs
commit b16a0e0d917bf2cbd32e5dc95b73d7e5407533a9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 29 15:18:44 2020 -0700
perl/SNMP/t/startagent.pl: Split this Perl script
commit f253df86c4560d762cc22f8234cd879d9b143b1e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 29 08:20:38 2020 -0700
Perl tests: Enable 'use strict' and 'use warnings'
commit 917b0f281c31ab152528e6dc4e5c2ab5027d5353
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 29 09:53:24 2020 -0700
Perl tests: do not modify @INC
commit dc43e75282c7b5de51463964571e5f6b633c582f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 29 12:50:30 2020 -0700
ci/perl.bat: Suppress two uninteresting Visual Studio compiler warnings
commit bc2a9a7fedf8a99073a4e5cb4872124101abd3d8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 29 10:24:41 2020 -0700
win32/Makefile.in: Tell the Perl DynaLoader where to find netsnmp.dll
commit 5bacc9af2baa5a5a02b0e3ffc6abf963adff6a71
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 29 13:30:38 2020 -0700
snmpd: Do not open /dev/kmem on Linux even if libelf-devel has been installed
See also f1647e3db242 ("snmpd: Do not open /dev/kmem on Linux")
commit 59e8b5b28db8bed05d68c4d508a89932437e9cb6
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 29 11:46:50 2020 -0700
snmpd: Make init_kmem() report "success" if /dev/kmem is not opened
Fixes: f1647e3db242 ("snmpd: Do not open /dev/kmem on Linux")
commit 595751cdf7b74083631b2ffd335be45f0b691a88
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 29 07:38:50 2020 -0700
ci/build.bat: Unbreak the MSVCSTATIC64 build
This patch fixes the following error that is triggered by the win32/Configure script:
Can't locate ExtUtils/Embed.pm in @INC (you may need to install the ExtUtils::Embed module) (@INC contains: /usr/lib/perl5/site_perl /usr/share/perl5/site_perl /usr/lib/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib/perl5/core_perl /usr/share/perl5/core_perl) at Configure line 9.
commit d84f0c6e160951318a35e72fe76ef2e0ffd91044
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Apr 28 20:42:46 2020 -0700
Windows, MSVC: Fix Perl module compilation
This patch fixes the following error message:
default_store.c: loadable library and perl binaries are mismatched (got handshake key 0000000010500080, needed 0000000010A00080)
See also https://github.com/net-snmp/net-snmp/issues/104.
commit 42aa220a7d3d686eb91bfd354c9b5094afbe6d97
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Apr 28 15:55:59 2020 -0700
ci/build.bat, MSVC: Run Perl tests
commit a4a8a70dbef581a30c3ba814de39b514f76072f8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Apr 28 15:40:59 2020 -0700
Perl: Use $Config{path_sep} instead of ';' for Windows
commit 4990ca1af1d16a3e3144d455cb1e41108f00b691
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Apr 28 14:50:44 2020 -0700
win32/Makefile.in: Set PERL5LIB before running tests
This is necessary to let the Perl interpreter find the Net-SNMP Perl modules.
commit 0e33f5025a483e4d724b6e417e8ef6b0788819e9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Apr 28 18:14:17 2020 -0700
testing/RUNFULLTESTS: Fix the --with-perl-modules test
commit e621ae3038c82f92666c37da9c0e2ceb09df93f0
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Apr 28 13:58:30 2020 -0700
testing/RUNFULLTESTS: Fix PERL5LIB
Fixes 5a86cfb005db ("testing: Unbreak RUNFULLTESTS").
commit 61822884421eae193ca9fd1f55da488000480789
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Apr 28 13:53:12 2020 -0700
ci/build.bat: Fix a comment
commit 467c5ee95ba804275e719a4848d2d46f18a9eee1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 25 15:54:06 2020 -0700
ci, .appveyor.yml: Switch to Visual Studio 2019 image
commit f7ae854c12c35c2561979873e53d217da688e809
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Apr 28 13:09:14 2020 -0700
win32/dist/build-binary.pl: Remove the dependency on File::Which
File::Which is a CPAN module and hence is not present in the core Perl
distribution.
Fixes: ed630cf540f6 ("win32/dist/build-binary.pl: Search %PATH% for tar.exe and gzip.exe")
commit 4f61570bca1d765bfdb11c6010c887cbe3176f29
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Apr 28 13:33:44 2020 -0700
ci/build.sh: Install MSYS Perl MakeMaker and Test-Harness
commit 62fb93df0641b4beed3db28d594ca1f87ec63b0c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 27 21:50:53 2020 -0700
ci/AppVeyor: Reduce build time
Only download and build Perl when building with the Visual Studio
compiler and for dynamic builds. Otherwise use the Perl interpreter that
is included with the development environment (MinGW or Cygwin).
commit 8df783a81996f03e2927fe0f56182ab0250e317e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 27 13:06:09 2020 -0700
ci/build.bat: Fail if win32/Configure fails
commit aea52476b536d85f42a31d05a2bb5bcefe484823
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 27 12:45:17 2020 -0700
win32/Makefile.in: Set NET-SNMP-PATH
commit bb8923f55329276debe86f787e3a0edd537c308f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 27 15:17:40 2020 -0700
perl/SNMP/Makefile.PL: Use NET-SNMP-PATH if it has been set
Additionally, ignore the unused NETSNMP_PREFIX environment variable.
commit 4d614474f9157809d8a5ab8c265246e5b2e56374
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 27 13:22:39 2020 -0700
perl/MakefileSubs.pm: Restore support for the -NET-SNMP-PATH option
Fixes: 273cd3379613 ("perl Makefiles: MinGW / MSYS fixes")
commit 93299804393dd777ec1a188807bb4f664475eac0
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 27 17:29:35 2020 -0700
perl/Makefile.PL: Simplify this file
commit 5135d509ed8bb1ac69b50f5980d97b237efb4f29
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 27 11:27:54 2020 -0700
ci/perl.bat: Make this batch file compatible with Windows tar
commit 04adea6a0f33286e9b884f498989d26fbf28e896
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 27 11:18:04 2020 -0700
ci/perl.bat: Bump Perl version
commit 0be093688013b90896f2db3204bb20e790d70149
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 27 08:23:16 2020 -0700
configure: Report supported authentication and encryption modes correctly
Commit 9e49de2e03b1 ("NEWS: snmplib: AES-192/AES-256 compatibility with SNMP
Research / CISCO") removed SHA-128 and SHA-192 support and added support for
SHA-224, SHA-256, SHA-384 and SHA-512. Commit 329a9d3c9d63 ("revamp auth/priv
protocol constants handling") added support for several AES encryption modes.
Make the configure script report which modes are supported.
commit 05739bdb63ef192bf9e9130fbc9b560baa8852ec
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Apr 24 10:16:07 2020 -0700
CHANGES: Windows, MSVC: snmpd: Switch from mibII/interfaces to if-mib/ifTable
Provide IF-MIB::ifTable and IF-MIB::ifXTable through the agent instead of
MIB-II::ifTable. This matches the default behavior of the Linux SNMP agent.
From the IF-MIB: "This MIB is an updated version of MIB-II's ifTable".
commit 0c880d6f7a2bcb4a4a6f93c4dc577f9bc22c6e6a
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 26 12:04:20 2020 -0700
Windows, include/net-snmp/types.h: Fix socklen_t type definition
commit f1647e3db24241f0c42449506aee4b406a37b1b5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 26 11:10:46 2020 -0700
snmpd: Do not open /dev/kmem on Linux
The Net-SNMP agent only uses /dev/kmem to access kernel data structures on
BSD systems. Hence do not open /dev/kmem on Linux. A side effect of this
patch is that it enables cross-compilation from Linux to MinGW. /dev/kmem
exists on Linux but the code in agent/kernel.c that is surrounded with
#ifdef HAVE_KMEM / #endif does not build with the MinGW compiler.
commit 9ee2a5ccf50098f8e7371051e878b169b1e58cc3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 26 11:36:40 2020 -0700
agent/mibgroup/host/hr_disk.c: #include <unistd.h>
Fixes: e91559e38d23 ("Net-SNMP include files: Minimize #include directives")
commit b7f44bbdbe484bd03b438595e7c6b58eda005897
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 26 09:33:51 2020 -0700
Cygwin, MIB-II: Fix a few compiler warnings
commit 8e9dfcc27b6cdb538ec4a4d5596641a88dd8a2d9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 26 08:04:46 2020 -0700
Cygwin, IF-MIB: Temporarily disable the iphlpapi implementation
Making the iphlpapi implementation compatible with Cygwin requires more
work. Hence temporarily disable the iphlpapi implementation for Cygwin.
commit dcec69ba971388d1da74acd1ca514e1c14ed8fa2
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 25 19:39:21 2020 -0700
Windows, IF-MIB: Minimize #include directives
This prevents a conflict on Cygwin between the Cygwin socket header files
and the Winsock header files.
commit e91559e38d230934c9b10fe0f0a51394e008dda9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 25 19:30:45 2020 -0700
Net-SNMP include files: Minimize #include directives
Move several #include directives from Net-SNMP include files into .c files.
commit 6945b208a74aabe9acebdae7e4642038ab8e1c96
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 25 11:58:48 2020 -0700
include/net-snmp/system/cygwin.h: Simplify this file
commit 8c686545d71894d1ba5b7eef846d559dae9fe06e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 25 15:53:06 2020 -0700
ci, .travis.yml: Use OS/X 10.14
commit 193062739789a63affe09d2eb80affd57157b233
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 25 10:18:39 2020 -0700
Net-SNMP headers: Move in_addr_t definition into <net-snmp/net-snmp-config.h>
This allows to remove #include <netinet/in.h> from <net-snmp/types.h>.
That change allows to include <net-snmp/net-snmp-config.h> from source
files that include Winsock header files. Cygwin BSD socket header files
conflict with Winsock header files.
See also commit a7f53c44a53d ("move include for in_addr_t to net-snmp/
types.h, where in_addr_t is defined for systems w/out netinet/in.h").
commit b3d2d0896a67be6f8fbbd2f025e077ba293a52a5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 25 10:14:18 2020 -0700
Net-SNMP headers: Only include <sys/time.h> if necessary
Minimizing #include directives reduces the build time.
commit e981bcbab5034ccd9cf8445d4ba60d1420b23b3d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 25 07:59:04 2020 -0700
IF-MIB: Unbreak the MinGW32 build
Fixes: c33140b0110c ("Win32, IF-MIB: Implement interface table support")
commit 72405d2efb5874f48b6871ac0197d86d0e4f109c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 25 08:51:21 2020 -0700
apps/Makefile.in: Make this Makefile again compatible with non-GNU make implementations
'ifneq' is a GNU extension. Instead of using 'ifneq', use a mechanism that is
compatible with GNU make.
Fixes: 71f46f7126b4 ("apps: Only build snmpps and snmptop if a curses library is available")
commit 5c209f9a6fe444b13d7c39eac12f5390e5e5fcb4
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Apr 24 21:46:40 2020 -0700
Darwin: Add support for Darwin versions 18..21
See also https://github.com/net-snmp/net-snmp/issues/101.
commit c33140b0110cead76039da6d985878ea9d05b2fd
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 23 18:10:39 2020 -0700
Win32, IF-MIB: Implement interface table support
On Windows Vista, Windows 2008 and later the ifOperStatus information is
more accurate than on older Windows versions.
commit 026348ef082d3bda5f2b394002b1d770d71ccec3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Apr 24 16:42:34 2020 -0700
Windows: Increase _WIN32_WINNT to 0xffff
Instead of restricting the Windows features to a certain version of the
Windows API, enable all Windows API functionality.
commit d560f542c0853fdfef2bf9cdf0365ac75dfdf40b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 22 19:27:26 2020 -0700
MIBs: Remove the NETSNMP_INCLUDE_IFTABLE_REWRITES and NETSNMP_ACCESS_INTERFACE_NOARCH macros
Switch all platforms to the rewritten ifTable implementation. Instead of defining
NETSNMP_ACCESS_INTERFACE_NOARCH if no data access implementation is available, use
the "unsup" dummy implementation.
commit e86230436ea0d3126a4525a98ff7dde60cd448b1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Apr 21 09:48:31 2020 -0700
Windows, IF-MIB: Switch to the rewritten ifTable implementation
Since the IF-MIB is not yet implemented on Windows, all switching to the rewritten
ifTable implementation involves is to provide a dummy implementation of the data
access functions.
commit d15cae3cb7e2eb5a1cfea8832d530fb81c317858
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Apr 21 10:13:27 2020 -0700
IF-MIB: Fix the build for the case !defined(HAVE_PCRE_H) && !defined(HAVE_REGEX_H)
commit 4803af75945291ee7ad270d93425781e9e79f3f1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Apr 21 15:04:39 2020 -0700
ci/openssl.bat: Bump the OpenSSL version
commit 71f46f7126b4f5cf1858d16be633a0d7a2002e6d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Apr 21 08:34:44 2020 -0700
apps: Only build snmpps and snmptop if a curses library is available
Additionally, only search for curses header files if a curses library is available.
commit 435ddb821bdae5950829d225d1c087784214d41c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Apr 21 07:53:15 2020 -0700
configure: Skip pcre.h check if --without-pcre has been specified
Fixes: 213941dfbee6 ("CHANGES: agent: PATCH 3525595: from dhubler: Add support for finding processes via regex")
commit 2f1c4d06bc49da5fc4a0fb7be373a8c6f9d3d4a6
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 20 14:40:13 2020 -0700
ci, FreeBSD: Improve the code that detects the OpenSSL version
commit b59e896245d001ebc13c415c86fb8c203b639f07
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 20 13:44:31 2020 -0700
ci, MinGW: Build HOST-MIB
commit 90ea93b038ea0f70a78f315d89f68d34615c1902
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jun 23 09:18:12 2018 -0700
tests: Rename SUCCESS() and FAILED()
This is necessary to avoid conflicts with constants with the same
name in the Windows header files.
commit c083ccbe9b365a06b7192be1d1b6a31695c677d1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 20 21:18:33 2020 -0700
MinGW, T008asn1_clib.c: Fix compiler warnings
commit f78d56a80e89aaa36a6da2b7318c9e012badfef9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 20 21:13:13 2020 -0700
MinGW: Fix multiple compiler warnings
commit c55a1421da1bed9acdbc08381744238aeca897c6
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 20 13:20:18 2020 -0700
agent/mibgroup/utilities/execute.c: Only define tokenize_exec_command() if necessary
commit 1ff5be497f7ef551c26bf320aab995ece596cca9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 20 20:00:31 2020 -0700
MinGW, MIB-II: Fix a linker error
commit fbb0e883abf2e3b2b021aabdc4e9ae56bba35ced
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 20 12:58:03 2020 -0700
MinGW: Fix agent/mibgroup/host/hr_system.c build
commit 3074aa18898b0461bc06b61041382d9622e83cf7
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 20 12:52:30 2020 -0700
agent/mibgroup/host/data_access/swrun_null: Fix a compiler warning
commit 3c9e5f2608eebacd31c4e08eabe11dbb183ee685
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 20 10:32:43 2020 -0700
MinGW: Fix cross-compilation
Fix building for MinGW on a non-MinGW system (--host=x86_64-w64-mingw32). Add
LT_LANG([Windows Resource]). Use @RC@ instead of windres such that the proper
cross-compilation prefix is used in front of the windres executable.
commit fda7c07b0ec3ab1384646548edd79e62138b71eb
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 20 11:19:08 2020 -0700
testing/fulltests/unit-tests/T008asn1_clib: Fix MinGW build
commit 44fd72624285fd52337c97577d92b94333b8dadb
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 20 11:18:41 2020 -0700
apps/snmpping: Fix MinGW build
commit 319f4d717fb9ab2ef0f7696d4afb348ed34054ae
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 18 20:16:52 2020 -0700
HOST-MIB: Reorder function definitions
Reorder the function definitions in hw_fsys.c such that the forward function
declarations can be removed.
commit 5732d8b3debdb149ea5f12d85b2804b41b98d22e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 18 19:54:49 2020 -0700
HOST-MIB: Declare _fsys_cache and _fsys_container static
Neither _fsys_cache nor _fsys_container is used outside the source file these
variables are declared in. Hence declare these variables static.
commit 3300c1f03e5899dc4301c39c104ff3cfbd840a79
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 18 18:46:09 2020 -0700
testing: Make the tests pass for --enable-minimalist and --enable-mini-agent
commit 228cba5710b2213cf4bb5c2d60d56608f2497831
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 18 11:10:29 2020 -0700
testing: Add a test for "extend OID"
See also https://github.com/net-snmp/net-snmp/issues/97 .
commit 633b8214eeb6558519efdb18a5fea1e53b7f2ba3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 12 19:28:13 2020 -0700
libsnmp: Only define strcasecmp() and strncasecmp() if necessary
commit ea4e62bf9242a2c4792bc60eb3fff0b97fa76060
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 12 04:12:43 2020 +0000
testing/fulltests/support/myip: Suppress Perl error messages
Suppress the following error message:
Constant subroutine main::AF_INET6 redefined at /System/Library/Perl/5.18/Exporter.pm line 66.
at (eval 1) line 2.
Prototype mismatch: sub main::AF_INET6 () vs none at /System/Library/Perl/5.18/Exporter.pm line 66.
at (eval 1) line 2.
usage: sin_sv = sockaddr_in6(port,iaddr)) at ../support/myip line 39.
commit cc2eece940c5e8508d635a1620eb1cddf25fd136
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 11 20:32:03 2020 -0700
ci/openssl.bat: Bump the OpenSSL version
commit 5f1986c79e8b9d3d8574fc73001d6e193bed7c79
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 11 20:11:35 2020 -0700
HOST-MIB: Log statfs() failures once
See also https://github.com/net-snmp/net-snmp/issues/94.
commit c94fdd4084fdefafaebcd3421f1c0fa644cda928
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 11 20:10:58 2020 -0700
HOST-MIB: Do not assume that statfs() returns meaningful values if it fails
commit e1b57bd02670818a44966ba4aad2a6d7ce9839b5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 11 19:56:31 2020 -0700
libsnmp: Suppress a clang warning about debug_indent()
Suppress the following clang warning:
snmp_debug.c:91:19: warning: adding 'unsigned long' to a string does not append\
to the string [-Wstring-plus-int]
return SPACES + sizeof(SPACES) - 1 - debugindent;
~~~~~~~^~~~~~~~~~~~~~~~
snmp_debug.c:91:19: note: use array indexing to silence this warning
return SPACES + sizeof(SPACES) - 1 - debugindent;
^
& [ ]
commit 23fe19d9b63df63446c4f39ae1c9a60cd9c198d0
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 11 17:15:55 2020 -0700
testing/fulltests/support/myip: Make this work with older Perl versions
Older Perl versions have Socket6 and Socket modules. Newer Perl versions
support the Socket module but not Socket6. Make the myip script work with
all Perl versions.
commit bf4964241391b197e1ce2afca225b684f94f7451
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 12 01:54:58 2020 +0000
IF-MIB: Fix regexec() argument types
Fixes: e6795b2d67b4 ("IF-MIB: Add regex support for include_ifmib_iface_prefix")
commit 9180ccb8772f7cd3317afcb6db676c8bdeedbcb9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 11 18:31:27 2020 -0700
NetBSD: Fix compilation of snmplib/snmpksm.c
commit 6d722dcf108055c24e783cb367cb6985f11bd850
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 11 11:33:21 2020 -0700
Regenerate the configure script
Fixes: e65031b76367 ("CHANGES: building: Remove extra argument to NETSNMP_SEARCH_LIBS to make libnl-3 end up in the right group of libraries")
commit e65031b76367696234f7f0e7ecb2d0379e094457
Author: Magnus Fromreide <magfr@lysator.liu.se>
Date: Tue Apr 7 05:41:14 2020 +0200
CHANGES: building: Remove extra argument to NETSNMP_SEARCH_LIBS to make libnl-3 end up in the right group of libraries
commit b04dd9585aee57615edc2f973ac3b43a3c758812
Author: Magnus Fromreide <magfr@lysator.liu.se>
Date: Mon Apr 6 02:46:12 2020 +0200
CHANGES: net-snmp-config: Allow nine or more files in --compile-subagent
commit b078c7eac1d98c340d3682341ae7d0ceb3504f12
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 4 19:40:02 2020 -0700
Revert "swinst_apt: Use dpkg for modified date"
The reasons for the revert are:
- The modified_date_t change that I made is wrong.
- Apparently not all Debian systems support ${db-fsys:Last-Modified}. From
the dpkg man page: "It contains the timestamp in seconds of the last time
the package filesystem entries were modified (since dpkg 1.19.3)."
commit 001cbbc32a8be87041ddb7a80a3642550691ecfb
Author: Craig Small <csmall@dropbear.xyz>
Date: Sat Apr 4 12:00:43 2020 +1100
swinst_apt: Use dpkg for modified date
Instead of trawling through dpkg's files, let dpkg-query tell us
when the package was last modified. It means if the directory
changes or any other internal changes happen, this will still
keep working.
db-sys:Last-Modified field has been in since dpkg-query 1.19.3
which means it works for Debian stable (Buster) onwards.
References: https://bugs.debian.org/905668
[ bvanassche: reworked an unsafe cast ]
commit d6551405ddcbdc003302d991cc550270c701d9db
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Mar 31 20:51:48 2020 -0700
ci: Move the mariadb installation code from .travis.yml into ci/before.sh
Additionally, display /etc/hosts on all operating systems.
commit 49485cd90f9e978d2e68678f9efdff0a645a34d2
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Mar 27 21:54:02 2020 -0700
testing/fulltests/support/clib_build: Fix a recently introduced bug
Prevent that linking the regression tests fails as follows on Ubuntu:
/usr/bin/ld: cannot find -lnetsnmpmibs
/usr/bin/ld: cannot find -lnetsnmpagent
collect2: error: ld returned 1 exit status
Fixes: 9db9d55f9511 ("testing: Add a unit test for run_exec_command()")
commit e6795b2d67b45dddcb4deb99e9af51f7659d5a0c
Author: lbw <lbw@telstra.com>
Date: Sat Mar 21 17:03:21 2020 +1100
IF-MIB: Add regex support for include_ifmib_iface_prefix
[ bvanassche: consolidated error paths ]
commit b49ff2207661c48bad46bb312f6f0627ffbbb825
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Mar 22 21:33:00 2020 -0700
testing/fulltests/unit-tests/T024run_exec_command_clib.c, Darwin: Fix executable paths
commit 418dd7012dd45612b6506d6519e128ec823918d5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Mar 22 21:29:04 2020 -0700
agent/netsnmp_close_fds.c, Darwin: Suppress two compiler warnings
commit 5459b69c4bc0f228f2e329b5913320a8d5acccc9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Mar 22 20:51:32 2020 -0700
ci: .travis.yml: Add Python 3 packages
commit f0bca593510e3776c6aca1c44556ae04e7a1109b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Mar 22 15:34:04 2020 -0700
agent/mibgroup/utilities/execute.c: Handle errors instead of ignoring these
commit 166a236be4f76796db0a49917415b790eec9ef89
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Mar 22 15:30:33 2020 -0700
agent/mibgroup/utilities/execute.c: Fix tokenize_exec_command()
Do not discard the 100th argument. Fix a buffer overflow.
commit 85a536c06f4de67fbb4f0382d4137be4b97b7ff3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Mar 22 15:41:55 2020 -0700
agent/mibgroup/utilities/execute.c: Remove the setPerrorstatus() macro
commit 6a666952e58c69225a2c681cc2059de7a782c4ee
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Mar 22 15:28:16 2020 -0700
agent/mibgroup/utilities/execute.c: Declare input arguments const
commit f8f6cb8e7513f38c782bf96a285e2f81cfeb98f1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Mar 22 15:26:12 2020 -0700
agent/mibgroup/utilities/execute.c: Convert tabs into spaces
commit 9db9d55f95116300c282aa48dd329764773af59b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Mar 22 16:22:36 2020 -0700
testing: Add a unit test for run_exec_command()
commit a524e99cb6524353883c72721f6df5b470740408
Author: Igor Ryzhov <iryzhov@nfware.com>
Date: Fri Mar 20 16:45:41 2020 +0300
mib2c: fix size_t format specifier in mfd generated code
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
commit 6141634d652cbd5a9e20982c88b95984d093099b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Mar 21 20:52:37 2020 -0700
libsnmp: Fix a potential buffer overflow in netsnmp_tlstmAddr_restore_common()
This patch fixes the following Coverity complaint:
CID 344591 (#1 of 1): Out-of-bounds access (OVERRUN)
5. overrun-buffer-arg: Overrunning array fingerprint of 256 bytes by passing
it to a function which accesses it at byte offset 256 using argument fp_len
(which evaluates to 256).
commit 3d5eab844a70367d2ea00a93ad37206ec7b91793
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Mar 21 20:48:08 2020 -0700
libsnmp: Document the is_labelchar() argument range
This patch suppresses the following Coverity complaint:
CID 344592 (#1 of 1): Improper use of negative value (NEGATIVE_RETURNS)
32. negative_returns: ch_next = netsnmp_getc(fp) is passed to a parameter
that cannot be negative.
commit 3f9aa163160e96b877f975519415ce3277d5da0a
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Mar 21 20:44:16 2020 -0700
snmplib/sd-daemon.c: Check LISTEN_FDS before using it
This patch fixes the following Coverity complaint:
CID 344596 (#1 of 1): Untrusted loop bound (TAINTED_SCALAR)
15. tainted_data: Using tainted variable 3 + (int)l as a loop boundary.
commit b67afb81eb0f7ad89496cd3e672654bfd8c55d0e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Mar 21 20:03:13 2020 -0700
snmpd: UCD-SNMP proxy: Fix a crash triggered by a wrong passphrase
See also https://github.com/net-snmp/net-snmp/issues/82 .
commit b83b0ddcf8fa27108b198bbb0fe247e18d2dae4f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Mar 21 20:01:18 2020 -0700
libsnmp: Improve snmp_async_send() and snmp_sess_async_send() documentation
commit 2e517c5d60fcf9f96d2ad8045e7aec9b60dec041
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Mar 21 13:59:27 2020 -0700
Python: Port to Python 3
Make the configure script look for the 'python3' interpreter instead of
'python'. Make all Python source code compatible with Python 2.7 and
Python 3. Make python/netsnmp/client_intf.c compatibly with Python 2.7
and Python 3.
commit 7fd595cbdf0fe855aafaf54fcc39e8b3b2f96c08
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Mar 21 14:24:16 2020 -0700
python/netsnmp/client_intf.c: Improve coding style conformance
Limit source code to 80 columns, move the body of if-statements to a
separate line and leave a blank line after declarations.
commit 9619aa41d5cf353ec1d9b94d3ed4b4a61a51bc34
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Mar 21 14:54:46 2020 -0700
python/netsnmp/client_intf.c: Add more comments
commit dfd0b638dd5ce9cabcc65afbd589a3177749fac3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Mar 21 15:10:14 2020 -0700
python/netsnmp/client_intf.c: Change the return type of py_netsnmp_attr_long() from long long into long
The type 'long' is big enough to fit all possible return values.
commit 3fb925a5a93ab2326b588899d81e0e412e0f321b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Mar 21 15:08:16 2020 -0700
python/netsnmp/client_intf.c: Fix the netsnmp_create_session_tunneled() return value
commit d9577374329fa4516ba0220bc8ff68c3f316b430
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Mar 21 13:35:10 2020 -0700
Python: Reorder function definitions
Reorder function definitions such that the forward declarations can be
removed.
commit df1c17d2a0d1ba2a3130c9fdd2bd4c03dba4a947
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Mar 20 20:36:21 2020 -0700
Perl: Complain about attempts to send a TRAP with an unsupported SNMP version
commit 883b354d4be90c13166bc11eb8ac65880f51e57d
Author: Peter Valdemar Mørch <peter@morch.com>
Date: Wed Sep 25 18:13:36 2019 +0200
Perl: Allow informs to be sent with SNMP v2(c).
Before informs required SNMP v3. But informs actually work just fine
with v2c too too.
commit dfe3c8bdff9bceb796fc9425ef21676a99138d33
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Mar 18 21:54:28 2020 -0700
ci/openssl.bat: Bump the OpenSSL version
commit 62eea843bf46162db557e7f39f87958de2fee26a
Author: Igor Ryzhov <iryzhov@nfware.com>
Date: Wed Mar 18 22:24:27 2020 +0300
mib2c: use struct counter64 instead of U64 in generated code
The U64 typedef was replaced with struct counter64 in net-snmp
code because of the conflicts with Perl headers. But mib2c still
generates the code with U64.
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
[ bvanassche: Adjusted indentation of source code comments ]
commit 1a8b31c175e69e0e0a8ef6b7068aff6c45980eea
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Mar 15 21:55:36 2020 -0700
CHANGES: configure: Assume that memcmp() works
From the autoconf documentation: "Macro: AC_FUNC_MEMCMP. If the memcmp
function is not available, or does not work on 8-bit data (like the one
on SunOS 4.1.3), or fails when comparing 16 bytes or more and with at
least one buffer not starting on a 4-byte boundary (such as the one on
NeXT x86 OpenStep), require an AC_LIBOBJ replacement for `memcmp`.
This macro is obsolescent, as current systems have a working memcmp.
New programs need not use this macro."
Hence remove the AC_FUNC_MEMCMP invocation.
See also https://github.com/net-snmp/net-snmp/issues/81.
commit 8c02e747d35d1df12c3482895879caf38e448c44
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Wed Mar 11 20:38:50 2020 +0100
fsys_mrtent: add glusterfs as a recognized filesystem type.
Thanks to Josef Ricky.
commit 3bc8e2de4e54b7c5f72f0c4d1b753d0c32ae9805
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Wed Mar 11 20:26:27 2020 +0100
snmplib/parse: change the tclist (TEXTUAL-CONVENTION) data structure
to be dynamically allocated.
commit ddb3a0b1f8b8cf2734f9c2cc4e434c79370b2cb5
Author: Mukesh Jain <mukesh.jain@newnet.com>
Date: Tue Mar 3 03:47:49 2020 +0530
snmpd: Fix a memory leak in handle_agentx_packet()
Fix a memory leak when contextName is used in the PDU. The memory for
contextName is assigned to community and is hence lost. This patch
fixes the following Valgrind complaint:
at 0x4C29EA3: malloc (vg_replace_malloc.c:309)
by 0x653F294: snmp_clone_mem (in /usr/lib64/libnetsnmp.so.31.0.2)
by 0x653F3E7: ??? (in /usr/lib64/libnetsnmp.so.31.0.2)
by 0x653F90D: snmp_clone_pdu (in /usr/lib64/libnetsnmp.so.31.0.2)
by 0x60E3837: handle_agentx_packet (in /usr/lib64/libnetsnmpagent.so.31.0.2)
by 0x6567ED0: ??? (in /usr/lib64/libnetsnmp.so.31.0.2)
by 0x6568F40: _sess_read (in /usr/lib64/libnetsnmp.so.31.0.2)
by 0x65698A8: snmp_sess_read2 (in /usr/lib64/libnetsnmp.so.31.0.2)
by 0x65698FA: snmp_read2 (in /usr/lib64/libnetsnmp.so.31.0.2)
by 0x656993B: snmp_read (in /usr/lib64/libnetsnmp.so.31.0.2)
by 0x60DF30A: agent_check_and_process (in /usr/lib64/libnetsnmpagent.so.31.0.2)
See also https://github.com/net-snmp/net-snmp/pull/78.
See also https://github.com/net-snmp/net-snmp/issues/58.
[ bvanassche: modified commit message and patch ]
commit 67fde288efa0d07df2dbd5dcc3d39b937b69b176
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Mon Mar 2 21:18:52 2020 +0100
Support for NetBSD 9.0
commit a49aa9c132cd38a9170de19b454dc27a67c2683c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Feb 28 20:26:34 2020 -0800
ci: Skip the DTLS and TLS tests
Since the DTLS and TLS code is broken, skip the corresponding tests.
commit b900b83258aa8b92895b9f988b02a1b086420322
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Feb 28 20:14:54 2020 -0800
libsnmp: Fix cert:map:secname fingerprint selection
See also https://github.com/net-snmp/net-snmp/issues/75.
Fixes: f51321751caf ("lots of new cert functionality")
commit a7c4831997a1deaf8a6a285babea28877bae15a8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Feb 25 21:15:19 2020 -0800
libsnmp: Surround MAKE_ENTRY() definition with do { } while (0)
commit eecd4d23b166a49ba4840264a4763ae5f9caad0e
Author: Gisle Vanem <gvanem@yahoo.no>
Date: Tue Feb 25 20:50:55 2020 +0100
libsnmp: Surround multiple macros with do { } while (0)
This patch suppresses the following clang warning:
empty expression statement has no effect; remove unnecessary ';' to silence this warning
See also https://github.com/net-snmp/net-snmp/pull/76.
[ bvanassche : combined three patches into one ]
commit e1d9a6181dd46dc14101665c38a3c875d8b6f303
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 22 14:44:18 2020 -0800
configure: Upgrade libtool and automake
The parts of the configure script generated by libtool and aclocal come from
libtool v2.4 (released on 2010-09-21) and automake v1.11 (released on
2009-05-16). Upgrade libtool to v2.4.6 and automake to v1.11.6.
commit db50cd646a49cf18c91c63a0737eb7a704e69099
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 22 08:13:06 2020 -0800
CHANGES: Remove dmalloc and efence support
Tools like dmalloc and efence were important to root cause memory corruption
issues until about 2005, when Valgrind became available. Remove support for
dmalloc and efence since tools like Valgrind and compiler sanitizers are
superior compared to dmalloc and efence. For more information about Valgrind
and the compiler sanitizers, see also:
* http://valgrind.org/
* https://en.wikipedia.org/wiki/AddressSanitizer
* https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html
commit f4ae8cf7d808ba54761d6ba8bd593c7a6669b9c3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jan 14 18:39:45 2019 -0800
configure: Re-enable shared library support for FreeBSD 10 and later
See also
https://lists.freebsd.org/pipermail/freebsd-current/2013-March/040460.html .
See also commit 7d66a35cd6bf ("configure: Enable shared library support for
FreeBSD 10 and later") # v5.8.1.pre1.
Fixes: 84355f7122da ("configure: Regenerate with autoconf v2.69").
commit 10823f0194e167b2e7860acd4f96d14380ae36b3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 22 07:55:55 2020 -0800
configure: Add exp() library to LMIBLIBS instead of LIBS
This change allows the ceil() test to add -lm to LNETSNMPLIBS.
This patch is a follow-up for commit d63e35a3a384 ("configure: Add -lm to
LNETSNMPLIBS if ceil() exists in libm").
See also https://github.com/net-snmp/net-snmp/issues/72.
commit 21e318b418f206cd3acc22f3ff7a58b864f287f0
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Feb 21 20:33:07 2020 -0800
dist/autoconf-version: Bump to v2.69
Fixes: 9a2753282c6a ("new autoconf")
commit d63e35a3a384c9f917bc4ab117d9239af2f01fc4
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Feb 21 19:42:11 2020 -0800
configure: Add -lm to LNETSNMPLIBS if ceil() exists in libm
See also https://github.com/net-snmp/net-snmp/issues/72.
Reported-by: Stuart Henderson
Fixes: 7497e2eade8a ("check if libm is needed for ceil function") # v5.8.pre2
commit f0f9279ad18ff03542e6dae156b6633628d36762
Author: Stuart Henderson <stu@spacehopper.org>
Date: Fri Feb 21 14:59:21 2020 +0000
TCP-MIB, UDP-MIB: Fix these tables for OpenBSD >= 5.6
OpenBSD changed from CIRCLEQ to TAILQ for inpt_queue in OpenBSD 5.6
(November 2014), the version of Net-SNMP in ports has been carrying this
patch since then.
[ bvanassche: modified patch title ]
commit bd276c697ae51cb7744b6731477f67203430cdbf
Author: Stuart Henderson <sthen@users.noreply.github.com>
Date: Fri Feb 21 14:56:05 2020 +0000
snmpps: Avoid null pointer dereference for SNMP_NOSUCHOBJECT
Handle SNMP_NOSUCHOBJECT as well as SNMP_NOSUCHINSTANCE. If snmpps/snmptop
are pointed at an agent which doesn't provide the required objects, before
this change it tries to dereference a null pointer when setting the
variables (noticed against OpenBSD snmpd which only implements part of
hrSWRunPerf and misses CPU/Mem).
[ bvanassche: modified patch description ]
commit 9a2753282c6a8dc09ed5dc4bc01683e8ba1f4850
Author: Wes Hardaker <opensource@hardakers.net>
Date: Thu Feb 20 14:23:41 2020 -0800
new autoconf
----------------------------------------------------------------------
Changes: V5.8.1.pre1 -> V5.8.1.pre2
commit 8436b3bbf944b87873e31c3c81694f03635082bf
Author: Wes Hardaker <opensource@hardakers.net>
Date: Tue Feb 18 15:41:04 2020 -0800
Version number update: 5.8.1.pre2
commit 473734ac3302210b4bf4175e20657029d55439e5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 8 09:36:58 2020 -0800
perl: Use netsnmp_memdup() where appropriate
commit dac831d3220e2ff9013955a314aada6c1c88fef5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Feb 7 20:13:06 2020 -0800
perl: Allow empty strings in notifications
Adding a string of length zero is not necessarily an error. In fact, treating
it as such, prevents us from sending the empty string as an otherwise valid
OCTET STRING in traps/notifications.
This is a modified version of a patch provided by Peter Valdemar Mørch
<peter@morch.com>.
commit 6725c4f7219fca50b7e455bcf2efc5bdfe7e9469
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Feb 7 20:06:52 2020 -0800
perl: Only call netsnmp_malloc() if necessary
Change the netsnmp_malloc() call into a netsnmp_memdup() call and only call
that function if len > 0.
This is a modified version of a patch provided by Peter Valdemar Mørch
<peter@morch.com>.
commit db95f59860c0d06e3aa591e71a278630dc3f48ee
Author: Alexander Dahl <post@lespocky.de>
Date: Wed Feb 5 01:49:37 2020 +0100
Add unit test for int8_t input to snmp_set_var_value()
This new test fails on 32bit arm, e.g. on Raspberry Pi, but not on x86
or x86_64. See output of a failing test:
Testing snmp_set_var_value() ................................ 1/?
not ok 3 - 128 =?= -128
not ok 5 - 233 =?= -23
not ok 7 - 255 =?= -1
Testing snmp_set_var_value() ................................ Failed 3/13 subtests
Reason is type "char" can be signed or unsigned, but
snmp_set_var_value() implicitly assumes "char" is always signed.
[ bvanassche: reformatted unit test source code ]
commit a3a4e65b5d4fdd37520d75e74d5f0f57501326a4
Author: Alexander Dahl <ada@thorsis.com>
Date: Tue Feb 4 15:34:29 2020 +0100
libsnmp: Cast signed char to signed int when setting value
We have an INT8 in a MIB, an Integer32(-128..127) to be more specific.
In a custom software we call 'snmp_pdu_add_variable()' with
type == ASN_INTEGER and len == 1. Deeper down the code path, we come to
'snmp_set_var_value()' and this part:
else if (vars->val_len == sizeof(char)) {
if (ASN_INTEGER == vars->type) {
const char *val_char
= (const char *) value;
*(vars->val.integer) = (long) *val_char;
} else {
const u_char *val_uchar
= (const u_char *) value;
*(vars->val.integer) = (unsigned long) *val_uchar;
}
Obviously the intent is to cast depending on whether the integer is
supposed to be signed or not, but although he jumps to the right code
path here, the result in vars->val.integer is wrong then. It does not
work with type 'char' like above.
We got values looking unsigned added to our pdu which we set to our
net-snmp server then and got them back unsigned on SNMP get requests
later, for example we fed an int8_t with value -32 we read back 224.
So this patch explicitly uses type 'signed char' which works for us.
Compiler is gcc 4.7 and we're cross-compiling for
arm-v5te-linux-gnueabi on Linux.
Fixes: 8e7458661b0eeb72d787a69cb915c16b151beee1
Signed-off-by: Alexander Dahl <ada@thorsis.com>
commit dd6cb372db7c1d7ca606c0d13c48f20148da8038
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 1 11:21:47 2020 -0800
FreeBSD, HOST-RESOURCES-MIB: Fix two compiler warnings
Fix the following compiler warnings:
hardware/cpu/cpu_sysctl.c:204:20: warning: unused variable 'mem_mib' [-Wunused-variable]
int mem_mib[] = { CTL_VM, NETSNMP_VM_STATS };
^
hardware/cpu/cpu_sysctl.c:205:20: warning: unused variable 'mem_size' [-Wunused-variable]
size_t mem_size = sizeof(NETSNMP_VM_STATS_TYPE);
^
Fixes: 2bbad43c53ff ("Patch for cpu_sysctl for FreeBSD 12")
commit d4d09af41f6e794271e62a986f2216357f8f11ef
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 1 11:33:47 2020 -0800
FreeBSD, HOST-RESOURCES-MIB: Move a misplaced comment
commit 5846564f5be46e0e362be894d4cb57be383c5b3d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 1 10:28:48 2020 -0800
FreeBSD, HOST-MIB: Fix a memory leak in swrun_kinfo.c
See also:
* https://sourceforge.net/p/net-snmp/bugs/2717/.
* https://sourceforge.net/p/net-snmp/patches/1341/.
* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219072.
commit 7229e320abd63512ba7e9d69adaa5f44553c6566
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Feb 1 10:11:34 2020 -0800
HOST-MIB: Remove a superfluous include directive
The only source file from which _ftime() is called is snmplib/gettimeofday.c.
Hence do not include <sys/timeb.h> from the host MIB implementation.
commit 0ded321a1588b7e1281f505c2f6266aa979168c6
Author: Thomas Abraham <tabraham@suse.com>
Date: Tue Jan 7 11:20:39 2020 -0500
Recognize NSS pools and NSS volumes (Open Enterprise Server)
commit bd92f4d6fec0dd278c8092c95437d09903c16bb2
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jan 3 18:33:28 2020 -0800
configure, include/net-snmp/net-snmp-config.h.in: Fix a description
Fixes: 5da4fc8c8e08 ("MinGW64: Fix select() and ioctlsocket() calls")
commit d3e17f70f26898dfe870cff03c56be628b9c0fd2
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Dec 7 15:34:31 2019 -0800
Fix -D_FORTIFY_SOURCE=1 compiler warnings
See also https://github.com/net-snmp/net-snmp/issues/51
Reported-by: coding@rms95.nl
commit 2c837e1811b49278d8ec34185f14c2651adeda79
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Nov 24 16:51:44 2019 -0800
ci/perl.bat: Bump the Perl version from 5.31.2 to 5.31.6
commit d418c635e68a95711b617c4d348fb806746329df
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Nov 29 20:21:52 2019 -0800
ci/net-snmp-run-tests: Do not run the DTLS tests
Do not run the DTLS tests since these tests fail systematically against
OpenSSL version 1.1.1 and later.
commit f67a451c509a0482c37ea53989bdde3b68ac4f43
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Nov 29 19:26:59 2019 -0800
testing/RUNFULLTESTS: Add command line option -e for excluding tests
commit 9fe45caf87ae6faf405d938ce0dfb6e3456bed4e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Nov 28 20:56:09 2019 -0800
libsnmp: Fix spelling of 'implementation' in a source code comment
commit 964700dc4382e7b39cc58438a4c48d50ea2a266f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Nov 26 18:38:08 2019 -0800
.gitignore: Add netsnmp.pc and netsnmp-agent.pc
See also https://github.com/net-snmp/net-snmp/issues/42.
commit 6624b240e034e8f8a85acd09d19519150df2c0a3
Author: Sam Tannous <stannous@cumulusnetworks.com>
Date: Wed Nov 13 11:20:46 2019 -0800
Add new config option to limit max number of interfaces for IF-MIB
This patch introduces a new config option "ifmib_max_num_ifaces NUM"
This patch sets the maximum number of interfaces included in IF-MIB
data collection. For servers with a large number of interfaces
(ppp, dummy, bridge, etc) the IF-MIB processing will take a large
chunk of CPU for ioctl calls (on Linux). Setting a reasonable
maximum number of ifaces for the CPU used will reduce the CPU
load for IF-MIB processing. For example, configuring
"ifmib_max_num_ifaces 500" will include only the first 500
interfaces based on ifindex and ignore all others for IF-MIB
processing.
Signed-off-by: Sam Tannous <stannous@cumulusnetworks.com>
[ bvanassche: combined two patches into one and removed one unused variable ]
commit 0a6e8c3311594e6449fc2b4df52ca03556b890bc
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Oct 28 18:54:48 2019 -0700
libsnmp: Re-export two USM functions
See also commit ee65591fba88 ("libsnmp, USM: Unexport more functions").
Reported-by: Joe Clark <joeclarkia@gmail.com>
commit b4ec525601709d4004d5c0746f0d6f62111b5006
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Oct 23 14:18:13 2019 -0700
libsnmp: Port to OpenSSL 1.1.1e
See also OpenSSL commit b13342e933c5 ("Modernise the ERR functionality
further (new functions and deprecations)").
commit b0f60ff42e0126a71f97b9733f2df211b37342d0
Author: Sam Tannous <stannous@cumulusnetworks.com>
Date: Wed Oct 9 12:58:14 2019 -0700
Reduce CPU load for IF-MIB on Linux servers with large number of interfaces
This patch introduces a new configution option to limit the number
of interfaces that the IF-MIB will process. On Linux servers with a
large number of interfaces (ppp, dummy, bridge, etc.), the IF-MIB
timer based stats collector can take a large amount of CPU processing.
The new config option "include_ifmib_iface_prefix" takes a space
separated string of ifname prefixes ("eth lo bridg") and will only
include interfaces with these prefixes in the IF-MIB tables.
If this config option is not present (the default), all interfaces
will continue to be processed in the IF-MIB.
Signed-off-by: Sam Tannous <stannous@cumulusnetworks.com>
[ bvanassche: Moved the netsnmp_access_interface_init() call from
init_mib_modules() into the MIB implementations that depend on that call. ]
commit 0917aead00854aa7458fa5f7341f01261aa88bb6
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Oct 22 07:51:14 2019 -0700
libsnmp: Restore the second argument of snmp_parse()
Since converting a netsnmp_session pointer into a struct session_list
pointer is not possible if a session has not been registered, restore
the second argument of snmp_parse(). This patch reverts f11583ee7bef
("libsnmp: Remove one argument from snmp_parse()").
commit 34991ccfc3494ab4ea987adbbe6d6deb207153f7
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Oct 19 09:30:30 2019 -0700
libsnmp: Document snmp_build() and snmp_parse()
commit 46a49c9f692073e7bf5742578e9668b3e366a402
Author: Sławomir Nizio <poczta-sn@gazeta.pl>
Date: Fri Oct 18 12:53:11 2019 +0200
libsnmp: Expose snmp_build and snmp_parse
[ bvanassche: Ported this patch to the v5.8 branch ]
commit f11583ee7bef26c56408d6416054a904fa8521ca
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Oct 19 10:17:50 2019 -0700
libsnmp: Remove one argument from snmp_parse()
Since all snmp_parse() callers pass slp->session as the second argument
to this function, this patch does not change any functionality.
commit 8b957a68307fa0da7f6f4c4ad04142d9189b601f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Oct 16 18:55:26 2019 -0700
Makefiles: Remove the LIB_LD_LIBS variable
This variable is never set, hence remove all occurrences.
commit 361b93b76c87cd422f4ff670358351363241f15c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Oct 16 18:44:27 2019 -0700
agent: Fix libnetsnmptrapd linker flags
See also https://github.com/net-snmp/net-snmp/issues/29.
Fixes: e09bf1a5f2bf ("Use libtool for building").
Signed-off-by: Craig Small
[ bvanassche: Removed use of $(CPPFLAGS) while generating 'sedscript' ]
commit 9201c9479ffa78033aaff6ccf5f4f1a34a33791e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Oct 15 20:27:57 2019 -0700
agent: Improve robustness of handle_subagent_set_response()
Several users have reported that 'retsess' can be NULL. Avoid that the
agent crashes if retsess == NULL. See also:
* https://sourceforge.net/p/net-snmp/mailman/message/29293701/
* https://sourceforge.net/p/net-snmp/bugs/2468/
* https://github.com/net-snmp/net-snmp/issues/28
commit 5a0ac74b93efab05ee7fca3b13adc304c848dc28
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Oct 12 21:25:09 2019 -0700
apps: Fix potential buffer overflows
This patch fixes the following Coverity complaint:
CID 85476: Out-of-bounds access (OVERRUN)
overrun-buffer-arg: Overrunning buffer pointed to by &base[base_length] of 1024 bytes by passing it to a function which accesses it at byte offset 1031 using argument indexlen * 8UL (which evaluates to 8).
commit 9b65cf7edc31f6fb053c78bfaa2120e65dcb4719
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Oct 12 21:16:21 2019 -0700
apps/snmptop: Fix a memory leak complaint reported by Coverity
Fix the following Coverity complaint:
CID 85620: Resource leak (RESOURCE_LEAK)
leaked_storage: Variable oproc going out of scope leaks the storage it points to.
commit d0787a2c86a80e31756965c436fac67b7d1c0f9b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Oct 11 20:09:08 2019 -0700
HOST-RESOURCES-MIB, UCD-SNMP-MIB: Report empty strings correctly
See also https://github.com/net-snmp/net-snmp/issues/26.
Fixes: 9b9c0e287b4d ("MIBs: Use asprintf() instead of snprintf() to prevent truncation")
commit 76c4ea51a48d36458ee7cb31918535a2f421408a
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Oct 11 18:11:26 2019 -0700
LM-SENSORS-MIB: Log an error message if initialization fails
commit a8651678216d48c91c58e4aba6a6bd269383a122
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Oct 6 19:55:00 2019 -0700
libsnmp, netsnmp_tlstmAddr_restore_common(): Fix potential buffer overflows
Make sure that netsnmp_tlstmAddr_restore_common() does not write past the
end of the buffers passed as arguments. This patch fixes e.g. the following
Coverity complaint:
CID 344598: Out-of-bounds access (OVERRUN)
overrun-buffer-arg: Overrunning array name of 256 bytes by passing it to a function which accesses it at byte offset 256 using argument name_len (which evaluates to 256).
commit 48d06b9b46840e3933288dc1d09cdd58f21f55c9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Oct 6 11:49:21 2019 -0700
libsnmp: Remove a check from encode_keychange()
All callers pass a valid kcstring_len pointer. Remove a test of that
pointer. This patch fixes the following Coverity complaint:
CID 266316: Dereference after null check (FORWARD_NULL)
var_deref_op: Dereferencing null pointer kcstring_len.
commit ac09ffc5487ce3cae6f3f08e2dee5e01a89ef063
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Oct 6 09:51:30 2019 -0700
libsnmp, DTLSUDP transport: Remove a superfluous pointer check
All f_fmtaddr() callers dereference the transport pointer. This patch
fixes the following Coverity complaint:
CID 341230: Dereference after null check (FORWARD_NULL)
var_deref_op: Dereferencing null pointer t.
commit 8e6a1d6d6088bd85436c0184fbe30eec32a47e7f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Oct 6 09:47:45 2019 -0700
libsnmp: Fix a NULL pointer dereference in the asn_build_string() debug code
This patch fixes
CID 344578: Dereference after null check (FORWARD_NULL)
var_deref_model: Passing null pointer str to sprint_realloc_asciistring, which dereferences it.
commit 776308793cd4683dac7ef7605487c66ac908560f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Oct 6 07:28:33 2019 -0700
ci/openssl.bat: Bump the OpenSSL version
commit 05c544a48e45371d4450338c356c68503a7a45e6
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Oct 5 20:47:12 2019 -0700
IP-MIB: Fix a memory leak in an error path
This patch fixes the following Coverity complaint:
CID 344587 (#2 of 2): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable bcastentry going out of scope leaks the storage it points to.
commit da8c970d534c41455267ad5352ef06cc757c4c47
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Oct 5 20:44:38 2019 -0700
libsnmp, DTLSUDP transport: Fix memory leaks in error paths
commit 7efdf32d3281e113cc6bff6aca4f5a4354345de5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Oct 5 20:43:08 2019 -0700
libsnmp, DTLSUDP transport: Use free() to free buffers allocated with malloc()
This patch addresses the following Coverity complaint:
CID 344589 (#1 of 1): Incorrect deallocator used (ALLOC_FREE_MISMATCH)
free: Calling CRYPTO_free frees buffer using CRYPTO_free but it should have been freed using free.
commit 2f114d1d253fdb91de839ec874d46cd55e174d62
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Oct 5 20:32:00 2019 -0700
Linux: Stop including the header file <sys/sysctl.h>
According to the glibc authors <sys/sysctl.h> is considered deprecated on
Linux and including that header file triggers a compiler warning. See also
https://savannah.gnu.org/forum/forum.php?forum_id=9515.
commit 56e1909436c525753e42f82e608b6b47dbb83884
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Oct 5 18:00:43 2019 -0700
libsnmp, UDP shared transport: Handle memory allocation failures properly
This patch fixes the following Coverity complaint:
CID 344602: Write to pointer after free (USE_AFTER_FREE)
double_free: Calling netsnmp_transport_free frees pointer t which has already been freed.
commit 5eb25dac673782219ebc24621294960fbff5415e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Oct 5 17:44:56 2019 -0700
libsnmp: Fix an out-of-bounds read
This patch fixes the following Coverity complaint about the
snmp_set_var_value() call in get_first_logging_entry() in nsLogging.c:
CID 344604 (#1 of 1): Out-of-bounds access (OVERRUN)
overrun-buffer-val: Overrunning buffer pointed to by (u_char *)&temp of 8 bytes by passing it to a function which accesses it at byte offset 15.
commit 2ea95d6e4f5bd2426f39e08c7276a8582b02043b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Oct 5 17:37:03 2019 -0700
LM-SENSORS-MIB: Fix a use-after-free in case registration fails
This patch fixes CID 344606: Use after free (USE_AFTER_FREE)
pass_freed_arg: Passing freed pointer reg as an argument to netsnmp_inject_handler_before.
commit 5d61e93672004cea961f1b9129ee3b84e7e1701c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Oct 5 17:31:27 2019 -0700
snmplib, UDP transport: Do not compare array pointers against NULL
Comparing an array pointer against NULL is not useful. This was detected by
Coverity. See also commit 02de400544de ("libsnmp: Set Linux VRF iface on
Trap sink IP addresses").
commit f7d52958c71345900492abe29d05e6efe5ff7428
Author: Benjamin Hesmans <benjamin.hesmans@tessares.net>
Date: Tue Oct 1 16:12:05 2019 +0200
HOST-MIB: Fix hrSWRunPath reported string length
```
snprintf (...) return value is the number of characters (excluding the
terminating null byte) which would have been written to the final string
if enough space had been available.
```
The length of the string reported was not correct because of this.
snmpget would then misinterpret the value like :
iso.3.6.1.2.1.25.4.2.1.4.19031 = Hex-STRING: 2F 74 6D 70 2F 6C 6F 6F 6F
6F 6F 6F 6F 6F 6F 6F
6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F
6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F
6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F
6F 6F 6F 6F 6F 6F 6F 6F 6E 67 2F 6C 6F 6F 6F 6F
6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F
6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F
6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 6F 00
00 2D 70 6F 20 2D 72 61 6F 65 6B 72 6B 20 65 72
61 7A 00 00 00 00
after the patch :
iso.3.6.1.2.1.25.4.2.1.4.19031 = STRING:
"/tmp/loooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong/loooooooooooooooooooooooooooooooooooooooooooooooooooo"
Signed-off-by: Benjamin Hesmans <benjamin.hesmans@tessares.net>
[ bvanassche: changed patch title ]
commit e5b55323c00544b10e4780a752e1daad504e9d9e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Oct 1 21:29:51 2019 -0700
snmpd, ip-forward-mib: Fix a NULL pointer dereference
Dereference route_container after having checked whether or not that
pointer is NULL instead of before. See also
https://github.com/net-snmp/net-snmp/issues/15.
This patch has been provided by Amit Sharma.
commit 02de400544dea6804c348c457a5ea5ea5531b12d
Author: Sam Tannous <stannous@cumulusnetworks.com>
Date: Thu Sep 26 09:40:58 2019 -0700
libsnmp: Set Linux VRF iface on Trap sink IP addresses
For Linux VRF support in Traps, this patch fixes an issue (#12) where
configuring and iface on the sink IP address was not being bound (via
SO_BINDTODEVICE) to the socket. This was broken for versions 1, 2c, and 3.
While a clientaddr setting in snmp.conf could fix this, a user would have to
find and set a source IP address in the VRF to be used. This patch does not
require setting a clientaddr but simply binds the iface provided in the sink
IP address (target) to the session socket that will be used.
Signed-off-by: Sam Tannous <stannous@cumulusnetworks.com>
[ bvanassche: made minor edits to patch description and removed one space from
the patch itself ]
commit 160fcda849ed111f457f74310148be90670ea417
Author: Yuri Pankov <yuripv@yuripv.net>
Date: Sat Oct 6 13:48:35 2018 +0300
CHANGES: FreeBSD: Fix first byte of IF-MIB::ifPhysAddress
Don't write past the interface name, and use temporary copy instead.
This fixes the first byte of ifPhysAddress always being 0 on FreeBSD.
See also https://sourceforge.net/p/net-snmp/code/merge-requests/20/.
[ bvanassche: edited patch title / added test for malloc() result / reduced
number of free(if_name) calls ]
commit f059d6e66d4a0aed7b176182b9191615b7cf85ac
Author: Peter Valdemar Mørch <peter@morch.com>
Date: Wed Sep 25 18:23:15 2019 +0200
perl: Document format of SecEngineId
commit cff90fa9fe3afe88a498fb21a07bc7cb7cec46e8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Sep 22 22:23:43 2019 -0700
libsnmp, TLS-TCP transport: Fix spelling in log messages
commit feda56b6265d16f254fe70407920b2573ce78214
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Sep 22 21:57:36 2019 -0700
libsnmp: Split netsnmp_tlstcp_open()
The length of this function hurts readability. Hence split this function.
commit 525a063e7e7915e64fc202c656c65da45289d5cb
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Sep 22 21:29:44 2019 -0700
snmplib/cert_util.c: Remove a superfluous cast
commit d443bbd6fdbd6388387925e2457dfac54941f0d8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Sep 20 07:12:57 2019 -0700
UCD-SNMP-MIB: Fix parsing of 'proc' directives for process names with spaces
See also https://github.com/net-snmp/net-snmp/issues/10.
commit 90837dcec21cc2faa55711c6f823e97c87085dd3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Sep 15 16:17:14 2019 -0700
snmpd: Make the output of a trap debug message more detailed
An example of the new output:
trap: sending trap type=166, version=3 to UDP: [127.0.0.1]:162->[0.0.0.0]:37458
This should help with root-causing https://sourceforge.net/p/net-snmp/bugs/2978.
commit 7d2c65836b59fa6e1cd81bf9c4d7fa21f0947056
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Sep 15 12:58:46 2019 -0700
CHANGES: snmpd: Suppress OpenVZ related error messages
When snmpd is run inside an OpenVZ container neither /proc/bus/pci nor
/proc/diskstat are available and /proc/partitions is empty.
See also https://sourceforge.net/p/net-snmp/bugs/2975/.
Signed-off-by: Sergey Chernomorets
[ bvanassche: introduced init_libpci() and simplified this patch ]
commit 2633eedde135c2e69c92b82f702da783608c6009
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Sep 14 10:13:40 2019 -0700
CHANGES: snmpd: Reduce the time needed to execute "pass" scripts on BSD systems
See also https://github.com/net-snmp/net-snmp/issues/8.
commit a346dbcf7f1181510a2a39f14a45eb594db26e90
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Sep 11 08:41:09 2019 +0100
agent/mibgroup/ip-mib/ipv6InterfaceTable/ipv6InterfaceTable.h: Remove superfluous whitespace
commit 90fd668641c9c113d67f959677aae7f03b6f67fe
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Sep 11 08:27:23 2019 +0100
IF-MIB, MIB-II: Remove #ifdef SCNuMAX
SCNuMAX is available on Linux since a long time. Hence remove #ifdef SCNuMAX.
commit 9c00aaebe4316910b34f3ddc01b866db060680fc
Author: Sam Tannous <stannous@cumulusnetworks.com>
Date: Mon Sep 9 19:22:38 2019 -0700
linux: IF-MIB Counters (HwIfInOctets, HwIfOutOctets, etc.) became 32-bit counters
Recently, patch 64f4ead (libsnmp: Only include <inttypes.h> when necessary)
effectively removed inttypes.h from types.h and added it back for most files
except for
if-mib/data_access/interface_linux.c
This turned what were 64 bit counters (SCNuMAX is no longer defined) into
32 bit counters.
This patch simply adds inttypes.h back to interface_linux.c
correcting the counters.
Signed-off-by: Sam Tannous <stannous@cumulusnetworks.com>
[ bvanassche: Moved inttypes.h include directive up ]
commit 635ccb36d32f94097021191bc77c1b211c4f4209
Author: Anders Wallin <wallinux@gmail.com>
Date: Fri Feb 22 17:14:30 2019 +0100
CHANGES: BUG: 2926: Make it possible to set agentXPingInterval for a subagent
- register agentXPingInterval for the subagent list handler,
before it was registered for snmp
- added agentxTimeout to the subagent list handler.
It's now possible to set for snmpd and the subagent.
See 'man snmpd.conf'
- added agentxRetries to the subagent list handler.
It's now possible to set for snmpd and the subagent.
See 'man snmpd.conf'. It's never used in the subagent,
but it's now following the documentation
Signed-off-by: Anders Wallin <wallinux@gmail.com>
commit bcb1a6b8afc444bbcd099a195e08f0b01cbc8f6b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Sep 6 14:51:35 2019 -0700
HOST-MIB, hr_filesys: Fix Check_HR_FileSys_AutoFs()
On Linux getmntent() is available but getfsstat() not. Hence remove #if
HAVE_GETFSSTAT from around the HRFS_type check.
See also https://sourceforge.net/p/net-snmp/patches/1350/.
Fixes: cf41e6e91015 ("HOST-MIB: Skip autofs entries").
commit a2334651b84878222b6a758154b283bcf8b233ef
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Sep 6 14:49:32 2019 -0700
HOST-MIB, hr_filesys: Clean up HRFS_ignores[]
Declare the HRFS_ignores array static. Make sure that "autofs" occurs once.
Define MNTTYPE_AUTOFS if necessary.
commit 5e416538cf035a4a0856022327f6b5494b0506e3
Author: Wes Hardaker <opensource@hardakers.net>
Date: Wed Sep 4 14:50:22 2019 -0700
openssl 1.1.0 -> 1.1.1 per David Hauck
----------------------------------------------------------------------
Changes: V5.8 -> V5.8.1.pre1
commit f69459109f64555321421501344c6965dc6355fd
Author: Wes Hardaker <opensource@hardakers.net>
Date: Tue Sep 3 08:10:21 2019 -0700
Version number update: 5.8.1.pre1
commit 1b3ef39cb7a3a7142be5b250f36770fa9a011e61
Author: Wes Hardaker <opensource@hardakers.net>
Date: Tue Sep 3 08:04:19 2019 -0700
version update for 5.8.1.pre1
commit 5e3643e627568661daf65c4e0a9ab2be633952ef
Author: Wes Hardaker <opensource@hardakers.net>
Date: Tue Sep 3 07:59:35 2019 -0700
NEWS: snmpd: security vulnerabilty in the ping MIB reported by Christopher Ertl from Microsoft fixed
commit 2b0fc439d1507a267558b26e20edda13e0ad0d09
Author: Bill Fenner <fenner@gmail.com>
Date: Wed Aug 28 08:21:35 2019 -0700
snmpd.conf: document the "-s" argument to trap*
commit 7c073e3a1b736689135fd2ed44ede5b83790bd37
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Aug 26 18:32:08 2019 -0700
IP-MIB, Linux: Fix a memory leak in an error path
When a Linux system is booted with "ipv6.disable=1" in the kernel command
line, the file "/proc/net/snmp6" is not created. Fix the memory leak in
_systemstats_v6_load_systemstats() that is triggered with IPv6 disabled.
See also https://sourceforge.net/p/net-snmp/bugs/2976/.
Reported-by: Mark E Rusk <marker55@users.sourceforge.net>
commit 37e498fdcde98ee93875a750dbcd5a8a9ba336b1
Author: Bill Fenner <fenner@gmail.com>
Date: Mon Aug 26 18:17:40 2019 -0700
SNMP-TARGET-MIB: express features used (broken by 58ae9e6b11)
commit 904aefa5a241473f2075e60147a307b2250a4853
Author: Bill Fenner <fenner@gmail.com>
Date: Mon Aug 26 18:07:05 2019 -0700
ci: skip mibs that do not support read-only
commit f8168d8f56744d1b96e776e863eae138253c18b9
Author: Bill Fenner <fenner@gmail.com>
Date: Mon Aug 26 14:33:30 2019 -0700
minimalist: adapt to semicolon-terminated feature macros
commit a0aa55d4541906bdc7b92c9db3f4282d9aa6fb48
Author: Bill Fenner <fenner@gmail.com>
Date: Mon Aug 26 14:44:12 2019 -0700
ci: display configure command in Travis log
commit f024ffeaef028d5db44dc40b97e53c352b573d4f
Author: Bill Fenner <fenner@gmail.com>
Date: Mon Aug 26 14:58:08 2019 -0700
ci: fix env configuration
commit 22ce0a3e6d43ca0fd7451d13328bce7b719d549f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Aug 25 07:44:11 2019 -0700
Win32: Remove most references to ActiveState Perl
Several years ago the ActiveState Perl binaries were built with Microsoft
Visual Studio. Today the ActiveState Perl binaries are built with gcc. This
makes ActiveState Perl inappropriate for building Net-SNMP Perl modules with
Microsoft Visual Studio. Hence remove most references to ActiveState Perl.
commit c887c216fc6a0cc9cd840e31742fba7f7bf5c8eb
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jan 23 20:40:00 2019 -0800
testing: Make it possible to run the Perl tests without installing Net-SNMP
commit 3eadd6e2e4b2d4d118f7d4fe7ed329880c667e39
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jan 12 15:28:11 2019 -0800
perl: Fix "use of uninitialized value $ENV{"OSTYPE"}" warnings
The bash shell sets the OSTYPE environment variable but FreeBSD sh not.
Hence check whether $OSTYPE has been set before using its value.
[ bvanassche: backported this patch from the master branch ]
commit d1a3c063b58b063feec4e58d7d1245ae0644cb47
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Nov 19 18:59:03 2018 -0800
snmpd, MIB-II: Fix a compiler warning in TCP_Count_Connections()
Avoid that the compiler reports the following on Linux:
mibII/tcpTable.c:341:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
Fixes: 7f3abe7515d5 ("Patch for tcpTable for FreeBSD 12")
[ bvanassche: backported this patch from the master branch ]
commit 54c71b0376b1597e01bf88187a9b807502526ec2
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jun 6 11:20:42 2018 +0200
snmplib, MIBs, Python: Fix gcc 8 warnings
Avoid that gcc 8 complains about incompatible function casts. This
patch does not change any functionality.
[ bvanassche: backported this patch from the master branch ]
commit f12c3f87e0c05c69e851ae1c152fa3c29d02f0df
Author: Robert Story <rstory@freesnmp.com>
Date: Wed Nov 16 23:12:03 2016 -0500
Perl: Initialize session objects correctly
[ bvanassche: backported this patch from the master branch ]
commit 10a689b732c02ec8990400fbced0d0134b78c799
Author: Robert Story <rstory@freesnmp.com>
Date: Thu Oct 13 13:43:42 2016 -0400
add range check; init vars to keep compiler happy
[ bvanassche: backported this patch from the master branch ]
commit 87bd90d04f20dd3f73e3e7e631a442ccd419b9d3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Aug 13 20:54:23 2019 -0700
libsnmp: Move the free_securityStateRef() call into snmp_free_pdu()
This patch fixes a memory leak that was introduced in commit 5f881d3bf245
("libsnmp, USM: Introduce a reference count in struct usmStateReference").
This patch partially reverts commit adc9b71aba91 ("snmpd: Avoid that snmpv3
bulkget errors result in a double free").
See also https://sourceforge.net/p/net-snmp/bugs/2938/.
commit f124907b2a814dc2db2b3fd806a7cf9e83af5fc5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Aug 11 12:25:22 2019 -0700
include/net-snmp/types.h: Remove a superfluous forward declaration
commit 171ca693cf7b3d089e69042b5d187c45e1cf2303
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Aug 11 12:00:00 2019 -0700
doxygen.conf: Fix INCLUDE_PATH
commit deaf0a7d29ad0a6b4e8ee84fedcc30a0edd61921
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Aug 11 12:11:53 2019 -0700
libsnmp, feature checking: Trigger a syntax error if the terminating semicolon is missing
commit 59a6f52f1e64391d1fc08cb391651c60ff7ed047
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Aug 13 19:58:05 2019 -0700
treewide: Terminate netsnmp_feature_*() uses with a semicolon
This patch has been generated by the following shell command:
git grep -l netsnmp_feature_ |
while read f; do sed -i 's/^netsnmp_feature.*[^;]$/&;/' "$f"; done
commit f3e80746fde826cf4665fb959bda78cce061c883
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Aug 5 20:15:37 2019 -0700
AgentX: Fix a use-after-free
When calling snmp_async_send(), the callback function is called whether or
not sending succeeds. Since the agentx_got_response() callback function
frees the cache unconditionally, calling netsnmp_free_delegated_cache()
explicitly after snmp_async_send() is wrong.
See also https://sourceforge.net/p/net-snmp/bugs/2943/.
Fixes: f9304c83f762 ("CHANGES: PATCH 1633670: fixed snmpd crashing when an AgentX subagent disconnect in the middle of processing of a request.") # v5.8.
commit f7972681c8d35506b75ec5fd652633b47e437869
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Aug 5 20:02:09 2019 -0700
libsnmp: Document _sess_async_send()
commit 1300ebd66ac124139522542aef41ddc251d9f64e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Aug 5 20:05:17 2019 -0700
libsnmp: Fix Doxygen headers
commit 9d150386ca35d0adffc7de1618ec69501f2d3bb1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 3 18:38:46 2019 -0700
winExtDLL: Call pfSnmpExtensionInitEx() even if pfSnmpExtensionInit() returns FALSE
Fixes: https://sourceforge.net/p/net-snmp/bugs/2969/
commit 73f2db7f669504789626d1a4644b0a9c24311147
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 3 17:46:29 2019 -0700
Win32, MSVC: Use the /MANIFEST:EMBED linker option instead of mt.exe
This patch simplifies the Win32 Makefiles.
commit b439755400da5954c45d055e48668f5f92d1cd55
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 3 17:22:18 2019 -0700
Win32, MSVC: Remove _BIND_TO_CURRENT_VCLIBS_VERSION
Building with _BIND_TO_CURRENT_VCLIBS_VERSION defined is considered
questionable. Hence remove _BIND_TO_CURRENT_VCLIBS_VERSION. This
patch reverts commit b0a62eb19763 ("Define _BIND_TO_CURRENT_VCLIBS_VERSION
token (as per Alex' build instructions)") # v5.7.1.
commit ed685ee20a1bc48b1c52bf1e77a693693499971b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 31 12:53:02 2019 -0700
Win32, MSVC: Enable Blumenthal AES if OpenSSL is enabled
See also https://sourceforge.net/p/net-snmp/bugs/2966/.
commit 620c8438f8cbf0c62deddb27b13aa25004b2dfe1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Jul 25 15:19:35 2019 -0700
ci/perl.bat, Win32: Upgrade the Perl version from 5.30.0 to 5.31.2
commit bf391f4e98d4568a828d2c55f367cdddef7fa36f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jul 28 20:43:48 2019 -0700
apps/snmptable: Remove dead code
This patch fixes CID 345250 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach the expression (char *)buf inside this statement: printf("End of table: %s\n"....
commit 48550f0887528fe6e74315736f398ca53aa16171
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jul 28 20:45:17 2019 -0700
Perl modules: Fix a memory leak in an error path
This patch fixes CID 345251 (#1 of 1): Unchecked return value (CHECKED_RETURN)
5. check_return: Calling snmp_send without checking return value (as is done elsewhere 14 out of 15 times).
commit 5f881d3bf24599b90d67a45cae7a3eb099cd71c9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jul 27 19:34:09 2019 -0700
libsnmp, USM: Introduce a reference count in struct usmStateReference
This patch fixes https://sourceforge.net/p/net-snmp/bugs/2956/.
commit cae2cb04e05bbf74f8bfca0a7e6836c3c8144a6c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jul 28 21:07:38 2019 -0700
libsnmp, USM: Remove superfluous secStateRef tests
secStateRef is never NULL. Hence remove the tests that check whether that
pointer is NULL. This was detected by Coverity.
commit 42e21ea0279185d28219868612dbf83adac8b647
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jul 27 17:48:33 2019 -0700
libsnmp, USM: Unexport usm_create_user_from_session_hook()
commit 2b32a0d80576caf0cc77a101179ceebba124020e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jul 21 20:44:18 2019 -0700
libsnmp: Fix memory leaks in usm_process_in_msg() error paths
commit ee65591fba88648091ee3b72b1579a7b73581186
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jul 27 16:42:21 2019 -0700
libsnmp, USM: Unexport more functions
Additionally, remove usm_remove_usmUser() since that function has no
callers.
commit 8a97e3b4509ad07b155febb6a7bd8d70ad5d8033
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jul 27 07:29:40 2019 -0700
ci, Travis: Unbreak the Darwin build
Fixes: 102dafdd1b2e ("ci: Fix ubuntu xenial build")
commit 102dafdd1b2e2fa172008b5e84a8cf65b6bf3e40
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jul 26 22:00:42 2019 -0700
ci: Fix ubuntu xenial build
Apparently Travis CI switched to trusty to xenial a few days ago. Make
the Travis build work on xenial.
commit a0df31c18c513a0d79f4d526b1af7fad48748e57
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jul 26 21:40:12 2019 -0700
HOST-MIB: Fix a recently introduced bug
Fixes: cf41e6e91015 ("HOST-MIB: Skip autofs entries")
Note: this bug was not introduced by Josef but by me.
commit aba456530704d671a74c77ed8d1e60158b1e7261
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jul 26 20:58:33 2019 -0700
libsnmp, USM: Enable type checking for session pointers
commit e2c452c794705cd8b036e3fc4a04c1dc4e436cff
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jul 26 20:27:42 2019 -0700
libsnmp, USM: Declare two functions 'static'
commit b78cb2621a6dee3d7cbf5bc382a3a9a481de20ea
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jul 26 20:07:21 2019 -0700
libsnmp, USM: Unexport four user manipulating functions
commit d20c294762fba2fd33657fc571682921de1f5458
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jul 26 19:45:35 2019 -0700
libsnmp, USM: Unexport init_usm_post_config(), deinit_usm_post_config() and clear_user_list()
commit 9ae17fd957dc0ca18993edc56c68f2e34133a7d9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jul 26 10:54:19 2019 -0700
Perl modules, Win32: Suppress C compiler warnings about integer assignments
commit 944284745ef9d4ddc877202e258722f16e3afacb
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jul 26 08:18:20 2019 -0700
Perl modules: Split NET-SNMP-CFLAGS into NET-SNMP-INC and NET-SNMP-DEFINE
commit 665cf2f66b9fc5a3f6afe4e75b7a1809e4a99515
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Jul 25 15:04:01 2019 -0700
ci, MSVC: Build Perl modules
commit bca38bcc7284a9a69f4d55768a8d2eb21fe40ad4
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Jul 23 16:50:44 2019 -0700
ci, MSVC: Build and install Perl
commit 07ed2514cc6ea863ec403eab6e2bb8bda2e6dd3e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Jul 25 12:40:00 2019 -0700
Perl modules, MSVC: Pass the OpenSSL include path to Perl MakeMaker
commit 2a20a2a6169da21bca90ea23645ffdca6e09768c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Jul 23 21:36:35 2019 -0700
perl, Win32: Set PERL5LIB
This is required for Perl 5.30.0. See also
https://sourceforge.net/p/net-snmp/bugs/2963/. See also
https://perldoc.perl.org/perl5260delta.html#Removal-of-the-current-directory-(%22.%22)-from-%40INC.
commit ac6963606664099da58aa32a8c6ecac4ad7990b9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 24 16:38:04 2019 -0700
perl modules: Remove the now superfluous #define _WIN32_WINNT 0x501
commit 9e8c1a413b2deca943d89414c0aeab6c15f97303
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 24 15:17:27 2019 -0700
Perl, MakeMaker, Win32: Define Net-SNMP C macros while building Perl modules
This patch fixes https://sourceforge.net/p/net-snmp/bugs/2965/.
commit f0292ee2edb038d52927f1b4330e315eadc42027
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 24 15:23:26 2019 -0700
Perl, MakeMaker: Remove NetSNMPGetOpts() argument
commit df5ac81d2a662b2085d4272a7c6fb3902e5f697d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 24 13:09:05 2019 -0700
Perl, MakeMaker: Introduce AddCommonParams()
This patch reduces code duplication.
commit fe7558b32d52a50034332d353cb306e6a2b926db
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 24 14:40:10 2019 -0700
Perl, MakeMaker: Check all net-snmp-config invocations
Fail if invoking net-snmp-config fails.
commit 895a4c1ad8271be85bd35542f92ce80b2a3d9411
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 24 14:21:42 2019 -0700
Perl, MakeMaker: Always set $MakefileSubs::basedir
This change will allow to use $MakefileSubs::basedir on the Windows platform
in a later patch.
commit 3d175504fd9c6aa97210e31bc610afdd6f16623d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 24 20:39:21 2019 -0700
perl/MakefileSubs.pm: Set $opts->{'debug'}
Avoid that using $opts->{'debug'} causes Perl to complain about using an
undefined value.
commit 631bb2f2343ad4b5643f514d0e3b737b24bf00eb
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 24 14:48:19 2019 -0700
Perl modules: Convert to C89 function declaration syntax
commit 2fbf8dec41710ab5d46110b07e3d1753c6ae2330
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 24 16:01:53 2019 -0700
ci, Appveyor: Download and install OpenSSL once
commit cf41e6e910158fb4c4cb546c49acd587c5f58232
Author: Josef Ridky <jridky@redhat.com>
Date: Wed Jul 24 07:23:47 2019 -0700
HOST-MIB: Skip autofs entries
Do not call statfs() for autofs entries.
See also https://sourceforge.net/p/net-snmp/patches/1350/.
See also https://sourceforge.net/p/net-snmp/bugs/2968/.
[ bvanassche: Made several small edits ]
commit 39381c4d20dd8042870c28ae3b0c16291e50b705
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Jul 23 10:52:28 2019 -0700
libsnmp: Unexport struct usmStateReference
Certain snmpd crashes can only be fixed by introducing a reference
count in struct usmStateReference. Unexport that structure such that
changing it does not affect the ABI.
commit bfcd20d9478bb5541fbf0bbf3bc7f857e82a3357
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Jul 23 08:28:38 2019 -0700
win32/Configure: Define NETSNMP_REMOVE_U64
See also https://sourceforge.net/p/net-snmp/bugs/2965/.
Reported-by: Harmdhast <harmdhast@users.sourceforge.net>
commit 5293fe9902755b9c4ce9cb0a5fc64ed3ace0ff29
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jul 22 08:55:41 2019 -0700
libsnmp: Fix several Valgrind complaints
Avoid that Valgrind complains about reading uninitialized memory on
random numbers generated by the OpenSSL library. Avoid that Valgrind
complains about received SSL data not having been initialized.
commit 51ea70063882110e69be15d338ba3b86f1d98c38
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jul 21 20:55:29 2019 -0700
libsnmp: Optimize snmp_free_pdu()
Remove commented-out code that would trigger a use-after-free if enabled.
Remove the memset() call that occurs just before the last free() call
since today there are better tools for detecting use-after-free issues,
e.g. Valgrind and AddressSanitizer.
commit e59ccc374c463236416e036c8dd0702eb1da8f6f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jul 22 19:12:06 2019 -0700
testing/fulltests/unit-tests/T104agentx_parse_cagentlib: Add to repository
This test is a reproducer for
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=14502.
commit 8b429a54b495fb69aa2efa4f15a815aaedd69f0c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jul 22 19:48:16 2019 -0700
AgentX: Fix an integer overflow
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=14502
commit 341eef1b98e5406575aa4ec4708d3ab4615069ca
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jul 21 12:15:52 2019 -0700
libsnmp: Add ref argument to the MAKE_ENTRY() macro
Make it explicit that 'ref' is an argument of the MAKE_ENTRY() macro.
commit b8a882812ac08da4add3f5df53300a656fecdb17
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jul 21 20:47:58 2019 -0700
RMON-MIB: Fix a compiler warning
Fix the following compiler warning:
Rmon/alarm.c: In function 'var_alarmEntry':
Rmon/alarm.c:648:20: warning: cast discards 'const' qualifier from pointer target type [-Wcast-qual]
648 | return (unsigned char *) "";
|
commit 5ff6745c103abbac55d20892bddee66351ec554f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jul 21 20:46:01 2019 -0700
RMON-MIB: Fix a NULL pointer dereference in an error path
This was detected by gcc.
commit 273cd33796133a1642dcfbcae33935fce776911e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Jul 2 21:18:58 2019 -0700
perl Makefiles: MinGW / MSYS fixes
This patch improves but does not fix the MinGW / MSYS Perl module build
entirely.
commit 9ba4d351b42f2c46ea53d09546b7dd20b6200cde
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Fri Jul 19 07:41:01 2019 +0200
Reorder ifdefs to unbreak DragonflyBSD compilation.
commit c82bc0f099b03c31f69daaf5106884c7cb008cb1
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Fri Jul 19 07:40:10 2019 +0200
snmptable: fix crash when agent has more columns than MIB.
commit 2014ae27a44e6121acefd37db8091e075947b27a
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Tue Jul 16 22:10:21 2019 +0200
nmptable: detect and fail on non-increaing OIDs.
commit 51df0da6f65be33ffc9723688318338fc4cce5c9
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Tue Jul 16 22:01:15 2019 +0200
testing: Debian 10 (buster) moved ss to /usr/bin/ss
commit ef6db67f708f6590fb9d2797022ca1d957c89073
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 10 18:15:15 2019 -0700
Revert "NET-SNMP-SYSTEM-MIB, Linux: Update calculation of free space"
Since there is a risk that this patch breaks existing monitoring
software, revert it.
commit a88d81f1144ecf33f0ca02ada042b77368855a94
Author: Josef Ridky <jridky@redhat.com>
Date: Thu Jul 4 08:45:19 2019 +0200
NET-SNMP-SYSTEM-MIB, Linux: Update calculation of free space
Update calculation of free space for Physical and Virtual memory on linux.
Based on https://gitlab.com/procps-ng/procps/blob/master/proc/sysinfo.c#L789
[ bvanassche: edited patch subject ]
commit 18b7ab7ae81293e48fc6f24c085a536ac2dbf6da
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jul 3 20:58:41 2019 -0700
NET-SNMP-SYSTEM-MIB, Linux: Read /proc/meminfo once
With recent Linux kernels the size of /proc/meminfo exceeds 1279 bytes.
Hence increase MEMINFO_INIT_SIZE and MEMINFO_STEP_SIZE.
commit 4e3ace87b566c80585001bb55efe5886d0a9474f
Author: Michael Rodrigues <michael.rodrigues@logicmonitor.com>
Date: Wed Jul 3 20:49:16 2019 -0700
NET-SNMP-SYSTEM-MIB: Account reclaimable space
See also:
* https://gitlab.com/procps-ng/procps/commit/05d751c4f076a2f0118b914c5e51cfbb4762ad8e
* https://sourceforge.net/p/net-snmp/patches/1338/
* Linux kernel commit 972d1a7b1405 ("[PATCH] ZVC: Support NR_SLAB_RECLAIMABLE / NR_SLAB_UNRECLAIMABLE") # v2.6.19.
[ bvanassche: rewrote patch description / removed error message if SReclaimable is not found ]
commit 4fd9a450444a434a993bc72f7c3486ccce41f602
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 22 09:56:21 2019 +0200
CHANGES: snmpd: Stop reading and writing the mib_indexes/* files
Caching directory contents is something the operating system should do
and is not something Net-SNMP should do. Instead of storing a copy of
the directory contents in ${tmp_dir}/mib_indexes/${n}, always scan a
MIB directory.
commit 5ed1bc566a02c800f18e8439aa00e758158594ca
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jun 29 14:49:25 2019 -0700
SNMP-TARGET-MIB: Improve error messages
Make it clear why adding a trap destination fails if the security name
is missing.
See also https://sourceforge.net/p/net-snmp/bugs/2948/.
commit 928f0726ff69a131006d904552ea482a31c6bd69
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jun 28 19:49:57 2019 -0700
ci/net-snmp-configure, MSYS2: Use OpenSSL again
Apparently the previous two patches are sufficient to fix the MSYS2 + OpenSSL
build. Hence re-enable OpenSSL.
This reverts commit e57b0f4f97f0 ("ci/net-snmp-configure, MSYS2: Use the internal OpenSSL implementation")
commit a35c49fa673544e7128efcd0fcbd0ece5cfef979
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jun 23 08:19:48 2018 -0700
configure: Reduce MinGW build time
commit 1d72b9f39dbaa7ad20b41c55ba5d03172503adb5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat May 12 07:51:29 2018 -0700
MSVC: Reduce build time
Define VC_EXTRALEAN and WIN32_LEAN_AND_MEAN. Add additional #include
directives where necessary.
commit e57b0f4f97f0bf5b63f94bd0850bbbbf51c9bebb
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jun 26 08:44:22 2019 -0700
ci/net-snmp-configure, MSYS2: Use the internal OpenSSL implementation
To do: figure out why building with OpenSSL on MSYS2 succeeds locally
but not on AppVeyor.
commit 886c864bba262c3993ea9485ac3d262ef526cf38
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jun 26 14:47:40 2019 -0700
ci/build.sh: Fix the branch name
commit 2e08bbaa915fc5cdcd06a672b778104afb40b132
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat May 19 20:52:10 2018 -0700
snmplib/asprintf.c: Fix header file inclusion order
Include <net-snmp/net-snmp-config.h> first.
commit b51032fd7361775ff851067b0e0ce6d74daf1a41
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jun 23 08:09:34 2018 -0700
MinGW-w64: Suppress more compiler warnings
commit 122245d0c78fecc12bf059b2ae01542dc365f9a1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun May 20 07:47:18 2018 -0700
Win32: Avoid that restart_doit() crashes snmpd
commit f7540763f79dd9d738ed2a388de5004597114632
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat May 19 21:53:41 2018 -0700
MinGW: Rely on the configure script
commit 56d8662c867a47d012920537198de6300017fc02
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jun 23 08:17:21 2018 -0700
snmplib: Define LOG_DAEMON etc. once
commit 71292606c6b7c62a0cb3bdfe63c1bf41fbdb0877
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jun 3 21:00:34 2019 -0700
MSYS2: Fix IPv6 stack type detection
Make sure that the IPv6 stack is detected as "generic" instead of "cygwin".
commit 1d36ff4bc472a7e47de498c65de886b6c5e41fd6
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jun 3 20:55:44 2019 -0700
configure.d/config_project_ipv6_types: Remove dead code
Fixes: 3efbbe9a7fa3 ("configure: Simplify IPv6 stack detection")
commit 2689dfdff5d11169b743ccecc5a4bab9a7d153d7
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jan 20 21:12:44 2019 -0800
configure: Add a test for getlogin()
This patch avoids that the build fails as follows on MinGW64:
snmpping.c:567:13: error: conflicting types for 'getlogin'
const char *getlogin(void)
^~~~~~~~
In file included from /usr/include/unistd.h:4:0,
from ../include/net-snmp/net-snmp-includes.h:34,
from snmpping.c:59:
/usr/include/sys/unistd.h:118:9: note: previous declaration of 'getlogin' was here
char * getlogin (void);
^~~~~~~~
commit cc4a3894e3abdc8e6a4ff6c2c1c1aa67d3449573
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Sep 16 06:17:36 2018 -0700
configure: Remove two commented out tests
commit 011342d8e453b9e0585bf77f659d80c648df8c9f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 18 09:28:14 2018 -0700
snmptrapd: Let configure check for mysql_options()
Let configure check for mysql_options() instead of using mysql_options()
depending on the MySQL version. Only call load_defaults() or
my_load_defaults() if mysql_options() is not available. Parse not_argv[]
only if mysql_options() is not available. This last change fixes
Coverity ID 266336 ("logically dead code").
commit 6972080b8a75aa444a5dc8851dd5d2bc529e3fa3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 18 14:14:14 2018 -0700
configure: Fix detection of the MySQL header files
Fixes: 8e1f21659275 ("CHANGES: snmptrapd: Add support for the latest libmysqlclient version")
commit b5ade7d766e740f7c01ea4ed519b19d85f68773d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jun 22 18:31:05 2018 -0700
configure: Simplify IPv6 stack detection
Combine all v6lib=dummy; v6libdir=none; v6trylibc=yes;
CFLAGS="-DNETSNMP_ENABLE_IPV6 $CFLAGS" cases into a single case.
This patch makes IPv6 detection work on AIX.
commit 15081d4e8f5c6e98f3e46996e9cbae50b7a895fc
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue May 8 14:48:37 2018 -0700
MinGW64: Fix the build
When using Windows sockets, only detect header files that are compatible
with Windows sockets. Exclude any header files that are related to fork().
Do not try to detect socket functions that are defined in non-Winsock
header files.
commit 3abe2c86dd1296a5a3b4563fd930cdc0223abd04
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat May 19 21:12:26 2018 -0700
MinGW: Include the Winsock header files before all other header files
commit 0097fd24427e980a9045f2fed1e7b3aa03e1657c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue May 8 17:34:50 2018 -0700
MinGW: Only use the <sys/...>, <net/...> and <netinet/...> header files if not using <winsock2.h>
Since most <sys/...>, <net/...> and <netinet/...> conflict with the
Winsock header files, only include the former if not using Winsock.
commit 748718eddc9e773d28495bdb93c06fc575a680fd
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 9 05:48:12 2018 -0700
configure.d/config_os_functions: Avoid testing the target OS name directly
commit b7e9a5064a839ed997d5b22ddd2a2a6ca889e0e5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat May 19 21:24:51 2018 -0700
configure.d/config_os_functions: Fix a typo
commit b12c749cc7bea0859e1738da03806c69ff6016c8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jun 23 16:37:36 2019 -0700
ci: Add --with-systemd to the configure options
commit 43c50b997fa39e599bf6c9b04a33f67e8311ced0
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jun 23 16:36:27 2019 -0700
libsnmp: Fix a compiler warning
commit c84d3843bda3a3d85907c0f00291d43c6e9d8d40
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jun 23 15:47:18 2019 -0700
libsnmp: Fix --with-systemd build
See also https://sourceforge.net/p/net-snmp/bugs/2948/.
Reported-by: Jean-christophe Manciot <jcmanciot@users.sourceforge.net>
Fixes: 76336fb63bb7 ("libsnmp/transports: Change multiple sockaddr_in* arguments into netsnmp_ep").
commit ede5c393704dc1d7e0613b97daacce13865683b6
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Jun 20 21:42:35 2019 -0700
AgentX: Limit input size again to 64 KB
This patch avoids that the oss-fuzzer times out. See also
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7280.
See also 46a42549dbae ("AgentX: Reduce stack usage").
commit 2e83dc51f3d91df109eab8d586b14da07009c641
Author: Yahu Gao <yahu.gao@windriver.com>
Date: Mon Jun 10 09:35:03 2019 +0800
snmpd: Remove a duplicate assignment
See also https://sourceforge.net/p/net-snmp/patches/1395/.
Signed-off-by: Yahu Gao <yahu.gao@windriver.com>
[ bvanassche: edited patch description ]
commit 3aebfbab87eb8b385abd5de93cbc45fc9780ad2d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jun 7 21:22:08 2019 -0700
Perl: Fix the session pointer data types
Use void * for session pointers that can have either type struct
session_list * or netsnmp_session *. This patch does not change any
functionality.
commit b590f1bde34b9331cc5270a7f39c839a31d44223
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jun 7 21:39:53 2019 -0700
Perl: Fix single-session support in __snmp_xs_cb()
No matter which API (traditional or single-session) is being used, the
second argument (ss) has the type netsnmp_session *. Hence use snmp_send()
and do not use snmp_sess_send().
commit de19ec6bd12f81e935a986583a9fd9ab0cf7fd62
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jun 7 21:34:57 2019 -0700
Perl: Make _catch work for the single-session API
The type of the session pointer depends on the value of the api_mode
variable. Make the interpretation of the session pointer dependent on
the API mode.
commit 0ef2d7209be7f75a147765e5748ac1dd8f2bb36b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jun 8 18:57:35 2019 -0700
python: Make __send_sync_pdu() set the 'err_num' argument correctly
Fix the type of the session pointer passed to __send_sync_pdu() and also
fix the *err_num assignment.
commit 0da34dc47eb2214e8e137a9cf2757fae1ceee709
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jun 7 06:52:11 2019 -0700
configure: Check for Winsock2 before checking for Cygwin
This patch avoids that the MSYS2 IPv6 stack is recognized as 'cygwin'
instead of 'winsock2'.
commit fd4bb10c3ae046857c5131545ac7c87b4fb8de32
Author: Jon DeVree <nuxi@vault24.org>
Date: Thu Jun 6 19:56:51 2019 -0400
agent, MIBs: Use snmp_close() instead of snmp_sess_close() where required
This patch avoids that closing a session triggers a crash.
See also https://sourceforge.net/p/net-snmp/bugs/2944/ and
https://sourceforge.net/p/net-snmp/patches/1393/.
Fixes: 4641464b4ec2 ("netsnmp_create_v3user_notification_session") # v5.8.
Fixes: 61ac63fa6ee6 ("add missing error handling in notifyTable") # v5.8.
Fixes: de8bc3c2d4ac ("separate notification storage from MIB implementation") # v5.8.pre1~285.
[ bvanassche: edited commit message ]
commit a6ba68ff77ca60260d5f5b007f409d08ce75c3b1
Author: Ming Chen <ming.chen@watchguard.com>
Date: Wed Jun 5 22:48:35 2019 -0700
agent/snmp_agent.c: Fix source code indentation
commit 7384a8b550d4ed4a00e41b72229cfcc124926b06
Author: Ming Chen <ming0903@users.sourceforge.net>
Date: Wed Jun 5 19:58:44 2019 -0700
libsnmp: Fix usm_free_usmStateReference()
See also https://sourceforge.net/p/net-snmp/bugs/2923/.
Fixes: adc9b71aba91 ("snmpd: Avoid that snmpv3 bulkget errors result in a double free")
commit 270c4018e6ee4f5150aecb3b52039e6eeab2c942
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jun 5 19:32:04 2019 -0700
MIBs: Fix netsnmp_get_link_settings()
This patch is based on a patch from Sam Tannous. See also
https://sourceforge.net/p/net-snmp/patches/1387/.
commit 7c2ca346abc13eb0c33d134761b199bcffe753fe
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jun 5 18:56:42 2019 -0700
MIBs: Introduce netsnmp_get_link_settings()
This patch does not change any functionality.
commit 2968b455e6f182f329746e2bca1043f368618c73
Author: Bill Fenner <fenner@gmail.com>
Date: Mon Jun 3 10:01:08 2019 -0700
libsnmp: free filenames from directory listing
Free each filename as we use it, as well as freeing the
list of filenames.
Fixes: 2b3e300ade4a ("CHANGES: libsnmp: Scan MIB directories in alphabetical order")
commit 5280e837dd475fb29d62e0ee4350c3f996467218
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jun 3 21:31:43 2019 -0700
MSYS2: Fix IPv6 stack type detection
Make sure that the IPv6 stack is detected as "generic" instead of "cygwin".
commit 5e1b4a5655dc0041b4e9ce6489f8223e33593201
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jun 2 10:57:09 2019 -0700
ci: Build Windows 64-bit installer and store it as an artefact
commit ed630cf540f662f8a7b6d52787e7ce4482254d75
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jun 2 17:09:48 2019 -0700
win32/dist/build-binary.pl: Search %PATH% for tar.exe and gzip.exe
Additionally, obtain the OpenSSL path from %OPENSSLDIR% and only show
the makensis output if that command fails.
commit 5a865399bebcc34814860e9fa5539cc7f6de04c3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jun 2 10:43:39 2019 -0700
apps/snmpping.c: Include <unistd.h> for getlogin()
commit 5018d4ffcf0168e4d3162cacb44507b2a6bc6362
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jun 2 08:52:03 2019 -0700
apps/snmpusm.c: Avoid that the MSYS2 or MinGW64 build fails
commit a0abab5af9e83ae92bac20f9f8b5118b1d42a5e5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat May 25 17:28:25 2019 +0200
snmplib/snmp_client.c: Document that pdu->securityModel == SNMP_DEFAULT_SECMODEL
commit 20524c9fde900a426536b52983a88a0cc3eb4972
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu May 23 11:08:27 2019 +0200
_snmp_parse(): Call free_securityStateRef() instead of open-coding it
This patch does not change any functionality.
commit 92ccd5a82a019fbfa835cc8ab2294cf0ca48c8f2
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat May 25 16:33:31 2019 +0200
libsnmp: Move the securityStateRef check into free_securityStateRef()
Instead of making each free_securityStateRef() caller check the
securityStateRef pointer, move that check into free_securityStateRef().
commit c268ba41bd42ab78184fc91dd0e705259f644802
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jun 1 21:51:32 2019 -0700
ci/openssl.bat: Bump the OpenSSL version
commit 77b1f7c15ea74e430ca304e61033fdb6fe047ed1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jun 24 19:14:26 2018 -0700
Fix clang compiler warnings
This patch does not change any functionality.
commit 526617cf1ee629fdda48d1702aa90311b9e7a828
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jun 1 09:39:59 2019 -0700
MIBs, apps: Avoid passing NULL to the %s format specifier
This was detected by gcc 9.
commit 6327b217d67a8eb9e5d90f18cc9bbc0c499fe495
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu May 23 22:44:14 2019 +0200
include/net-snmp/types.h: Unbreak the MinGW build
Revert the two most recent changes to this header file to avoid that the MSYS2
build fails as follows:
util_funcs.c:406:1: error: conflicting types for 'get_exec_pipes'
get_exec_pipes(char *cmd, int *fdIn, int *fdOut, netsnmp_pid_t *pid)
^~~~~~~~~~~~~~
In file included from util_funcs.c:91:0:
util_funcs.h:40:17: note: previous declaration of 'get_exec_pipes' was here
int get_exec_pipes(char *cmd, int *fdIn, int *fdOut, HANDLE *pid);
^~~~~~~~~~~~~~
commit e9ce939e41986955ac21bc37dac5c4ed02332c14
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu May 23 10:48:02 2019 +0200
ci/build.sh: Stop dumping config.log
Now that the configure script works reliably for MinGW, stop dumping config.log
upon build failures.
commit f100abcd4dfd386f8c5be2169beed199756404a9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu May 23 10:50:59 2019 +0200
Cygwin: Unbreak the build
Fixes: 48593bb6abd2 ("include/net-snmp/types.h: Include <windows.h> explicitly")
commit 48593bb6abd20f4817504206ac672ee396c02e47
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 22 17:03:51 2019 +0200
include/net-snmp/types.h: Include <windows.h> explicitly
commit 328b1161cac13cecb65a87e3355d1ac483a7f89c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 22 17:22:37 2019 +0200
libsnmp: Simplify snmp_free_pdu()
This patch does not change any functionality.
commit deef46f3d24a038fb383f23f638fed4e05985888
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 22 15:06:11 2019 +0200
libsnmp, MinGW: Fix format specifiers in debug statements
Fixes: 2706f0024dc7 ("libsnmp: Make it easier to verify how the maximum message size is determined").
commit 67c2b92015e5f1c82d9877e4008a7df7f3fdd250
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 22 10:30:10 2019 +0200
configure, MinGW: Make the winsock header file detection more reliable
Avoid that winsock header file detection fails due to <sys/types.h> being
included before a winsock header file. This patch prevents that detecting
a winsock header file fails as follows:
In file included from /usr/include/w32api/winsock.h:36:0,
from conftest.c:163:
/usr/include/w32api/psdk_inc/_fd_types.h:100:2: warning: #warning "fd_set and associated macros have been defined in sys/types. This can cause runtime problems with W32 sockets" [-Wcpp]
#warning "fd_set and associated macros have been defined in sys/types. \
^~~~~~~
Fixes: f0d400c28b54 ("MinGW64: Fix winsock2.h header detection")
commit c77172ae94bde978c18cf02437e0f2d3875ff75a
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 22 10:12:09 2019 +0200
ci/build.sh: Fail the build if "make" fails
Fixes: b3f3cb8b4948 ("ci/build.sh: Dump config.log if 'make' fails")
commit 114e4c2cec2601ca56e8afb1f441520f75a9a312
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 22 10:08:53 2019 +0200
libsnmp: Fix a compiler warning
Avoid that the compiler complains on Windows systems that tmpstr[] is not used.
Fixes: 2b3e300ade4a ("CHANGES: libsnmp: Scan MIB directories in alphabetical order")
commit f142b40a3b885d871959e3f94ccc010043158008
Author: Ming Chen <ming0903@users.sourceforge.net>
Date: Tue May 21 19:36:17 2019 +0200
snmpd: Avoid that CPU usage goes up to 100% while processing a getbulk request
See also https://sourceforge.net/p/net-snmp/bugs/2941/.
[ bvanassche: left out comment and "continue" statements ]
commit 0b32cca60331af47714d3bd369ecdc13e36aa22a
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue May 21 19:34:43 2019 +0200
agent/helpers/table_iterator.c: Adjust source code indentation
commit 66d32cef5ec3b97d59668ff27fb3c1799bb39966
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue May 21 17:39:49 2019 +0200
libsnmp, DTLSUDP: Fix address formatting code
Make sure that a meaningful address is shown with debugging enabled when sending
DTLSUDP data.
commit 4c7c819f7157ca0593fb8b0a87cf094e088e8736
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue May 21 14:44:06 2019 +0200
libsnmp, DTLSUDP: Fix transport constructors
Make sure that the transport constructors return a DTLSUDP transport object
instead of an UDP transport object.
Fixes: d60c3cb2e6af ("NEWS: snmplib: add IPv6 support to DTLSUDP transport CHANGES: snmplib: use new netsnmp_sockaddr_storage in netsnmp_addr_pair CHANGES: snmplib: add base_transport ptr for tunneled transports") # v5.7.rc2~604.
commit 1af6a41824bc4364d5edc3c15b942328300029cc
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue May 21 14:23:39 2019 +0200
snmpd: Fix three memory leaks
Avoid leaking memory if -profile, -name and/or -tag are specified multiple times
in a trapsink, trap2sink or trapsess specification. This was detected by Coverity.
commit 09f2cbaed98012e7e063361d02768161005aaa0f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu May 16 14:32:26 2019 +0200
libsnmp, netsnmp_parse_args(): Fix memory leaks in error paths
commit 42535c3a47066bd8d68aff49e4559fd949dd90bb
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu May 16 14:57:20 2019 +0200
libsnmp, netsnmp_parse_args(): Rework error paths
This patch does not change any functionality.
commit 7576fcde27301d079f37dacb08aba9d0d2b29560
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu May 16 14:40:00 2019 +0200
snmpd: Suppress a false positive Coverity complaint
Avoid that Coverity complains that the third argument passed to memset() exceeds
the size of a single array element.
commit 9d55a7067f21f805aca7c8b58bd68bfeb2c8aef0
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu May 16 14:21:31 2019 +0200
ucd-snmp proxy: Avoid that proxy_fill_in_session() crashes if out of memory
commit 2e4091f4cbe171213a5674246898181f6706941e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu May 16 14:15:25 2019 +0200
libsnmp: Suppress a false positive Coverity complaint
Although it is not required that community strings are '\0' terminated,
Coverity complains about the community string duplication code in _sess_copy().
Make Coverity happy by using strdup() instead of netsnmp_memdup().
commit 9cfb38b0aa95363da1466ca81dd929989ba27c1f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu May 16 13:49:05 2019 +0200
libsnmp: Fix two recently introduced issues in the MIB parsing code
Ensure that the first argument passed to qsort() is not NULL. Free the memory
that holds the directory contents.
Fixes: 2b3e300ade4a ("CHANGES: libsnmp: Scan MIB directories in alphabetical order")
commit d73ebccfe45be49f70ab0a3f5dd298db78c99f6d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu May 16 13:48:03 2019 +0200
AgentX: Fix two use-after-free issues
snmp_add_full() frees the transport if it fails. This was detected by Coverity.
commit 78bf0069ddd24ea0cc716421c53e1daf46da7002
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 15 21:25:46 2019 +0200
CHANGES: libsnmp: Increase the maximum SNMPv3 session receive size from 1472 to 2**31-1 bytes
For the UDP transport this patch increases the maximum message size from 1472
to about 64 KB.
This patch adjusts a limit that was introduced by commit 6e83b3cd891d
("respect msgMaxSize in received v3 PDUs (in the weak sense that if the
serialized response PDU is more than it, we don't send it)") # v5.7.
commit d1f6c87d83f0cef32696f4c4d70b61149e305390
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 15 18:23:59 2019 +0000
testing/fulltests/default/T0221snmpbulkget_large_simple: Make this test more robust
Since sysUpTime may appear in the MIB walk that starts at .1, check whether
sysUpTime occurs at least once in the output instead of checking whether it
occurs exactly five times. Enable several debug options.
commit 2706f0024dc7edbe29ab3f842468bf50a4d069d3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 15 20:24:07 2019 +0200
libsnmp: Make it easier to verify how the maximum message size is determined
This patch only modifies debug log statements.
commit 6066c6e21991ee31ae4fd5eaf791911a31c3432f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri May 17 08:44:08 2019 +0200
libsnmp, snmpv3_packet_build(): Avoid triggering a buffer overflow
commit fac879e83e529bf10b7c91227faa18cafe622d22
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri May 17 08:38:25 2019 +0200
libsnmp, snmpv3_packet_build(): Use sizeof() where appropriate
This patch does not change any functionality.
commit a00eb0515be695786bdc7d839a066e4870064a5a
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue May 14 18:09:25 2019 +0200
perl/SNMP/t/mib.t: Make it easier to enable the debugging code in this test
commit e8f2295bc02e0fc73514efc7c660ed69d689fa68
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue May 14 18:45:33 2019 +0200
perl/SNMP/t/mib.t: Verify the result of all tests
This patch reverts commit 3c0a609e0c24 ("comment out broken tests for now (XXX marked)") # v5.7.
commit 2b3e300ade4add03b889e61d610b0db77d300fc3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 15 14:09:25 2019 +0200
CHANGES: libsnmp: Scan MIB directories in alphabetical order
This guarantees that e.g. mibs/RFC1213-MIB.txt is read before mibs/SNMPv2-MIB.txt.
The order in which these MIBs is read matters because both define sysLocation but
with different attributes.
commit e6a1bbc2304fc0391f479e28946872bf324fb597
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Aug 21 04:52:44 2018 +0000
MIB-II, IPv6: Port to FreeBSD
Compile-tested only.
commit b6f77702dfaf98addf8d3502e86cb30de0fccd13
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 15 09:32:10 2019 +0200
agent/mibgroup/mibII/ipv6.c: Reduce the scope in which 'udb6' and 'tcb6' are visible
This patch does not change any functionality.
commit ee11caa817c5b12c290d01299d2554da87b0ddf7
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 15 10:12:44 2019 +0200
testing/fulltests/tls/STsmPrefix: Specify the snmpd transport endpoint once
Additionally, remove an snmpget invocation of which the output is not used.
Fixes: d75c5a1c4f03 ("useprefix scalar testing and support") # v5.7.
commit 89aecee38ea9afcd1ae0cad98da02832919730ac
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue May 14 21:09:05 2019 +0200
testing/fulltests/default/T0221snmpbulkget_large_simple: Only run this test on Linux systems
commit 785c25da91286b929bcdf196db4a26f10e228bf3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue May 14 17:35:42 2019 +0200
testing/fulltests/default/T0221snmpbulkget_large_simple: Add this test
Add a test for an snmpbulkget with a reply that exceeds the size of a single
Ethernet UDP datagram.
commit b3f3cb8b4948a14663b5071348b95e43a16a4360
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon May 13 18:36:55 2019 +0200
ci/build.sh: Dump config.log if 'make' fails
commit 9f0e0e6266b3316cda548d2870302ca4cd405aec
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue May 14 07:52:38 2019 +0200
testing/fulltests/default/T053trapforwardloop_simple: Improve test robustness
Match both text strings that report trap forwarding.
commit 07270f0a1940734eea992949ea9d751e866896d7
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon May 13 17:54:37 2019 +0200
libsnmp: Remove obsolete comments from the container code
See also commit e2f9573849bd ("CHANGES: snmplib: remove inline versions of container funcs") # v5.7.
commit d21d33cf5693a4ac5a6c88182ec59560019694fe
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun May 12 15:09:21 2019 +0200
win32/Configure: Add the --enable-blumenthal-aes option
See also https://sourceforge.net/p/net-snmp/bugs/2937/.
commit 9cb80e309be7da1b498b4295d8ec81f21b6d209b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat May 11 16:07:30 2019 -0700
testing: Add a test that verifies whether forwarding loops are detected correctly
commit b45782d5632266e86613d9bd5696f0b7fab3ef19
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu May 9 20:14:50 2019 -0700
snmptrapd: Add original sender and forwarder IP addresses to forwarded traps
See also https://sourceforge.net/p/net-snmp/patches/1320/.
[ bvanassche: modified the implementation of this patch significantly; added
a man page description and removed the --add-forwarder-info snmptrapd
command line option ]
commit 3673f3263e4b0d5f0805c557871b3d342289f74f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 8 20:33:48 2019 -0700
ci/before.sh, ci/net-snmp-configure: Extend FreeBSD test coverage
commit 50bccea7cb515dddb1883dfcee6e9100ab9264ce
Author: Ming Chen <ming.chen@watchguard.com>
Date: Wed May 8 10:50:08 2019 -0700
MIB-II: Avoid that snmpd uses 100% CPU for querying network interfaces
snmpd updates its network interface cache data every 3 seconds. If there
is a huge number of virtual interfaces updating the cache takes longer
than 3 seconds. Optimize the code that queries network interfaces by
moving netsnmp_access_ipaddress_ioctl_get_interface_count() out of the
while loop and by calling netsnmp_arch_interface_index_find() only for
IPv6.
Fixes: https://sourceforge.net/p/net-snmp/bugs/2137/
[ bvanassche: fixed coding style issues, rewrote the commit message and
fixed a compiler warning ]
commit 0b88ff97e30db34bacd8375b4d15b0b101c0d57c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 8 17:33:35 2019 -0700
agent/mibgroup/ip-mib/data_access/ipaddress_ioctl.h: Avoid using typedefs
Use struct netsnmp_ipaddress_entry_s instead of the corresponding typedef
such that it becomes easier to include this file.
commit 8f92cadfecedc4bc6bc56c24d8282d11f82b06c3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon May 6 21:20:13 2019 -0700
ci: Improve the code that supports various Windows builds
Install openssl-devel again on MSYS2. Fix the MSYS2 and MinGW32 code for
detecting the OpenSSL version. Disable Python support again for MSYS2.
commit c890caa47876a0da05e69cae1428b65d9ec70478
Author: Bill Fenner <fenner@gmail.com>
Date: Tue May 7 13:10:51 2019 -0700
Avoid off-by-one error when logging "" to a file
commit f9dfc64746c69e4f9cb34837863baa94156f5082
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon May 6 20:15:51 2019 -0700
ci/net-snmp-configure: Detect which software has been installed
Detect which software has been installed instead of hard-coding per
CI environment which options to enable. Fix the OpenSSL and openssh
version checks. Simplify the Python check. Fix the SSL include path
checks on MinGW32 and MinGW64. Fix the test that decides whether or
not to enable Blumenthal AES.
commit 7510e972655f86818eac2944b554396f11a41d1d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon May 6 20:25:34 2019 -0700
.travis.yml: Also install the MariaDB client library
commit 33f8e2e1d63ad5932ade885ffbff379cab1e50bd
Author: Shogo Matsumoto <shogo.matsumoto@jp.fujitsu.com>
Date: Tue May 7 09:41:13 2019 +0900
agent/mibgroup/agentx: Fix double free of delegated cache in agentx_got_response()
If snmpd receives a response from subagent immediately after the agentx
session closed, agentx_got_response() frees delegated cache twice.
This patch changes return value of "response too late on session"
in agentx_got_response function to make the caller of this function
remove the request in order to prevent double free.
See also https://sourceforge.net/p/net-snmp/patches/1392/.
Signed-off-by: Shogo Matsumoto <shogo.matsumoto@jp.fujitsu.com>
[ bvanassche: added patch tracker URL ]
commit be80fdbeb0f21c1ed819f8b80736dab2d093601d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun May 5 20:17:00 2019 -0700
ci/build.sh: Fix Mingw64 package list
commit 068b4686739cc8add671639597bada19d91845a0
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun May 5 19:08:16 2019 -0700
libsnmp: Rework the MDblock() implementation
Avoid that MDblock() modifies its input data buffer on big-endian systems.
commit fc071d97669ccac61d07e28c2b7fd0aacc840ff4
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 29 18:47:07 2019 -0700
ci/build.bat: Add an URL to the Appveyor documentation
commit 2954c4e3c92026b3a6d4c0a0f44e9919b61d20be
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 29 12:25:59 2019 -0700
ci/build.sh: Make the MinGW-w64 build more reliable
Uninstall packages on which the installed packages depend before installing
any packages.
commit bfdccd426c484ec70d80c36c774b2b12b20afec3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 29 10:26:51 2019 -0700
AgentX: Restore another size check
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=14502.
Fixes: 46a42549dbae ("AgentX: Reduce stack usage").
commit a083613bf8da6863ed252fbe0177cadee779ce07
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 29 06:54:33 2019 -0700
libsnmp: Really fix the FreeBSD build
Apparently on FreeBSD 'timezone' is a function instead of a global variable.
Detect the type of 'timezone' and only use its value if it is a scalar.
commit d575c3e77aa951135eca7eabe442d9e90a5b6dad
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 28 21:37:28 2019 -0700
libsnmp: Unbreak the FreeBSD build
Avoid that the FreeBSD build fails as follows:
snmp-tc.c:258:21: error: use of undeclared identifier 'daylight'
tm.tm_isdst = !!daylight;
^
snmp-tc.c:259:15: error: invalid operands to binary expression ('int' and 'char *(*)(int, int)')
tm.tm_sec -= timezone;
~~~~~~~~~ ^ ~~~~~~~~
commit 314ac9a648aa5901dc4daaa3ac04dcc94b0eef5e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 28 21:27:48 2019 -0700
AgentX: Avoid passing a long to abs()
The function abs() namely expects an 'int' as argument.
commit f39d5486bd66adde244fb0c6fbaf8d55e22918cd
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 28 19:49:42 2019 -0700
MSVC: Define the NETSNMP_BIGENDIAN macro
Fixes: 484524cda948 ("configure: Determine endianness at compile time instead of at configure time")
commit d57f431170190c2fd18dea965e8bfc50cd205e02
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 28 18:30:27 2019 -0700
libsnmp, asn_parse_objid(): Avoid reading uninitialized memory
This patch fixes Coverity ID 85590.
commit 88e001fe799e868753f86330a532d94de47f9fe4
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Apr 26 10:31:13 2019 -0700
testing/fulltests/support/simple_run: Reduce the number of 'cd' commands
Make the code easier to read by using explicit paths instead of 'cd'
where appropriate. Remove the SNMP_ORIGDIR variable since it is no
longer necessary.
commit 39121a995d09484766ee5e86137ade1123bea7ab
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 28 17:15:14 2019 -0700
snmplib: Fix tm.tm_isdst check in ctime_to_timet()
This patch fixes Coverity issue 144417.
Fixes: af3fc499f600 ("snmplib: Initialize tm_isdst if available") # v5.8.
commit 484524cda94838dfec8eb1ae92b069ea8ce448f6
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 28 13:40:24 2019 -0700
configure: Determine endianness at compile time instead of at configure time
The new test supports cross-compilation. In other words, --with-endianness
no longer has to be specified during cross-compilation.
commit 4a0886b848855942699758b5cee3e47783bdc4db
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 28 15:41:31 2019 -0700
win32/config.h.borland: Remove this header file because it is obsolete
The most recent version of the Borland compiler was released in 2000 so
it is unlikely that anyone is still using that compiler. Hence remove the
Borland config.h file.
commit 8071426579ca4b00d51fb0c11360ab701e0f9faa
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 28 15:05:05 2019 -0700
testing/fulltests/unit-tests/T008asn1_clib.c: Make the integer encoding test more strict
commit 79857f794c1d2b17d058b949fc8b30632d8c4e40
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 27 21:12:55 2019 -0700
libsnmp, ASN parsing: Avoid triggering undefined shift-left behavior
A quote from https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7199:
So this is a fun corner case of asn.1 integer parsing: the C standard says
that shifting a negative number left has undefined behavior. The other
obvious way to do this is to use the same code on an unsigned long, and
then cast to long. The result of a cast to a signed value is
implementation-defined. Linus Torvalds' argument on this is that there
is no sensible way for the implementation to define it other than "copy
the 2's complement bits".
Avoid triggering all these corner cases by using byte-copying instead of
using shift operations.
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7199
commit 7de049193ab78d9fcdc3baa2c0673bd1e300ed5b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 27 20:53:15 2019 -0700
AgentX: Avoid reading uninitialized data
Fixes: 46a42549dbae ("AgentX: Reduce stack usage")
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=14481
commit 9af3c50c84d24de06c0fa48c9fef721e2490ce49
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 27 16:54:32 2019 -0700
ci/net-snmp-configure: Only set --build=... for MSYS2
commit c43115d39ffc9dfbc55d7c18bb33b17a8847c0d7
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 27 16:31:26 2019 -0700
agent/mibgroup/winExtDLL.c: Fix Mingw64 compiler warnings
Avoid that the Mingw64 compiler complains about incompatible function
casts.
commit 21b0ea844db3e45ec170ddec0bab1cea083e3709
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 27 16:31:16 2019 -0700
agent/mibgroup/util_funcs.c: Fix Windows debug statements
Fixes: 9f4f13c6cb42 ("CHANGES: Win32: BUG: 2779541 Fixed handle leak in pass_persist.") # v5.7.rc2.
commit e6e45da5229fb14768bd4077ca0cd290c1d7e87f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 27 16:38:24 2019 -0700
apps/snmptrapd_handlers.h: Remove an obsolete declaration
Fixes: d10be3eb4be7 ("Remove redundant code.") # v5.7.rc2.
commit 870e553b9a8051ae93f98e8faf977e151773b08b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 27 11:09:47 2019 -0700
apps/encode_keychange: Fix an MSVC compiler warning
Avoid that the compiler reports that _isatty() has not been declared.
commit 0f25cd33500fd104aa4e977b982bdbba2be7d266
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Apr 27 11:01:43 2019 -0700
AgentX, MSVC: Fix a recently introduced build error
Avoid that the following error and warnings are reported:
..\..\agent\mibgroup\agentx\protocol.c(1249): error C2036: 'void *': unknown size
..\..\agent\mibgroup\agentx\protocol.c(1560): warning C4146: unary minus operator applied to unsigned type, result still unsigned
..\..\agent\mibgroup\agentx\protocol.c(1565): warning C4146: unary minus operator applied to unsigned type, result still unsigned
..\..\agent\mibgroup\agentx\protocol.c(1570): warning C4146: unary minus operator applied to unsigned type, result still unsigned
commit 46a42549dbae76e1c2fc284b81c6e6f83ce46831
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 25 16:31:56 2019 -0700
AgentX: Reduce stack usage
Instead of allocating a buffer with the largest supported size on the
stack, allocate a 64 byte buffer on the stack and dynamically allocate
a larger buffer if necessary.
commit 4cdf8314a1ff3ecca3483c0b1a4b7cd92ae03f5c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Apr 26 09:24:41 2019 -0700
AgentX: Fix a debug statement in agentx_realloc_build_string()
Avoid that a debug statement reads past the end of the buffer passed
to this function. This was detected by Valgrind.
commit 004d7d473d9e7a6929ae0f7a9d2f9b96b6c94f4e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Apr 26 07:00:24 2019 -0700
AgentX: Micro-optimize agentx_parse_string()
commit 07c4226435a42c260cd7a17e6c89e9c89a036e6c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Apr 26 08:50:48 2019 -0700
AgentX: Make indentation consistent in _agentx_realloc_build()
commit ecaeda0fff7b2c50661ff170cb1d747641e1f58b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 25 16:31:32 2019 -0700
AgentX: Make agentx_parse_oid() easier to read
Use 64-bit assignments instead of two 32-bit assignments to assign a
64-bit number to a 64-bit variable.
commit d20ace88ceb71c208f2b638b822c6b4359ead0d3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 25 13:11:11 2019 -0700
AgentX: Reduce the number of return statements
This patch does not change any functionality.
commit a0fcb8912153e79170afd34044d0d400e1169164
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 25 09:13:59 2019 -0700
AgentX: Declare pointers that are not modified const
Additionally, declare local functions 'static'.
commit 1710f9f8f8bc2ea3ee1a89bdef11bd311dc86ff8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 25 08:55:48 2019 -0700
AgentX: Remove two superfluous casts
This patch does not change any functionality.
commit 8830aafcab6375e7774004c3049b3d9538a0a641
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Apr 25 10:01:15 2019 -0700
AgentX: Make indentation consistent
This patch only changes the indentation level of the code.
commit e28e19b204e3610b9a04d88034163ee43a97e076
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 24 21:47:51 2019 -0700
Mingw64: Define NETSNMP_PRIz correctly
Older versions of Mingw64 identify as *-w64-* while newer identify as
x86_64-pc-mingw32. Make sure that both are recognized.
commit a18f036972ccecff51059517b29a231e529efa14
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 24 21:39:19 2019 -0700
Remove SCCS and RCS IDs
Since git is used to manage the Net-SNMP source code these IDs are not relevant.
commit 513aff4c5d05f65030e705e39eb7376c224b862b
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Wed Apr 24 22:00:25 2019 +0200
swrun_kinfo: DragonflyBSD does not have KERN_PROC_PROC
commit 09da7e285a2ae8a75905ac49e7ebfb0cffaf5139
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Wed Apr 24 21:57:47 2019 +0200
Fix CentOS6 compile witch does not define ETHTOOL_GLINKSETTINGS
commit 17387a9fc331fba46055894dd8f5eb3e327f310f
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Wed Apr 24 21:55:10 2019 +0200
Not all compilers groks mixed declaration and statements.
commit 54be00a40b3a31917c8825886dc45d0de14b714b
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Wed Apr 24 21:53:48 2019 +0200
Remove a superfluous semicolon.
commit 5ca7193ae1978626d1abf491f777e68bbb88c164
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Wed Apr 24 21:48:05 2019 +0200
Add openbsd6.h to headers to install.
commit 678422d7b8495310fa03e2a1c827b8f0b97fb8b0
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Wed Apr 24 21:29:30 2019 +0200
Proactively add FreeBSD 13, 14
commit 353287249340c40f1ab1f378d3fc746d8579b822
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Wed Apr 24 21:13:57 2019 +0200
mibs/rfclist: Add RFCs 8389, 8502, 8502.
commit 48495424cb8d452ebe87bb1df5f2ae1b1f47f08d
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Wed Apr 24 21:12:46 2019 +0200
Update IANAifType-MIB to current version.
commit 40c319c7bda8cad3d12a8e33297226363e80e879
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 24 06:56:14 2019 -0700
libsnmp: Use a symbolic name for the TLS version
commit a07d20c370736887cbd9b160ce9dade5de539655
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 22 21:02:37 2019 -0700
ci/openssl.bat: Bump the OpenSSL version
commit 814abb9392bf84993b81f0a1b481197c166a297a
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Apr 22 20:45:22 2019 -0700
snmplib: Suppress the "'TLSv1_method' is deprecated" compiler warning
commit f632342cd62ca3a064bd1ebde8858fbba76b9626
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 17 19:21:25 2019 -0700
snmpd: Fix the code for changing DES private keys
See also https://sourceforge.net/p/net-snmp/bugs/2935/.
commit 7f31df7069e0b1dfed7955d5c7f78aa51052e019
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Apr 17 19:33:41 2019 -0700
agent/mibgroup/snmpv3/usmUser.c: Remove the 'alen' variable
commit 456ef19a12678b0f73f74fd947bd13a2df329d92
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 14 21:12:20 2019 -0700
snmplib, Windows: Fix the NETSNMP_IMPORT and NETSNMP_EXPORT definitions
Make sure that global variables are exported. See also
https://sourceforge.net/p/net-snmp/bugs/2934/.
commit 0cf5a779b6e335c48b6d12665c7748d38449bd20
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 14 20:30:50 2019 -0700
snmplib: Fix the build for older versions of Visual Studio
See also https://sourceforge.net/p/net-snmp/bugs/2932/.
commit 21260fdd60c172839f997fb6f888a6e21c6825eb
Author: Changqing Li <changqing.li@windriver.com>
Date: Tue Feb 26 14:26:07 2019 +0800
net-snmp: fix compile error with --disable-des
| scapi.c: In function 'sc_encrypt':
| scapi.c:1256:5: error: 'pad_size' undeclared (first use in this function); did you mean 'dysize'?
| pad_size = pai->pad_size;
| ^~~~~~~~
| dysize
pad_size is defined only without --disable-des
[snip]
#ifndef NETSNMP_DISABLE_DES
int pad, plast, pad_size = 0;
but used when disable-des,
[snip]
QUITFUN(SNMPERR_GENERR, sc_encrypt_quit);
}
pad_size = pai->pad_size;
memset(my_iv, 0, sizeof(my_iv));
#ifndef NETSNMP_DISABLE_DES
if (USM_CREATE_USER_PRIV_DES == (pai->type & USM_PRIV_MASK_ALG)) {
/*
fix by move it into #ifndef NETSNMP_DISABLE_DES
Signed-off-by: Changqing Li <changqing.li@windriver.com>
commit abdcb6af8df352a257a7092c1649471af1e4e97b
Author: Douglas Royds <douglasr@users.sourceforge.net>
Date: Sun Apr 14 19:56:24 2019 -0700
CHANGES: snmpd: Accept null NETSNMP_CONFIGURE_OPTIONS from the environment
Make it possible to avoid that build host paths end up in Net-SNMP binaries
by accepting a null NETSNMP_CONFIGURE_OPTIONS environment variable.
commit 5ccd784e0f7bb16b3f2daa77814087e90af3c321
Author: Roger Bertilsson <rogge@users.sourceforge.net>
Date: Sun Apr 14 19:47:48 2019 -0700
snmpd: Fix a typo in the snmpusm.1.def man page
See also https://sourceforge.net/p/net-snmp/patches/1386/.
commit ec9f61461e82d203e24b8e5b431190a40b27ea6d
Author: Vasile-Laurentiu Stanimir <vlstanimir@gmail.com>
Date: Sun Apr 14 19:21:32 2019 -0700
CHANGES: snmpd: Use ETHTOOL_GLINKSETTINGS when available
Newer Linux kernels support ETHTOOL_GLINKSETTINGS. Use it when available
instead of the older and deprecated ETHTOOL_GSET. This patch avoids that
the Linux kernel reports the following kernel warning:
warning: 'snmpd' uses legacy ethtool link settings API, link modes are only partially reported
See also https://sourceforge.net/p/net-snmp/patches/1387/.
[bvanassche: reworked this patch significantly]
commit d6689d6a938e29e02f1964bc7d7a15103817c0fa
Author: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
Date: Mon Apr 8 19:56:04 2019 -0400
snmplib/snmp_api: Remove the request on the session when the sending is failed
snmpd is terminated abnormally due to an invalid memory access after
the sending of a request is failed.
The time out callback for the failed request is executed when the
session is closing because the request remains in the internal session.
The cleanup for the request is executed on the
callback(NETSNMP_CALLBACK_OP_SEND_FAILED,) and also on the time out
callback(NETSNMP_CALLBACK_OP_TIMED_OUT,), so the wrong memory access
happens.
Remove the failed request from the internal session after the callback
for the failed request is done.
Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
Reported-by: Shogo Matsumoto <shogo.matsumoto@jp.fujitsu.com>
commit 408c8919e36feb4e9c1024e74d3b8c77454d89a0
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 14 18:57:17 2019 -0700
snmplib: Introduce the function remove_request()
This patch does not change any functionality.
commit d9b2acc48efc3b5098cde5a7b89cf81a3e1988fa
Author: Anders Wallin <anders.wallin@windriver.com>
Date: Sun Apr 14 18:30:48 2019 -0700
test: Skip TLS-TCP IPv6 test for OpenSSL versions before 1.1.0
See also https://sourceforge.net/p/net-snmp/patches/1382/.
Signed-off-by: Anders Wallin <anders.wallin@windriver.com>
[ bvanassche: edited patch description; combined two version checks into one ]
commit 69253ba63cfaaaacc10942aad360449b2a081681
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Apr 14 17:30:50 2019 -0700
snmpd: Fix --disable-snmpv1 build
See also https://sourceforge.net/p/net-snmp/bugs/2924/.
Fixes: e422fbfb09cd ("more checks for disabling protocol versions at runtime").
commit 7f88b06bf0f4140bc03cabacd35eaeffdf21d722
Author: Anders Wallin <wallinux@gmail.com>
Date: Sun Apr 7 18:31:16 2019 -0400
agentx/master: Return when NETSNMP_CALLBACK_OP_RESEND is set to the callback
snmpd is terminated abnormally due to the double free for the
request cache after the request is resend.
That is because the callback for NETSNMP_CALLBACK_OP_RESEND isn't
cared and the cache is freed wrongly.
Let's just return if NETSNMP_CALLBACK_OP_RESEND is set on the
callback.
Fixes: b7b50bbac ("snmp_send callback updates")
Signed-off-by: Anders Wallin <wallinux@gmail.com>
commit 6e1329bde834e0edcfadb88d3c05e6015e945638
Author: Hugh McMaster <hugh.mcmaster@outlook.com>
Date: Wed Apr 3 21:36:03 2019 +1100
NEWS: Add pkg-config support for building applications and sub-agents
Use the netsnmp package when building Net-SNMP applications.
Use the netsnmp-agent package when building Net-SNMP subagents.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
[ bvanassche: edited makefile code and .pc files; added ./configure changes ]
commit adc9b71aba9168ec64149345ea37a1acc11875c6
Author: Sam Tannous <stannous@cumulusnetworks.com>
Date: Wed Apr 10 06:57:21 2019 -0700
snmpd: Avoid that snmpv3 bulkget errors result in a double free
See also https://sourceforge.net/p/net-snmp/bugs/2923/.
See also https://sourceforge.net/p/net-snmp/patches/1388/.
commit 30fb24e6cd9ac495fb7cfa0e32e5eea39c2b29ab
Author: Narendra Kumar S S <ssnkumar@users.sourceforge.net>
Date: Mon Apr 8 09:17:52 2019 -0700
CHANGES: BUG: 2930: Fix a Solaris hrSWInst crash
Avoid that snmpd crashes on Solaris when querying software packages
with an empty CATEGORY field.
See also https://sourceforge.net/p/net-snmp/bugs/2930/.
See also https://sourceforge.net/p/net-snmp/patches/1390/.
commit 9f4af8c42d515e6b214738cc97212dfbe7f749cf
Author: Andreas Hasenack <ahasenack2@users.sourceforge.net>
Date: Tue Feb 5 18:21:40 2019 -0800
apps/snmptrapd_sql: Fix build against MySQL 8
See also https://sourceforge.net/p/net-snmp/bugs/2922/.
[bvanassche: changed 'int' into 'char']
commit b9a778df08315500958fd83d11b4a123aaeec753
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Aug 4 21:43:59 2018 -0700
testing/fulltests/snmpv3/T010scapitest_capp.c: Port this test to FreeBSD
commit 36fda7476cc26e44af84a679b8448b8629886dc2
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Jan 29 20:58:38 2019 -0800
ci: Skip tests that do not pass
Instead of not building transports that do not pass, skip the tests
that are known to fail.
commit f727d51b0fa485f93ffd57112442271716042cd7
Author: Anders Wallin <wallinux@gmail.com>
Date: Mon Jan 28 18:59:08 2019 -0800
testing/fulltests/tls/STlsAgentTrap: Test both TRAP and INFORM
Additionally, use localCert / peerCert instead of the deprecated
our_hostname / their_hostname. Remove incorrect comments and superfluous
configuration directives.
commit e926b1cec44ee769618440719dbcc92bb68f7aa7
Author: Anders Wallin <wallinux@gmail.com>
Date: Mon Jan 28 18:57:40 2019 -0800
libsnmp, TLS: Change default TLS version from v1.3 into v1.1
See also https://sourceforge.net/p/net-snmp/bugs/2920/.
Fixes: d686bc3502f1 ("CHANGES: snmplib: Add support for OpenSSL 1.1.0")
commit d1300ee69c6ff91779229fd4fba4b5141106ff9e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jan 27 18:27:27 2019 -0800
ci: Fix and enable MinGW64 build
commit a9fa5dcf2fa238db0538df2213878fa6e6b559dc
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jan 27 21:05:28 2019 -0800
ci/net-snmp-run-perl-tests: Make the Perl tests pass again
Fixes: 41b5927a8b53 ("testing: Unbreak RUNFULLTESTS")
commit 927040dd4ff9601f12ba7d082279b5d35c3d6031
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jan 23 18:47:56 2019 -0800
ci, Appveyor: Rename MinGW64 build into MSYS2
Since that build uses the MSYS2 compiler, rename it into MSYS2. The
MinGW64 build has been commented out because it does not yet pass.
commit 1d714a0d9f2f712afdcb9b7ba75222fcc46292af
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jan 23 20:59:55 2019 -0800
README.win32: Fix a MinGW64 package name
commit 5a86cfb005dbc3dc495c7eb216ac1faaac00a069
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jan 23 20:40:00 2019 -0800
testing: Unbreak RUNFULLTESTS
Make it again possible to run RUNFULLTESTS from outside ci/net-snmp-run-tests.
Fixes: 9b1535bfb140 ("testing, perl: Remove push @INC statements")
commit 2d3bb48b00fca7fff0f63dd065742f01ecd8f79f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jan 20 19:40:34 2019 -0800
.appveyor.yml: Verify whether or not the MinGW64 build succeeded
Now that building against MinGW64 works for Appveyor, check the build
exit status. Disable the regression tests because these do not yet pass.
commit 58649949f37aa5f37a4a624a715043f7b48215f7
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Jan 15 20:52:59 2019 -0800
testing/check_for_pskill, MinGW64: Skip pskill test
MinGW64 namely provides a proper kill command.
commit e0cfa7c84b1db81b0ad07066bab0d87b4f131991
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Jan 17 20:12:04 2019 -0800
ci/net-snmp-configure, MinGW64: Enable openssl at configure time
commit 7cdbaad9295467392a8264febaf42583991817f6
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jan 19 12:47:34 2019 -0800
ci/build.bat, MinGW32: Make downloading succeed
Avoid that downloading fails every now and then as follows:
curl: (16) Error in the HTTP2 framing layer
commit d2e2624156cb3195efa9a69bdb03d48f5d6782ab
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jan 20 21:36:27 2019 -0800
ltmain.sh, MinGW64: Fix a linker error
Avoid that linking fails as follows with certain MinGW64 versions:
./.libs/lt-snmpps.c: In function 'main':
./.libs/lt-snmpps.c:315:10: warning: implicit declaration of function '_spawnv' [-Wimplicit-function-declaration]
rval = _spawnv (_P_WAIT, lt_argv_zero, (const char * const *) newargz);
^~~~~~~
./.libs/lt-snmpps.c:315:19: error: '_P_WAIT' undeclared (first use in this function); did you mean '__VALIST'?
rval = _spawnv (_P_WAIT, lt_argv_zero, (const char * const *) newargz);
^~~~~~~
__VALIST
commit 2ff6a360f79dd63a7569fda8e4714dd9139ea136
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jan 20 16:41:06 2019 -0800
snmplib/winservice.c: Move local data types and function declarations from .h into .c
commit 14b5618f31cdeedd0ff4e4a8d6ff2aeefe9f235d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jan 20 14:21:44 2019 -0800
snmplib/winservice.c: Use ANSI C datatypes and functions
Use int, void and char instead of INT, VOID and TCHAR. Use snprintf()
instead of _sntprintf(). Note: using Microsoft's "Unicode" (UCS-2) mode
is considered obsolete. See also https://utf8everywhere.org/.
commit abecab9327fd496d79332256990ade53745e49e0
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jan 20 14:13:35 2019 -0800
snmplib/winservice.c: Reindent
Reindent this source file with the help of the indent command mentioned in
the CodingStyle file.
commit 1882e55c2f9e2c42eb7a75176710173774c34d3c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jan 20 21:12:44 2019 -0800
configure: Add a test for getlogin()
This patch avoids that the build fails as follows on MinGW64:
snmpping.c:567:13: error: conflicting types for 'getlogin'
const char *getlogin(void)
^~~~~~~~
In file included from /usr/include/unistd.h:4:0,
from ../include/net-snmp/net-snmp-includes.h:34,
from snmpping.c:59:
/usr/include/sys/unistd.h:118:9: note: previous declaration of 'getlogin' was here
char * getlogin (void);
^~~~~~~~
commit 03c98e3d4e7e459ed4e925c22f9cc4b181ded3eb
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jan 20 08:48:43 2019 -0800
libsnmp, agent, apps, MinGW64: Only use those MSVC functions that are available
_get_osfhandle() is available in the MSVC and MinGW32 C libraries but not
in the MinGW64 C library. Hence add a configure test for _get_osfhandle()
and only use it if it is available.
commit 98eb60dcaf13d5bc8513a785df21bd164ff04c35
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Jan 20 18:41:52 2019 -0800
agent/mibgroup/util_funcs: Reindent uClinux code
Make the uClinux code indentation conform to the Net-SNMP coding style.
Change exit(0) statements in the parent into return 0 to make the behavior
of get_exec_pipes() more uniform across platforms.
commit 90d91fa1943bbc4e9c18ba19e30ccf49b2be78ff
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jan 21 08:53:58 2019 -0800
apps/snmptrapd: Fix a MinGW64 compiler warning
Avoid that the compiler complains about passing a struct timeval pointer to
a function that expects a struct __ms_timeval pointer.
commit 5da4fc8c8e0849ba0997b16657430675283904e8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri May 11 21:55:56 2018 -0700
MinGW64: Fix select() and ioctlsocket() calls
See also https://github.com/mirror/mingw-w64/blob/master/mingw-w64-headers/include/psdk_inc/_ip_types.h.
commit 5250c5f62c573308ab8ecd62366eceaa488a85f6
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri May 11 22:08:14 2018 -0700
configure.d/config_os_libs2: Remove redundant checks
Instead of using both AC_CHECK_DECL() and AC_CHECK_FUNCS() to check for
EVP_sha224() and EVP_sha384(), only use AC_CHECK_FUNCS().
commit c7a330e6adefedbd7393401f55243b2b8313afb2
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jan 21 12:54:57 2019 -0800
apps/agentxtrap.c: Fix a MinGW64 compiler warning
Avoid that the following compiler warning is reported:
agentxtrap.c: In function 'main':
agentxtrap.c:576:52: warning: passing argument 5 of 'select' from incompatible pointer type [-Wincompatible-pointer-types]
count = select(numfds, &fdset, NULL, NULL, !block ? &timeout : NULL);
^
In file included from ../include/net-snmp/system/mingw32.h:29:0,
from ../include/net-snmp/net-snmp-config.h:2194,
from agentxtrap.c:1:
/usr/include/w32api/winsock2.h:995:34: note: expected 'PTIMEVAL {aka struct __ms_timeval * const}' but argument is of type 'struct timeval *'
WINSOCK_API_LINKAGE int WSAAPI select(int nfds,fd_set *readfds,fd_set *writefds,fd_set *exceptfds,const PTIMEVAL timeout);
^~~~~~
commit b8cb73951f9204417c43105a27a5335ecbcddda1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jan 21 12:52:47 2019 -0800
apps/agentxtrap.c: Declare local variables static
commit 9f3d055ff8523618ae57373e28dacbe33a0c25d6
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jan 21 12:40:32 2019 -0800
apps/agentxtrap.c: Reindent to make the code conform to the coding style
commit 53a971debbe6c04a41fbe8ce792a778c739174c8
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jan 21 13:26:10 2019 -0800
agent/mibgroup/util_funcs.c: Fix MinGW32 compiler warnings
Avoid that the compiler complains about passing a DWORD (unsigned long int)
to the %d format specifier.
commit 45d848dbbf06797f4ff2eca9a576f3c5cad6bb1e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jan 21 20:19:13 2019 -0800
README.win32: Improve MinGW64 instructions
commit 2baa87b2bfd772b62fa1864903afe101fc2e4946
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Jan 1 19:31:40 2019 -0800
ci: Add support for Cirrus CI and FreeBSD
commit 241304ef7132a2c04f135ea8a3463e29e6e46496
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jan 12 08:53:14 2019 -0800
ci: Port three scripts from bash to sh
commit 744ae09fd0a38f4634195197ab201442516559c5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jan 12 19:46:05 2019 -0800
testing, Perl: enable use strict and use warnings
commit 9b1535bfb140697dff985ce8feaaa939069b7ac1
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jan 12 19:31:28 2019 -0800
testing, perl: Remove push @INC statements
These statements are not necessary if $PERL5LIB is set before these
tests are run.
commit ba0505329f18424899c96589bd20c4f5c739aa17
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jan 12 19:21:59 2019 -0800
testing: Skip DTLS-UDP tests if DTLS-UDP transport is not available
Fixes: 0b8b11504729 ("testing for checking client side verification of server certificates")
commit e566d5d792c003f4f67f83a0deb6b482ae694ab5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jan 12 17:01:22 2019 -0800
testing/RUNFULLTESTS: Only run Perl and Python tests if support for these languages has been enabled
commit 3be8ca102a3c13237b499ef5c7f80dde9f2f5fa3
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jan 12 20:42:04 2019 -0800
testing/RUNFULLTESTS: Enable 'use warnings'
Additionally, fix two bugs: assign the exit code of the $cfp_path
script to $rc instead of its output and make decide_exec() return
early if there is no app extension.
commit 04e59874c135b7bc8fcad73057c8b75bc0ec2f9b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jan 12 08:51:38 2019 -0800
testing/fulltests/support/simple_eval_tools.sh: Improve tmp file dumping
Avoid showing the contents of temporary files twice that are shorter
than 512 lines if a test fails.
commit 969e9a7391067b3829bad7b88918f60c4944a22e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Jan 2 06:50:55 2019 -0800
testing/fulltests/support/simple_TESTCONF.sh: Increase MAX_RETRIES
This patch avoids that regression tests sporadically fail due to not
finding an UDP port that is not in use.
commit baf47f3e1e3f0c2397ba074a0245d4b3b442a9b6
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jan 12 15:28:11 2019 -0800
perl: Avoid "use of uninitialized value $ENV{"OSTYPE"}" warnings
The bash shell sets the OSTYPE environment variable but FreeBSD sh not.
Hence check whether $OSTYPE has been set before using its value.
commit e1c6ec5a73bc67b3b6139479fa7a0b7e985b47ca
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Jan 3 21:14:57 2019 -0800
snmplib/snmpksm: Fix OLD_HEIMDAL compiler warnings
Avoid that the following compiler warnings are reported for OLD_HEIMDAL:
snmpksm.c:486:21: warning: unused variable 'blocksize' [-Wunused-variable]
size_t blocksize, encrypted_length;
^
snmpksm.c:1769:21: warning: assigning to 'u_char *' (aka 'unsigned char *') from 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
*parms->scopedPdu = (char *) output.data;
^ ~~~~~~~~~~~~~~~~~~~~
snmpksm.c:1249:34: warning: unused variable 'blocksize' [-Wunused-variable]
size_t cksumlength, blocksize;
^
commit 611b485ea14541c1e04afb812c88a1bcdf203396
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jan 12 08:30:36 2019 -0800
agent/auto_nlist: Fix a FreeBSD compiler warning
Avoid that the following compiler warning is reported on FreeBSD 10 systems:
auto_nlist.c:56:22: warning: unused variable 'n_name' [-Wunused-variable]
static char *n_name = NULL;
^
commit 944c75959517c66dc12fe5c713b5904abb05343d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Jan 12 08:30:32 2019 -0800
agent/auto_nlist: Enclose a code block in curly braces
Other than leaving out a superfluous if-test this patch does not change
any functionality. The purpose of this patch is to make the next patch
easier to read.
commit 7d66a35cd6bf86ca9e8070751cfba9ce97eddd6b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Jan 14 18:39:45 2019 -0800
configure: Enable shared library support for FreeBSD 10 and later
See also https://lists.freebsd.org/pipermail/freebsd-current/2013-March/040460.html.
commit e4e1d25dae34f5a9aeff13c83008d89794211ab0
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Dec 16 12:29:11 2018 -0800
README.win32: Update this document
Change "Microsoft Visual C++" into "Microsoft Visual Studio".
Remove all references to the Microsoft Platform SDK since that SDK
has been integrated in the Windows SDK. Remove all references to .dsp
files since these files are no longer maintained. Update all outdated
instructions. Add build instructions for Mingw-w64.
commit fccd5f13ce825c813944a555dfbdb36c3eddc21f
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Dec 16 12:29:09 2018 -0800
README.win32: Strip trailing whitespace
commit a79439a2fe185864183252b7c59d008b1f031b70
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jan 11 19:16:15 2019 -0800
man/snmpd.conf.5.def: Document that monitor names must be unique
Reported-by: Masanari Iida <standby24x7@gmail.com>
commit 79f014464ba761e2430cc767b021993ab9379822
Author: Wes Hardaker <opensource@hardakers.net>
Date: Tue Jan 8 08:52:29 2019 -0800
NEWS: snmptrap: BUG: 2899: Patch from Drew Roedersheimer to set library engineboots/time values before sending
commit dc3194eaecb4545a0364fe4a565f1c0d001835a7
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Dec 28 18:58:45 2018 -0800
libsnmp/transports/UDP: Remove MSG_NOSIGNAL
Remove MSG_NOSIGNAL from the UDP code because it does not affect SOCK_DGRAM
sockets. From the sendto() specification
(http://pubs.opengroup.org/onlinepubs/9699919799/functions/sendto.html):
"[EPIPE] The socket is shut down for writing, or the socket is
connection-mode and is no longer connected. In the latter case, and if
the socket is of type SOCK_STREAM or SOCK_SEQPACKET and the MSG_NOSIGNAL
flag is not set, the SIGPIPE signal is generated to the calling thread."
commit 3ca90c2c1260e036a5abd73a40f83d4ded545580
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Dec 28 11:57:11 2018 -0800
libsnmp/transports/UDP: Add support for VRF
This patch is based on a patch provided by Sam Tannous. See also
https://sourceforge.net/p/net-snmp/patches/1354/.
commit 3dce73c8833a74aab30046155ab50a1c95edd893
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Dec 28 11:56:40 2018 -0800
libsnmp/transports/UDP: Reduce indentation level
This patch does not change any functionality.
commit a74d7087e536cfa3b74a77647fa73a49c742f1c4
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Dec 28 11:34:25 2018 -0800
libsnmp: Split netsnmp_udpbase_sendto()
This patch does not change any functionality but makes the implementation
of this function easier to read.
commit 9e29c8da35041520a58614281eb504bb91990177
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Dec 28 11:05:52 2018 -0800
testing/fulltests/support/simple_eval_tools.sh: Show file name above file contents if a test fails
See also commit 0d828eed1fb5 ("testing/fulltests/support/simple_eval_tools.sh: Dump log files in case of test failure").
commit 0b52f2ed1de081c1b8682d55c9c6cde973af7630
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed May 9 08:12:41 2018 -0700
testing/fulltests/support/simple_eval_tools.sh: Dump log files in case of test failure
This makes it easier to determine the root cause of tests that fail
on Travis or Appveyor.
commit 35fcadf5ba23a14a994ac5a963a02b3558a998ec
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Dec 28 09:41:20 2018 -0800
testing/fulltests/support/myip: Avoid using IO::Socket::IP
Since IO::Socket::IP is not available on Travis Darwin instances, rewrite
'myip' such that it doesn't use IO::Socket::IP.
commit 472a30e1a49dd2cbfaf63f5571249124064e4671
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Dec 27 21:53:25 2018 -0800
ci: Move Travis before_script shell code into ci/before.sh
This makes it easier to maintain this code.
commit 8d1894314ad1dff67124d50c9f9fa071ac3abb99
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Dec 27 21:28:07 2018 -0800
libsnmp/asn1.c: Minimize diffs with the master branch
See also commit 7aceb7a49264 ("libsnmp, FreeBSD: Fix the build") on the
v5.8 branch and commit b97a0417a235 ("MSVC: Reduce build time") on the
master branch.
commit ac65c73a90369f725959c820af8579627ec6f965
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Dec 27 16:57:11 2018 -0800
ci/net-snmp-configure: Make the code for querying the OpenSSL and libssh2 versions more robust
commit 7aceb7a4926430576d2253a5b2e00d9809389fdd
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Dec 28 00:12:13 2018 +0000
libsnmp, FreeBSD: Fix the build
commit 77972cc90d1ef18f93c81284f5a1623947f55a94
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Dec 27 23:55:30 2018 +0000
NetBSD: Fix two compiler warnings in MIB implementations
commit 024c6316eb1f37a7c3645e0a15032173d04e2c11
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Dec 27 15:05:47 2018 -0800
SNMP-TARGET-MIB, FreeBSD: Hide kernel threads
See also https://sourceforge.net/p/net-snmp/bugs/2890/.
See also https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231732.
Signed-off-by: Ben Rubson <benrubson@users.sourceforge.net>
commit 178e3240cb880ddb5489ce3eb5c7a4371cebf288
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jun 8 10:46:22 2018 +0200
SNMP-TARGET-MIB: Fix the debug code that shows tAddress
Since tAddress contains binary data, show it in hex instead of as an
ASCII string.
commit 67dbffc04db36be6bd654b8472262e4c1850319e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Dec 17 19:35:00 2018 -0800
snmplib, transports, Darwin: Fix compiler warnings
Avoid that the compiler complains about implicit declarations of
strdup(), strchr() and strlcpy().
commit 29f03b11f527c874cc01afa5293eb9bb790b9798
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Dec 17 18:49:18 2018 -0800
libsnmp, Windows: Fix a recently introduced compiler warning
Since sin6_scope_id has been declared as unsigned long on Windows,
cast it to int before passing it to the %d format specifier.
Fixes: f3d96c8c45f9 ("libsnmp: Add two additional debug statements in the code for parsing IPv6 addresses")
commit bb4631cfbaefbea8b29c4716e858d1467d588541
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Dec 16 19:30:19 2018 -0800
testing/fulltests/support/myip: Also return IPv6 scope ID
This is necessary to let the tests based on S180trapaddrinfra pass.
commit f3d96c8c45f91a193883c7b669b78eec6d2b3242
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Dec 16 19:54:51 2018 -0800
libsnmp: Add two additional debug statements in the code for parsing IPv6 addresses
commit c602f9527ea63aaafa40f400e1e14dcd4113ae66
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Dec 16 19:53:48 2018 -0800
libsnmp: Fix the code for parsing the IPv6 scope ID
Fixes: 0b637fea62c7 ("libsnmp/transports: Introduce netsnmp_parse_ep_str()")
commit 64f4ead817c4c018f9f811442565feac656fc0e9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Dec 16 14:51:44 2018 -0800
libsnmp: Only include <inttypes.h> when necessary
This helps to reduce the Net-SNMP compilation time.
commit 7d6ab1439d5d8cb09801c184ef17882cb62ba28d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Dec 16 16:44:52 2018 -0800
ci/openssl.bat: Update OpenSSL version
commit de7f76855c53e9a184f3ec6015c680fd13b03fae
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Dec 16 14:51:25 2018 -0800
ci/build.sh: Remove CFLAGS / CPPFLAGS / LDFLAGS definitions
These definitions are not necessary when building with MinGW and break
the build when building with Mingw-w64.
commit cd09fd82522861830aaf9d237b26eef5f9ba50d2
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Nov 21 20:47:42 2018 -0800
MIB-II: Only log once that opening /proc/net/if_inet6 failed
If IPv6 has been disabled (ipv6.disable=1) then opening /proc/net/if_inet6
fails. Only log this once instead of thousand of times a day.
Reported-by: Fif <lefif@users.sourceforge.net>
commit 4eab854c9759be79ad56497445210f60bbc6b50d
Author: Anders Wallin <anders.wallin@windriver.com>
Date: Mon Nov 19 16:27:59 2018 +0100
snmpd: Fix handling of trapsess option -tag
The trapsess argument '-tag' is not recognized due to an incorrect string
length. Fix that length.
See also https://sourceforge.net/p/net-snmp/patches/1383/.
Fixes: 6b7350749490 ("allow trap sinks to set name, tag, profile")
Signed-off-by: Anders Wallin <anders.wallin@windriver.com>
[ bvanassche: edited commit message ]
commit de590a1a47f610ed0701c19f62c2e92c0d4a535f
Author: Anders Wallin <wallinux@gmail.com>
Date: Thu Aug 30 11:22:31 2018 +0200
libsnmp/transports/DTLSUDP: Fix a typo in a debug token
See also https://sourceforge.net/p/net-snmp/patches/1381/.
Fixes: a9a619e0d173 ("CHANGES: snmplib: dtls: overhaul of debug")
Signed-off-by: Anders Wallin <wallinux@gmail.com>
[ bvanassche: edited commit message ]
commit f651cfa36569ab95d1bc817b3bd1289cdb15a5ea
Author: Anders Wallin <wallinux@gmail.com>
Date: Mon Oct 22 09:05:45 2018 +0200
tests: Add a delay in STlsVars
Avoid that the STlsVars tests fail due to checking whether a trap has been
received before it has been sent.
See also https://sourceforge.net/p/net-snmp/patches/1380/.
Signed-off-by: Anders Wallin <wallinux@gmail.com>
[ bvanassche: edited commit message ]
commit 8fd3780f99ae50f33dd1216597bb8b6be271507d
Author: lijo <lijogeorge@users.sourceforge.net>
Date: Mon Nov 19 18:33:26 2018 -0800
snmpd: Avoid that parsing "trapsess ... -e ..." triggers a memory leak
See also https://sourceforge.net/p/net-snmp/patches/1379/.
See also https://sourceforge.net/p/net-snmp/bugs/2887/.
[ bvanassche: reduced the number of changes in this patch from four to one ]
commit a5282f41db0cb339666fb0db8590085e69464be6
Author: Anders Wallin <wallinux@gmail.com>
Date: Mon Jun 25 10:48:51 2018 +0200
libsnmp: Include disabled debug tokens in NET-SNMP-AGENT-MIB::nsDebugTokenStatus
See also https://sourceforge.net/p/net-snmp/patches/1371/.
Signed-off-by: Anders Wallin <wallinux@gmail.com>
commit b0f497b84aa28a754ad7ce260c63092dd85a584d
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Nov 19 18:59:03 2018 -0800
snmpd, MIB-II: Fix a recently introduced compiler warning
Avoid that the compiler reports the following on Linux:
mibII/tcpTable.c:341:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
Fixes: 61c373a9a357 ("Forward port FreeBSD 12 patches")
commit f42a4af67a00deb1b11748b944e45de9e2415c50
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Mon Nov 19 21:39:58 2018 +0100
hr_disk: include sys/disk.h is not cosher for DragonFly
commit 2bbad43c53ffe040f02bc6269e32368edd7c6ca7
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Wed Nov 14 22:01:52 2018 +0100
Patch for cpu_sysctl for FreeBSD 12.
Patch taken from FreeBSD ports collection.
commit 61c373a9a3571ea3f63a2762e43ddb0c9273ce64
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Wed Nov 14 21:45:26 2018 +0100
Forward port FreeBSD 12 patches
commit bdfdc84b67124f530cdae9f295fa3906021ebf8e
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Tue Nov 13 23:06:17 2018 +0100
Update IANAifType-MIB to current IANA version
commit 5e9bf8c69f8b3fe5f49c3402f8d5865a4aa0ed24
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Tue Nov 13 22:57:32 2018 +0100
Minor hr_disk fixes for FreeBSD/NetBSD.
commit 38dfa1db7b3f60862bdf01d95aac807f222146ab
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Tue Nov 13 22:43:21 2018 +0100
Fix hr_disk for newer FreeBSD and NetBSD.
commit e48ead2dff1820b8fb7aadf2293b24303659ac26
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Tue Nov 13 22:00:46 2018 +0100
Update IANAifType-MIB to current IANA version.
commit fcecebf8f0fc894c351c82fda87693d76eebf994
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Tue Nov 13 21:55:34 2018 +0100
Patch for udpEndpointTable for FreeBSD 12.
Patch take from FreeBSD ports collection.
commit 64074f086957ec6dc45f73e67f5007e4eea0734d
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Tue Nov 13 21:54:52 2018 +0100
Patch for udpTable for FreeBSD 12.
Patch take from FreeBSD ports collection.
commit 27e21bee375723ba6b88cbd2d52b9c40206a1e9a
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Tue Nov 13 21:53:04 2018 +0100
Patch for tcpConnTable for FreeBSD 12
Patch taken from FreeBSD ports collection.
commit 7f3abe7515d585e089ddddf9a30762451b95aa44
Author: Niels Baggesen <nba@users.sourceforge.net>
Date: Tue Nov 13 21:51:24 2018 +0100
Patch for tcpTable for FreeBSD 12
Patch taken from Freebsd ports collection.
commit 1f7a794ece5f8e0754c2d584bdee89ed002921c6
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Nov 9 07:07:51 2018 -0800
libsnmp, transports: Log an error message if parsing "clientaddr" fails
commit 70488e36d3a686d2956464b68043bac62ae2be64
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Nov 8 14:40:11 2018 -0800
snmplib, transports: Make the IPv6 address parsing code closer to the IPv4 equivalent
commit ebac62b66e35197ee036ea5967c4d4ff91bf1b4a
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Nov 8 11:24:51 2018 -0800
snmplib, transports: Move the code for recognizing bare IPv6 addresses into netsnmp_parse_ep_str()
This patch makes Net-SNMP recognize endpoint specifications like ::1@lo next
to the already supported [::1]@lo.
commit 0d4d74bcc3e35ed55a6653db71ad2b187a64f3b0
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Nov 8 12:03:01 2018 -0800
libsnmp, transports: Only recognize non-empty strings as a number
commit 5abe5322404b72c2df2344948be28def710eccca
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Nov 7 16:45:52 2018 -0800
libsnmp, transports, UDP/IPv6: Simplify netsnmp_udp6_transport()
This patch does not change any functionality.
commit a21587438825a6658bca214425240aae473df9ff
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Nov 8 13:26:36 2018 -0800
libsnmp, transports: Simplify netsnmp_udpipv4base_transport()
This patch does not change any functionality.
commit b25536962f81dc4b4e03f3a12b2e847c23fb36a9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Nov 8 14:09:00 2018 -0800
man/snmp.conf.5.def: Improve clientaddrUsesPort documentation
commit 8cbb36da6ef4e82f0521ff0cf3f4b1424e49d21b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Nov 8 10:30:59 2018 -0800
snmplib, transports: Remove NETSNMP_TSPEC_NO_DFTL_CLIENT_ADDR
Since this flag is never set, remove it. Also remove the code that depends
on this flag being set.
Fixes: 5d8372341594 ("shared transport + udp shared domain")
commit a240e46cdaf189f2c74b6b465ffbc09d6c697088
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Nov 8 10:33:07 2018 -0800
snmplib, transports: Remove NETSNMP_TSPEC_SHARED
Since this flag is not used anywhere in the Net-SNMP code base, remove it.
Fixes: 5d8372341594 ("shared transport + udp shared domain")
commit d566ac2930f66c42dec1a20503b25a3b12902911
Author: Bill Fenner <fenner@gmail.com>
Date: Thu Nov 8 10:45:15 2018 -0800
Go back to testing ::1, without brackets, for IPv6.
commit 48a1163640a651ad035523a9673ab6e20adf7dfc
Author: Bill Fenner <fenner@gmail.com>
Date: Thu Nov 8 10:43:33 2018 -0800
Parse a bare IPv6 address, which netsnmp_parse_ep_str() won't.
commit 06a02b7c708c1ea2bf67e59c333001e8ce128dff
Author: Bill Fenner <fenner@gmail.com>
Date: Thu Nov 8 10:42:58 2018 -0800
Specify the default port of ":0" when parsing source addresses.
commit 280d6c16e847f0204663ccfe81063c5f7da215e9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Nov 7 06:58:22 2018 -0800
testing, T18[0123]: Synchronize with master branch
commit bb1e817b3b83c3e22951a815689964dc235f5d54
Author: Bart Van Assche <bvanassche@acm.org>
Date: Wed Nov 7 06:47:50 2018 -0800
testing/fulltests/default/S180trapaddrinfra: Use again the default port
Since the purpose of the T18* tests is to use the default port, remove
the PROBE_FOR_PORT calls again.
commit 5d94f6baff0f05dd4976cbbf0fef64ecf70cf881
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Nov 6 19:59:20 2018 -0800
testing, T18[012345]: Make it possible to run these tests as a regular user
commit 8169acab64012fe0026e8a47a054e16a4c20621e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Tue Nov 6 19:37:35 2018 -0800
libsnmp/transports: Change the meaning of ":0" back to "any port"
commit 1809c8c0aa33ab48f2e5217d9dafcca87b032a6c
Author: Bill Fenner <fenner@gmail.com>
Date: Tue Nov 6 13:06:33 2018 -0800
Fix clientaddr for v6 traps by zeroing the port number
This is the same thing that snmpUDPIPv4BaseDomain.c does
in the same place: zeroes out the port number when parsing
the clientaddr.
commit 29d3a54c189e63cab1d15987e07ec8fe8fb76e84
Author: Bill Fenner <fenner@gmail.com>
Date: Tue Nov 6 13:05:52 2018 -0800
Fix typo: test IPv6, not IPv4.
commit 4833c4ff7d479fd3554eeafa1cd4b23f52dfc7f5
Author: Bill Fenner <fenner@gmail.com>
Date: Tue Nov 6 13:05:28 2018 -0800
Fix UDP/IPv6 address parsing. Add default tracing.
commit 7be7d70719dea95a55b29b4fa3a7c29a7e7c946b
Author: Bill Fenner <fenner@gmail.com>
Date: Tue Nov 6 12:17:24 2018 -0800
Add some default tracing for trap source tests
commit b7d00beeed42137aa5b2b3c93014059e8d67db2b
Author: Bill Fenner <fenner@gmail.com>
Date: Tue Nov 6 12:09:23 2018 -0800
Fix typo: test v6
commit 9de0984a4c2502f2d548c9e9332cc04267b4c026
Author: Bill Fenner <fenner@gmail.com>
Date: Tue Nov 6 11:58:14 2018 -0800
Add trap source tests for "trapsess -s"
commit 223de5eb19c95866e7c50c6d022f25cbdb22f816
Author: Bill Fenner <fenner@gmail.com>
Date: Tue Nov 6 11:54:22 2018 -0800
Bind to the address that we chose above, not just to the session address
commit 6f6d85d27b2c1d42d05173633cea95916ab11cda
Author: Bill Fenner <fenner@gmail.com>
Date: Tue Nov 6 11:12:21 2018 -0800
Tests for setting the source address of trap messages
commit 379cfa157e51fe51a802a3554fc7f268efeb74dc
Author: Bill Fenner <fenner@gmail.com>
Date: Tue Nov 6 08:16:16 2018 -0800
Avoid logging "unknown snmp version" for agentx
commit 313949522c4d0ddfeac72195fa63512955d9eb28
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Nov 2 21:12:24 2018 -0700
libnsmp/transports: Fix the Darwin build
Avoid that the Darwin build fails as follows:
transports/snmpIPBaseDomain.c:9:12: error: static declaration of 'isnumber' follows non-static declaration
static int isnumber(const char *cp)
^
/usr/include/ctype.h:323:1: note: previous definition is here
isnumber(int _c)
^
commit 62f6babcc7cfc54c79b442b8a7f45662b4ddc807
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Oct 28 12:43:33 2018 -0700
testing/fulltests/unit-tests: Add netsnmp_parse_ep_str() unit test
commit 0831ed64a39a34dc040eabe39d0229b07fa2a8a5
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Oct 26 19:25:47 2018 -0700
libsnmp/transports: Add support for interface binding
commit c7398de4122102b3250e6dac7c09dbc5d09f1840
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Oct 27 20:42:47 2018 -0700
configure: Add a test for SO_BINDTODEVICE
commit 76336fb63bb74b4dede5dda5c14fb8cf2d60be8e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Oct 25 21:13:13 2018 -0700
libsnmp/transports: Change multiple sockaddr_in* arguments into netsnmp_ep
Make this change for all internal transport functions that will need
the network interface information. This patch does not change any
functionality.
commit 19ba7b0a6b56d201a8563fe6505cd82e313c1c9c
Author: Bart Van Assche <bvanassche@acm.org>
Date: Thu Oct 25 19:53:04 2018 -0700
libsnmp/transports: Introduce netsnmp_sockaddr_in3() and netsnmp_sockaddr_in6_3()
Introduce functions for converting Net-SNMP endpoint definitions into
struct netsnmp_ep. Calls to these functions will be added in a later
patch.
commit 0b637fea62c7b6dc467b94206d0bd2dec6f912ca
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Oct 22 21:07:14 2018 -0700
libsnmp/transports: Introduce netsnmp_parse_ep_str()
The only functional change in this patch is that it is now allowed
to surround IPv4 addresses and hostnames with square brackets in
transport endpoint definitions.
commit b5c62f2dc1df5e97d635eab55286190d2acceae4
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Oct 28 14:27:21 2018 -0700
ci: Disable brew upgrade openssl in travis.yml because it fails often
commit 9b637efe809c490fdcaf30d1af20b4cbaef76e3e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Oct 27 20:34:21 2018 -0700
libsnmp/transports: Fix netsnmp_udp6_transport()
Only create a transport object if parsing the client address succeeded
instead of creating a transport object when parsing the client address
failed.
Fixes: 5d8372341594 ("shared transport + udp shared domain")
commit 22884099f55d0bf33ba5953b5e3dbc24fac8214a
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Oct 26 21:45:32 2018 -0700
libsnmp/transports: Unexport functions that are only used inside libsnmp
This only affects the non-Cygwin Windows builds.
commit 1e0856b3cc0336aea3a75076c491e98113c38990
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Jun 22 22:06:41 2018 -0700
MinGW64: Fix the NETSNMP_PRIz detection code
commit e03dd5b6b906eb8cee8a08a52c69598e07875d1e
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon May 7 07:02:51 2018 -0700
snmplib/read_config: Fix a compiler warning
commit d20012cb9158153c66ddd5ce024e129b3e15e349
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun May 20 20:06:30 2018 -0700
configure: Fix the netsnmp_cv_size_t_type check
Avoid that the following error message appears if size_t == long long:
configure: line 26619: [: too many arguments
commit f0b8f2c17707a3526132cfcdfa2056ffd1eea5b7
Author: Bart Van Assche <bvanassche@acm.org>
Date: Mon Oct 22 21:06:24 2018 -0700
libsnmp/transports: Introduce netsnmp_resolve_v6_hostname()
Other than changing the debug label from netsnmp_sockaddr_in6_2 into
netsnmp_sockaddr_in6, this patch does not change any functionality.
commit fc286dc029054d292edc303146b2a07df40cf1fa
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Oct 26 19:47:40 2018 -0700
libsnmp/transports: Make TCP transport error handling more systematic
This patch does not change any functionality.
commit d0c22996629dabee9b416ffdaafaa740075dae8b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Oct 21 20:19:06 2018 -0700
libsnmp/transports: Remove several superfluous assignments
Since the C language guarantees that static objects are zero-initialized,
assigning NULL to a member of such an object is superfluous. Leave out
several such superfluous NULL assignments.
commit 06b7af9798a521e2ed1f88bcf62e550202d4095b
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sun Oct 21 20:54:23 2018 -0700
libsnmp/transports/snmpIPv6BaseDomain.c: Remove some trailing whitespace
commit d1ea7513559b66f17593f52b16a90977ca0da999
Author: Bart Van Assche <bvanassche@acm.org>
Date: Fri Oct 26 18:43:03 2018 -0700
libsnmp/snmp_transport.c: Document the origin of the format of ostring variables
commit 159b13e99fcdd32f273e0c3018d092b91f45c8e9
Author: Bart Van Assche <bvanassche@acm.org>
Date: Sat Oct 27 07:46:50 2018 -0700
MinGW64: Fix UDP transport build
Avoid that the MinGW64 build fails as follows:
transports/snmpUDPBaseDomain.c: In function 'netsnmp_udpbase_sendto':
transports/snmpUDPBaseDomain.c:290:16: error: 'struct in_pktinfo' has no member named 'ipi_spec_dst'
Mr. DellatioNx196 GaLers xh3LL Backd00r 1.0, Coded By Mr. DellatioNx196 - Bogor BlackHat